fix pending diff race condition when join is still pending #8788
SteffenDEci.yml
on: pull_request
Matrix: e2e test
Matrix: mix_test
Matrix: npm test
Matrix: coverage report
Annotations
2 errors, 10 warnings, and 1 notice
|
[webkit] › tests/errors.spec.js:265:5 › exception handling › after connected mount › parent crashes and reconnects when linked child LV crashes:
test/e2e/tests/errors.spec.js#L273
2) [webkit] › tests/errors.spec.js:265:5 › exception handling › after connected mount › parent crashes and reconnects when linked child LV crashes
Error: expect(received).toEqual(expected) // deep equality
Expected: ArrayContaining [StringMatching /mount/, StringMatching /child error: unable to join/, StringMatching /child destroyed/, StringMatching /error: view crashed/, StringMatching /mount/, StringMatching /child mount/]
Received: ["phx-GF09-WOXPq63ltlh mount: - {0: content=\"OCdTOzEfOQQ0CDkeOAQaeiU4JD4NbAwhrn7vTQwlN8UtmrC6vWhpb8_S\", 1: undefined, p: undefined, s: 2}", "child error: unable to join - {reason: join crashed}", "child destroyed: the child has been removed from the parent - undefined", "phx-GF09-WOXPq63ltlh error: view crashed - {}", "phx-GF09-WOXPq63ltlh mount: - {0: content=\"OyJJOgobHycRRAVHGRJoNiQlGDY1NwURqk-woUQOkti-Ld1zwJTxZcVc\", 1: undefined, p: undefined, s: 2}"]
271 | // child crashed on mount, linked to parent -> parent crashed too
272 | // second mounts are successful
> 273 | expect(consoleMessages).toEqual(
| ^
274 | expect.arrayContaining([
275 | expect.stringMatching(/mount/),
276 | expect.stringMatching(/child error: unable to join/),
at /__w/phoenix_live_view/phoenix_live_view/test/e2e/tests/errors.spec.js:273:31
|
|
[firefox] › tests/forms.spec.js:220:7 › /form/nested - form recovery › phx-auto-recover:
test/e2e/tests/forms.spec.js#L0
1) [firefox] › tests/forms.spec.js:220:7 › /form/nested - form recovery › phx-auto-recover ───────
Error: browserContext.newPage: Target page, context or browser has been closed
|
|
npm test (1.18.4, 27.3):
test/e2e/tests/issues/3083.spec.js#L29
Unexpected use of page.waitForTimeout()
|
|
npm test (1.18.4, 27.3):
test/e2e/tests/forms.spec.js#L134
Avoid calling `expect` conditionally`
|
|
npm test (1.18.4, 27.3):
test/e2e/tests/forms.spec.js#L133
Avoid having conditionals in tests
|
|
npm test (1.18.4, 27.3):
test/e2e/tests/errors.spec.js#L147
Unexpected use of page.waitForTimeout()
|
|
npm test (1.18.4, 27.3):
test/e2e/tests/errors.spec.js#L118
Unexpected use of page.waitForTimeout()
|
|
npm test (1.18.4, 27.3):
test/e2e/tests/errors.spec.js#L67
Unexpected use of page.waitForTimeout()
|
|
npm test (1.18.4, 27.3):
test/e2e/tests/components.spec.js#L77
Unexpected use of the `.skip()` annotation
|
|
npm test (1.18.4, 27.3):
test/e2e/tests/components.spec.js#L76
Avoid having conditionals in tests
|
|
npm test (1.18.4, 27.3):
test/e2e/tests/components.spec.js#L36
Unexpected use of the `.skip()` annotation
|
|
npm test (1.18.4, 27.3):
test/e2e/tests/components.spec.js#L35
Avoid having conditionals in tests
|
|
🎭 Playwright Run Summary
2 flaky
[firefox] › tests/forms.spec.js:220:7 › /form/nested - form recovery › phx-auto-recover ────────
[webkit] › tests/errors.spec.js:265:5 › exception handling › after connected mount › parent crashes and reconnects when linked child LV crashes
3 skipped
442 passed (3.8m)
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
e2e-test-results
Expired
|
4.19 MB |
sha256:01d2d1333b907800a4ba778ae557162edadd49612f1c675a6d57d2769d08757f
|
|
|
js-unit-coverage
Expired
|
852 KB |
sha256:4fe54ae50fd1c53be16848d3318634a4b8fc3cd59f059766b74bc7f3c23f8079
|
|
|
mix-e2e-coverage
Expired
|
105 KB |
sha256:e07cff15dd7552ba1e40435c68296efb30c48692a8b6c672f77dd6511498d656
|
|
|
mix-test-coverage-25.3-1.15.4
Expired
|
156 KB |
sha256:cb8bb9affdd45080c91601ee4a168bda2a922009f6c7acdba7b58a6548f5bbf9
|
|
|
mix-test-coverage-26.2-1.16.3
Expired
|
153 KB |
sha256:9c1340bfd8f26627e7892538bcf246507a27d572a01bd3b069c0684f331f905a
|
|
|
mix-test-coverage-27.3-1.18.4
Expired
|
102 KB |
sha256:f1dbf11721002b3380451eb314dd0c2ae6f814e934cfbb75048eb1bb449535d0
|
|
|
mix-test-coverage-maint-28-main-otp-28
Expired
|
103 KB |
sha256:5307b7491dc58d660d8e2dce9be3407aea9764e19beb8c755337d60cd5b3c407
|
|
|
overall-coverage
Expired
|
1.55 MB |
sha256:9a8ba09f2d43ab51284b954b94ddff7b7c8b44a214b5a6ab62c520169383347b
|
|
|
playwright-report
Expired
|
1.07 MB |
sha256:c5a7bc6d7dffde30cc4ee275d0fd7d4d0fc25c8810c258280d8e530a7fa2b3e9
|
|