Skip to content

Commit 512b382

Browse files
authored
Ensure list when converting to lazy (#3934)
Closes #3927.
1 parent 859f59d commit 512b382

File tree

3 files changed

+12
-1
lines changed

3 files changed

+12
-1
lines changed

lib/phoenix_live_view/test/dom.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ defmodule Phoenix.LiveViewTest.DOM do
146146
@doc """
147147
Turns a tree into a lazy.
148148
"""
149-
def to_lazy(tree), do: LazyHTML.from_tree(tree)
149+
def to_lazy(tree), do: LazyHTML.from_tree(List.wrap(tree))
150150

151151
@doc """
152152
Escapes a string for use as a CSS identifier.

test/phoenix_live_view/integrations/elements_test.exs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -457,6 +457,13 @@ defmodule Phoenix.LiveView.ElementsTest do
457457
assert from_element.meta.submitter == from_selector.meta.submitter
458458
end
459459

460+
test "put_submitter/2 works on forms without IDs", %{live: view} do
461+
view
462+
|> element("form[data-name='form-without-id']")
463+
|> put_submitter("[name=button]")
464+
|> render_submit()
465+
end
466+
460467
describe "render_submit" do
461468
test "raises if element is not a form", %{live: view} do
462469
assert_raise ArgumentError, "phx-submit is only allowed in forms, got \"a\"", fn ->

test/support/live_views/elements.ex

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -234,6 +234,10 @@ defmodule Phoenix.LiveViewTest.Support.ElementsLive do
234234
<button name="button_no_value">Button No Value</button>
235235
</form>
236236
237+
<form data-name="form-without-id" phx-submit="form-submit">
238+
<button name="button" type="submit">button</button>
239+
</form>
240+
237241
<form
238242
id="trigger-form-default"
239243
phx-submit="form-submit-trigger"

0 commit comments

Comments
 (0)