Remove phx-update=append/prepend in tests (#3724)

This has been deprecated long before v1.0 and,
while we kept some support to ease migration,
it is time to push away from it.

Author: josevalim

lib/phoenix_live_view/test/dom.ex

@@ -439,51 +439,9 @@ defmodule Phoenix.LiveViewTest.DOM do
     end
   end
 
-  defp apply_phx_update(type, html_tree, {tag, attrs, appended_children} = node, _streams)
-       when type in ["append", "prepend"] do
-    container_id = attribute(node, "id")
-    verify_phx_update_id!(type, container_id, node)
-    children_before = apply_phx_update_children(html_tree, container_id)
-    existing_ids = apply_phx_update_children_id(type, children_before)
-    new_ids = apply_phx_update_children_id(type, appended_children)
-
-    content_changed? =
-      new_ids != existing_ids
-
-    dup_ids =
-      if content_changed? && new_ids do
-        Enum.filter(new_ids, fn id -> id in existing_ids end)
-      else
-        []
-      end
-
-    {updated_existing_children, updated_appended} =
-      Enum.reduce(dup_ids, {children_before, appended_children}, fn dup_id, {before, appended} ->
-        patched_before =
-          walk(before, fn {tag, _, _} = node ->
-            cond do
-              attribute(node, "id") == dup_id ->
-                new_node = by_id!(appended, dup_id)
-                {tag, attrs(new_node), child_nodes(new_node)}
-
-              true ->
-                node
-            end
-          end)
-
-        {patched_before, Floki.filter_out(appended, "##{dup_id}")}
-      end)
-
-    cond do
-      content_changed? && type == "append" ->
-        {tag, attrs, updated_existing_children ++ updated_appended}
-
-      content_changed? && type == "prepend" ->
-        {tag, attrs, updated_appended ++ updated_existing_children}
-
-      !content_changed? ->
-        {tag, attrs, updated_appended}
-    end
+  defp apply_phx_update(type, _html_tree, _node, _streams) when type in ["append", "prepend"] do
+    raise ArgumentError,
+          "phx-update=#{inspect(type)} has been deprecated before v1.0 and is no longer supported in tests"
   end
 
   defp apply_phx_update("stream", html_tree, {tag, attrs, appended_children} = node, streams) do

test/phoenix_live_view/test/dom_test.exs

@@ -143,92 +143,6 @@ defmodule Phoenix.LiveViewTest.DOMTest do
       assert new_html =~ ~S(<div id="4">a</div>)
     end
 
-    test "inserts new elements when phx-update=append" do
-      html = """
-      <div data-phx-session="SESSIONMAIN"
-                     data-phx-main="true"
-                     id="phx-458">
-      <div id="list" phx-update="append">
-        <div id="1">a</div>
-        <div id="2">a</div>
-        <div id="3">a</div>
-      </div>
-      </div>
-      """
-
-      inner_html = """
-      <div id="list" phx-update="append">
-        <div id="4" class="foo">a</div>
-      </div>
-      """
-
-      {new_html, _removed_cids} =
-        DOM.patch_id("phx-458", DOM.parse(html), DOM.parse(inner_html), [])
-
-      new_html = DOM.to_html(new_html)
-
-      assert new_html =~ ~S(<div id="1">a</div>)
-      assert new_html =~ ~S(<div id="2">a</div>)
-      assert new_html =~ ~S(<div id="3">a</div><div id="4" class="foo">a</div>)
-    end
-
-    test "inserts new elements when phx-update=prepend" do
-      html = """
-      <div data-phx-session="SESSIONMAIN"
-                     data-phx-main="true"
-                     id="phx-458">
-      <div id="list" phx-update="append">
-        <div id="1">a</div>
-        <div id="2">a</div>
-        <div id="3">a</div>
-      </div>
-      </div>
-      """
-
-      inner_html = """
-      <div id="list" phx-update="prepend">
-        <div id="4">a</div>
-      </div>
-      """
-
-      {new_html, _removed_cids} =
-        DOM.patch_id("phx-458", DOM.parse(html), DOM.parse(inner_html), [])
-
-      new_html = DOM.to_html(new_html)
-
-      assert new_html =~ ~S(<div id="4">a</div><div id="1">a</div>)
-      assert new_html =~ ~S(<div id="2">a</div>)
-      assert new_html =~ ~S(<div id="3">a</div>)
-    end
-
-    test "updates existing elements when phx-update=append" do
-      html = """
-      <div data-phx-session="SESSIONMAIN" data-phx-main="true" id="phx-458">
-        <div id="list" phx-update="append">
-          <div id="1">a</div>
-          <div id="2">a</div>
-          <div id="3">a</div>
-        </div>
-      </div>
-      """
-
-      inner_html = """
-      <div id="list" phx-update="append">
-        <div id="1" class="foo">b</div>
-        <div id="2">b</div>
-      </div>
-      """
-
-      {new_html, _removed_cids} =
-        DOM.patch_id("phx-458", DOM.parse(html), DOM.parse(inner_html), [])
-
-      new_html = DOM.to_html(new_html)
-
-      assert new_html =~ ~S(<div id="1" class="foo">b</div>)
-      assert new_html =~ ~S(<div id="2">b</div>)
-      assert new_html =~ ~S(<div id="3">a</div>)
-    end
-
     test "patches only container data attributes when phx-update=ignore" do
       html = """
       <div data-phx-session="SESSIONMAIN" data-phx-main="true" id="phx-458">