Skip to content

Commit df94671

Browse files
committed
remove outdated phx-portal validation
1 parent 24d117b commit df94671

File tree

1 file changed

+2
-18
lines changed

1 file changed

+2
-18
lines changed

lib/phoenix_live_view/tag_engine.ex

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1607,14 +1607,14 @@ defmodule Phoenix.LiveView.TagEngine do
16071607

16081608
defp validate_tag_attrs!(_attrs, _meta, _state), do: :ok
16091609

1610-
# Check if `phx-update`, `phx-hook` or `phx-portal` is present in attrs and raises in case
1610+
# Check if `phx-update`, `phx-hook` is present in attrs and raises in case
16111611
# there is no ID attribute set.
16121612
defp validate_phx_attrs!(attrs, meta, state) do
16131613
validate_phx_attrs!(attrs, meta, state, nil, false)
16141614
end
16151615

16161616
defp validate_phx_attrs!([], meta, state, attr, false)
1617-
when attr in ["phx-update", "phx-hook", "phx-portal"] do
1617+
when attr in ["phx-update", "phx-hook"] do
16181618
message = "attribute \"#{attr}\" requires the \"id\" attribute to be set"
16191619

16201620
raise_syntax_error!(message, meta, state)
@@ -1627,19 +1627,6 @@ defmodule Phoenix.LiveView.TagEngine do
16271627
defp validate_phx_attrs!([{:root, _, _} | t], meta, state, attr, _id?),
16281628
do: validate_phx_attrs!(t, meta, state, attr, true)
16291629

1630-
defp validate_phx_attrs!(
1631-
[{"phx-portal", _, _} | _t],
1632-
%{tag_name: tag_name} = meta,
1633-
state,
1634-
_attr,
1635-
_id?
1636-
)
1637-
when tag_name != "template" do
1638-
message = "\"phx-portal\" is only allowed on <template> tags"
1639-
1640-
raise_syntax_error!(message, meta, state)
1641-
end
1642-
16431630
defp validate_phx_attrs!([{"id", _, _} | t], meta, state, attr, _id?),
16441631
do: validate_phx_attrs!(t, meta, state, attr, true)
16451632

@@ -1679,9 +1666,6 @@ defmodule Phoenix.LiveView.TagEngine do
16791666
defp validate_phx_attrs!([{"phx-hook", _, _} | t], meta, state, _attr, id?),
16801667
do: validate_phx_attrs!(t, meta, state, "phx-hook", id?)
16811668

1682-
defp validate_phx_attrs!([{"phx-portal", _, _} | t], meta, state, _attr, id?),
1683-
do: validate_phx_attrs!(t, meta, state, "phx-portal", id?)
1684-
16851669
defp validate_phx_attrs!([{special, value, attr_meta} | t], meta, state, attr, id?)
16861670
when special in ~w(:if :for :type) do
16871671
case value do

0 commit comments

Comments
 (0)