prevent crash when passing * to ignore_attributes (#3997)

Closes #3996.

Author: SteffenDE

assets/js/phoenix_live_view/js.js

@@ -334,6 +334,7 @@ const JS = {
             attrs.some(
               (toIgnore) =>
                 attr.name == toIgnore ||
+                toIgnore === "*" ||
                 (toIgnore.includes("*") && attr.name.match(toIgnore) != null),
             )
           ) {

assets/test/view_test.ts

@@ -1003,6 +1003,47 @@ describe("View + DOM", function () {
       expect(view.el.firstChild.getAttribute("data-new")).toBe("new");
       expect(view.el.firstChild.textContent.replace(/\s+/g, "")).toEqual("A1");
     });
+
+    test("ignore_attributes *", () => {
+      let liveSocket = new LiveSocket("/live", Socket);
+      let el = liveViewDOM();
+      let updateDiff = {
+        "0": ' phx-mounted="[["ignore_attrs",{"attrs":["open","*"]}]]"',
+        "1": ' data-foo="foo" data-bar="bar"',
+        "2": "0",
+        s: [
+          "<details",
+          "",
+          ">\n    <summary>A</summary>\n    <span>",
+          "</span></details>",
+        ],
+      };
+
+      let view = simulateJoinedView(el, liveSocket);
+      view.applyDiff("update", updateDiff, ({ diff, events }) =>
+        view.update(diff, events),
+      );
+
+      expect(view.el.firstChild.tagName).toBe("DETAILS");
+      expect(view.el.firstChild.open).toBe(false);
+      view.el.firstChild.open = true;
+      view.el.firstChild.setAttribute("data-foo", "bar");
+      view.el.firstChild.setAttribute("data-other", "also kept");
+      view.el.firstChild.setAttribute("something", "else");
+      // apply diff
+      view.applyDiff(
+        "update",
+        { "1": 'data-foo="foo" data-bar="bar" data-new="new"', "2": "1" },
+        ({ diff, events }) => view.update(diff, events),
+      );
+      expect(view.el.firstChild.open).toBe(true);
+      expect(view.el.firstChild.getAttribute("data-foo")).toBe("bar");
+      expect(view.el.firstChild.getAttribute("data-bar")).toBe("bar");
+      expect(view.el.firstChild.getAttribute("something")).toBe("else");
+      expect(view.el.firstChild.getAttribute("data-other")).toBe("also kept");
+      expect(view.el.firstChild.getAttribute("data-new")).toBe("new");
+      expect(view.el.firstChild.textContent.replace(/\s+/g, "")).toEqual("A1");
+    });
   });
 });