Fix problem with the negation (apache#10971)

shukitchan · phongn · commit 143c73e8306e · 2024-02-01T11:01:55.000-08:00
diff --git a/lib/swoc/src/TextView.cc b/lib/swoc/src/TextView.cc
@@ -63,7 +63,12 @@ svtoi(TextView src, TextView *out, int base) {
         out->assign(start, parsed.data_end());
       }
       if (neg) {
-        zret = -intmax_t(std::min<uintmax_t>(n, ABS_MIN));
+        uintmax_t temp = std::min<uintmax_t>(n, ABS_MIN);
+        if (temp == ABS_MIN) {
+          zret = std::numeric_limits<intmax_t>::min();
+        } else {
+          zret = -intmax_t(temp);
+        }
       } else {
         zret = std::min(n, ABS_MAX);
       }

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,12 @@ svtoi(TextView src, TextView *out, int base) {`
`63`	`63`	`out->assign(start, parsed.data_end());`
`64`	`64`	`}`
`65`	`65`	`if (neg) {`
`66`		`- zret = -intmax_t(std::min<uintmax_t>(n, ABS_MIN));`
	`66`	`+ uintmax_t temp = std::min<uintmax_t>(n, ABS_MIN);`
	`67`	`+ if (temp == ABS_MIN) {`
	`68`	`+ zret = std::numeric_limits<intmax_t>::min();`
	`69`	`+ } else {`
	`70`	`+ zret = -intmax_t(temp);`
	`71`	`+ }`
`67`	`72`	`} else {`
`68`	`73`	`zret = std::min(n, ABS_MAX);`
`69`	`74`	`}`