Merge pull request #450 from afshin/issue-449

sccolbert · web-flow · commit 5eea83bf58a1 · 2019-11-05T07:43:10.000-06:00
Bail if widget to be removed is not found in GridLayout. Fixes #449.
diff --git a/packages/widgets/src/gridlayout.ts b/packages/widgets/src/gridlayout.ts
@@ -350,7 +350,7 @@ class GridLayout extends Layout {
     let i = ArrayExt.findFirstIndex(this._items, it => it.widget === widget);
 
     // Bail if the widget is not in the layout.
-    if (i !== -1) {
+    if (i === -1) {
       return;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -350,7 +350,7 @@ class GridLayout extends Layout {`
`350`	`350`	`let i = ArrayExt.findFirstIndex(this._items, it => it.widget === widget);`
`351`	`351`
`352`	`352`	`// Bail if the widget is not in the layout.`
`353`		`- if (i !== -1) {`
	`353`	`+ if (i === -1) {`
`354`	`354`	`return;`
`355`	`355`	`}`
`356`	`356`