Skip to content

Commit c883482

Browse files
committed
Clarify docs, examples, and integration notes
Update documentation and small API docs to clarify integration and example policy: - Mark publishability roadmap as completed and add detailed progress/remaining notes (PUBLISHABILITY_ROADMAP.md). - Explain that examples are repo-only due to Xtensa flashing/toolchain requirements (README.md). - Add DHCP link troubleshooting guidance to examples README (apps/examples/README.md). - Tweak module doc comments to reference feature-gated esp-hal/integration facades (src/boards/mod.rs, src/driver/mod.rs). These changes improve discoverability and reduce confusion about example packaging and integration feature flags.
1 parent 0603ba5 commit c883482

File tree

5 files changed

+27
-3
lines changed

5 files changed

+27
-3
lines changed

PUBLISHABILITY_ROADMAP.md

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,9 +111,11 @@ Last updated: 2026-02-08
111111

112112
**Goal**: Present a clear, minimal integration story with current examples and docs.
113113

114+
**Status**: ✅ Completed
115+
114116
**Work items**
115117
- **Root documentation pass**
116-
- Add “happy path” snippets for esp-hal (WT32-ETH01), embassy-net, and smoltcp.
118+
- Add “happy path” snippets for esp-hal (WT32-ETH01) and esp-hal async.
117119
- Add a concise **feature-flag matrix** (what each flag unlocks).
118120
- Add a **memory/footprint** section (DMA descriptor counts, buffer sizes, defaults).
119121
- Ensure all docs use the correct crate name and current API (no legacy references).
@@ -125,6 +127,20 @@ Last updated: 2026-02-08
125127
- Document the decision to keep examples repo-only (or spin out a separate examples crate).
126128
- If repo-only, add a short “why” and link from the root README.
127129

130+
**Progress**
131+
- Rebuilt the root README around the esp-hal happy path (sync + async) and added a memory sizing section.
132+
- Added a docs index (`docs/README.md`) and rewrote `/docs` to the current standards.
133+
- Normalized crate name references across docs and module-level rustdocs.
134+
- Updated `apps/examples/README.md`, `apps/qa-runner/README.md`, `apps/README.md`, and `xtask/README.md`.
135+
- Updated CI fmt/doc to target the root manifest only (avoids non-crate apps/ issues).
136+
- Added a short “repo-only examples” rationale to the root README.
137+
- Added a DHCP/link troubleshooting note to the examples README.
138+
- Confirmed `cargo doc --no-deps` builds cleanly.
139+
- Kept embassy-net/smoltcp snippets in the example docs (not in the root README).
140+
141+
**Work remaining**
142+
- None.
143+
128144
**Exit criteria**
129145
- Docs build cleanly with `cargo doc --no-deps`.
130146
- Example and integration-test READMEs are accurate, minimal, and up-to-date.

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,8 @@ See [xtask/README.md](xtask/README.md) for details.
136136

137137
Examples are provided as a **separate crate** in this repository and are not
138138
packaged with the published library crate.
139+
They require the Xtensa toolchain and flashing setup, so they are kept repo-only
140+
to avoid pulling those requirements into crates.io consumers.
139141

140142
See [apps/examples/README.md](apps/examples/README.md) for build and run
141143
instructions.

apps/examples/README.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,12 @@ $env:ESPFLASH_BAUD = "921600"
5656
All examples default to the WT32-ETH01 board (LAN8720A, external 50 MHz clock).
5757
If you use different hardware, adjust the constants at the top of the example.
5858

59+
## Troubleshooting
60+
61+
- **DHCP takes too long or never assigns**: confirm link is up, give it 10–30s,
62+
and ensure your network allows broadcast/multicast. If still stuck, power-cycle
63+
the board and retry.
64+
5965
## Related
6066

6167
- `apps/qa-runner/` for hardware QA runs

src/boards/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
//!
1616
//! # See Also
1717
//!
18-
//! - [`crate::integration::esp_hal`] - esp-hal facade helpers
18+
//! - esp-hal facade helpers (feature-gated `esp-hal` module at crate root)
1919
2020
#[cfg(feature = "esp32")]
2121
#[cfg_attr(docsrs, doc(cfg(feature = "esp32")))]

src/driver/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
//!
2626
//! # See Also
2727
//!
28-
//! - [`crate::integration`] - stack and runtime facades
28+
//! - Integration facades (feature-gated modules under `integration`)
2929
3030
// Submodules
3131
pub mod config;

0 commit comments

Comments
 (0)