Skip to content
This repository was archived by the owner on Nov 30, 2021. It is now read-only.

Feature: make dialogs extensible #75

@lehnerchristian

Description

@lehnerchristian

Obsolete Description:

Dialogs are currently very limited in terms of interaction possibilities. there is only one hard-coded button in the footer and no possibility to inject more buttons in the footer exists.

see also https://github.com/phovea/phovea_ui/blob/develop/src/dialogs.ts#L19-L33

we need to have a dialog which can handle at least multiple buttons (or everything we want to inject, such as multiple form elements, etc.)

Edit:
it is actually possible to add buttons inside the footer by accessing the footer (see https://github.com/phovea/phovea_ui/blob/develop/src/dialogs.ts#L60-L62) and then adding the elements.

however I've added two other features:

  • adding custom CSS classes (e.g. for different modal sizes)
  • a getter for the header element such that it is also customizable like the body and the footer

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions