Skip to content

Commit 919e509

Browse files
WyriHaximusWyriHaximus
committed
Make sure nested schemas in arrays with no properties are also not hydrated
1 parent 62e8551 commit 919e509

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

46 files changed

+112
-664
lines changed

‎src/Hydrator/Operation/Enterprises/CbEnterpriseRcb/AuditLog.php

Lines changed: 0 additions & 76 deletions
Original file line numberDiff line numberDiff line change
@@ -195,16 +195,6 @@ private function hydrateApiClients⚡️Client⚡️GitHubAE⚡️Schema⚡️Au
195195
goto after_config;
196196
}
197197

198-
static $configCaster1;
199-
200-
if ($configCaster1 === null) {
201-
$configCaster1 = new \EventSauce\ObjectHydrator\PropertyCasters\CastListToType(...array (
202-
0 => 'ApiClients\\Client\\GitHubAE\\Schema\\AuditLogEvent\\Config',
203-
));
204-
}
205-
206-
$value = $configCaster1->cast($value, $this);
207-
208198
$properties['config'] = $value;
209199

210200
after_config:
@@ -216,16 +206,6 @@ private function hydrateApiClients⚡️Client⚡️GitHubAE⚡️Schema⚡️Au
216206
goto after_config_was;
217207
}
218208

219-
static $config_wasCaster1;
220-
221-
if ($config_wasCaster1 === null) {
222-
$config_wasCaster1 = new \EventSauce\ObjectHydrator\PropertyCasters\CastListToType(...array (
223-
0 => 'ApiClients\\Client\\GitHubAE\\Schema\\AuditLogEvent\\Config',
224-
));
225-
}
226-
227-
$value = $config_wasCaster1->cast($value, $this);
228-
229209
$properties['config_was'] = $value;
230210

231211
after_config_was:
@@ -303,16 +283,6 @@ private function hydrateApiClients⚡️Client⚡️GitHubAE⚡️Schema⚡️Au
303283
goto after_events;
304284
}
305285

306-
static $eventsCaster1;
307-
308-
if ($eventsCaster1 === null) {
309-
$eventsCaster1 = new \EventSauce\ObjectHydrator\PropertyCasters\CastListToType(...array (
310-
0 => 'ApiClients\\Client\\GitHubAE\\Schema\\AuditLogEvent\\Config',
311-
));
312-
}
313-
314-
$value = $eventsCaster1->cast($value, $this);
315-
316286
$properties['events'] = $value;
317287

318288
after_events:
@@ -324,16 +294,6 @@ private function hydrateApiClients⚡️Client⚡️GitHubAE⚡️Schema⚡️Au
324294
goto after_events_were;
325295
}
326296

327-
static $events_wereCaster1;
328-
329-
if ($events_wereCaster1 === null) {
330-
$events_wereCaster1 = new \EventSauce\ObjectHydrator\PropertyCasters\CastListToType(...array (
331-
0 => 'ApiClients\\Client\\GitHubAE\\Schema\\AuditLogEvent\\Config',
332-
));
333-
}
334-
335-
$value = $events_wereCaster1->cast($value, $this);
336-
337297
$properties['events_were'] = $value;
338298

339299
after_events_were:
@@ -807,15 +767,6 @@ private function serializeObjectApiClients⚡️Client⚡️GitHubAE⚡️Schema
807767
if ($config === null) {
808768
goto after_config;
809769
}
810-
static $configSerializer0;
811-
812-
if ($configSerializer0 === null) {
813-
$configSerializer0 = new \EventSauce\ObjectHydrator\PropertyCasters\CastListToType(...array (
814-
0 => 'ApiClients\\Client\\GitHubAE\\Schema\\AuditLogEvent\\Config',
815-
));
816-
}
817-
818-
$config = $configSerializer0->serialize($config, $this);
819770
after_config: $result['config'] = $config;
820771

821772

@@ -824,15 +775,6 @@ private function serializeObjectApiClients⚡️Client⚡️GitHubAE⚡️Schema
824775
if ($config_was === null) {
825776
goto after_config_was;
826777
}
827-
static $config_wasSerializer0;
828-
829-
if ($config_wasSerializer0 === null) {
830-
$config_wasSerializer0 = new \EventSauce\ObjectHydrator\PropertyCasters\CastListToType(...array (
831-
0 => 'ApiClients\\Client\\GitHubAE\\Schema\\AuditLogEvent\\Config',
832-
));
833-
}
834-
835-
$config_was = $config_wasSerializer0->serialize($config_was, $this);
836778
after_config_was: $result['config_was'] = $config_was;
837779

838780

@@ -889,15 +831,6 @@ private function serializeObjectApiClients⚡️Client⚡️GitHubAE⚡️Schema
889831
if ($events === null) {
890832
goto after_events;
891833
}
892-
static $eventsSerializer0;
893-
894-
if ($eventsSerializer0 === null) {
895-
$eventsSerializer0 = new \EventSauce\ObjectHydrator\PropertyCasters\CastListToType(...array (
896-
0 => 'ApiClients\\Client\\GitHubAE\\Schema\\AuditLogEvent\\Config',
897-
));
898-
}
899-
900-
$events = $eventsSerializer0->serialize($events, $this);
901834
after_events: $result['events'] = $events;
902835

903836

@@ -906,15 +839,6 @@ private function serializeObjectApiClients⚡️Client⚡️GitHubAE⚡️Schema
906839
if ($events_were === null) {
907840
goto after_events_were;
908841
}
909-
static $events_wereSerializer0;
910-
911-
if ($events_wereSerializer0 === null) {
912-
$events_wereSerializer0 = new \EventSauce\ObjectHydrator\PropertyCasters\CastListToType(...array (
913-
0 => 'ApiClients\\Client\\GitHubAE\\Schema\\AuditLogEvent\\Config',
914-
));
915-
}
916-
917-
$events_were = $events_wereSerializer0->serialize($events_were, $this);
918842
after_events_were: $result['events_were'] = $events_were;
919843

920844

‎src/Hydrator/Operation/Orgs/CbOrgRcb/AuditLog.php

Lines changed: 0 additions & 76 deletions
Original file line numberDiff line numberDiff line change
@@ -195,16 +195,6 @@ private function hydrateApiClients⚡️Client⚡️GitHubAE⚡️Schema⚡️Au
195195
goto after_config;
196196
}
197197

198-
static $configCaster1;
199-
200-
if ($configCaster1 === null) {
201-
$configCaster1 = new \EventSauce\ObjectHydrator\PropertyCasters\CastListToType(...array (
202-
0 => 'ApiClients\\Client\\GitHubAE\\Schema\\AuditLogEvent\\Config',
203-
));
204-
}
205-
206-
$value = $configCaster1->cast($value, $this);
207-
208198
$properties['config'] = $value;
209199

210200
after_config:
@@ -216,16 +206,6 @@ private function hydrateApiClients⚡️Client⚡️GitHubAE⚡️Schema⚡️Au
216206
goto after_config_was;
217207
}
218208

219-
static $config_wasCaster1;
220-
221-
if ($config_wasCaster1 === null) {
222-
$config_wasCaster1 = new \EventSauce\ObjectHydrator\PropertyCasters\CastListToType(...array (
223-
0 => 'ApiClients\\Client\\GitHubAE\\Schema\\AuditLogEvent\\Config',
224-
));
225-
}
226-
227-
$value = $config_wasCaster1->cast($value, $this);
228-
229209
$properties['config_was'] = $value;
230210

231211
after_config_was:
@@ -303,16 +283,6 @@ private function hydrateApiClients⚡️Client⚡️GitHubAE⚡️Schema⚡️Au
303283
goto after_events;
304284
}
305285

306-
static $eventsCaster1;
307-
308-
if ($eventsCaster1 === null) {
309-
$eventsCaster1 = new \EventSauce\ObjectHydrator\PropertyCasters\CastListToType(...array (
310-
0 => 'ApiClients\\Client\\GitHubAE\\Schema\\AuditLogEvent\\Config',
311-
));
312-
}
313-
314-
$value = $eventsCaster1->cast($value, $this);
315-
316286
$properties['events'] = $value;
317287

318288
after_events:
@@ -324,16 +294,6 @@ private function hydrateApiClients⚡️Client⚡️GitHubAE⚡️Schema⚡️Au
324294
goto after_events_were;
325295
}
326296

327-
static $events_wereCaster1;
328-
329-
if ($events_wereCaster1 === null) {
330-
$events_wereCaster1 = new \EventSauce\ObjectHydrator\PropertyCasters\CastListToType(...array (
331-
0 => 'ApiClients\\Client\\GitHubAE\\Schema\\AuditLogEvent\\Config',
332-
));
333-
}
334-
335-
$value = $events_wereCaster1->cast($value, $this);
336-
337297
$properties['events_were'] = $value;
338298

339299
after_events_were:
@@ -807,15 +767,6 @@ private function serializeObjectApiClients⚡️Client⚡️GitHubAE⚡️Schema
807767
if ($config === null) {
808768
goto after_config;
809769
}
810-
static $configSerializer0;
811-
812-
if ($configSerializer0 === null) {
813-
$configSerializer0 = new \EventSauce\ObjectHydrator\PropertyCasters\CastListToType(...array (
814-
0 => 'ApiClients\\Client\\GitHubAE\\Schema\\AuditLogEvent\\Config',
815-
));
816-
}
817-
818-
$config = $configSerializer0->serialize($config, $this);
819770
after_config: $result['config'] = $config;
820771

821772

@@ -824,15 +775,6 @@ private function serializeObjectApiClients⚡️Client⚡️GitHubAE⚡️Schema
824775
if ($config_was === null) {
825776
goto after_config_was;
826777
}
827-
static $config_wasSerializer0;
828-
829-
if ($config_wasSerializer0 === null) {
830-
$config_wasSerializer0 = new \EventSauce\ObjectHydrator\PropertyCasters\CastListToType(...array (
831-
0 => 'ApiClients\\Client\\GitHubAE\\Schema\\AuditLogEvent\\Config',
832-
));
833-
}
834-
835-
$config_was = $config_wasSerializer0->serialize($config_was, $this);
836778
after_config_was: $result['config_was'] = $config_was;
837779

838780

@@ -889,15 +831,6 @@ private function serializeObjectApiClients⚡️Client⚡️GitHubAE⚡️Schema
889831
if ($events === null) {
890832
goto after_events;
891833
}
892-
static $eventsSerializer0;
893-
894-
if ($eventsSerializer0 === null) {
895-
$eventsSerializer0 = new \EventSauce\ObjectHydrator\PropertyCasters\CastListToType(...array (
896-
0 => 'ApiClients\\Client\\GitHubAE\\Schema\\AuditLogEvent\\Config',
897-
));
898-
}
899-
900-
$events = $eventsSerializer0->serialize($events, $this);
901834
after_events: $result['events'] = $events;
902835

903836

@@ -906,15 +839,6 @@ private function serializeObjectApiClients⚡️Client⚡️GitHubAE⚡️Schema
906839
if ($events_were === null) {
907840
goto after_events_were;
908841
}
909-
static $events_wereSerializer0;
910-
911-
if ($events_wereSerializer0 === null) {
912-
$events_wereSerializer0 = new \EventSauce\ObjectHydrator\PropertyCasters\CastListToType(...array (
913-
0 => 'ApiClients\\Client\\GitHubAE\\Schema\\AuditLogEvent\\Config',
914-
));
915-
}
916-
917-
$events_were = $events_wereSerializer0->serialize($events_were, $this);
918842
after_events_were: $result['events_were'] = $events_were;
919843

920844

‎src/Hydrator/WebHook/IssueComment.php

Lines changed: 3 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1566,20 +1566,10 @@ private function hydrateApiClients⚡️Client⚡️GitHubAE⚡️Schema⚡️We
15661566
$value = $payload['assignees'] ?? null;
15671567

15681568
if ($value === null) {
1569-
$missingFields[] = 'assignees';
1569+
$properties['assignees'] = null;
15701570
goto after_assignees;
15711571
}
15721572

1573-
static $assigneesCaster1;
1574-
1575-
if ($assigneesCaster1 === null) {
1576-
$assigneesCaster1 = new \EventSauce\ObjectHydrator\PropertyCasters\CastListToType(...array (
1577-
0 => 'ApiClients\\Client\\GitHubAE\\Schema\\WebhookCheckSuiteCompleted\\ActionsMeta',
1578-
));
1579-
}
1580-
1581-
$value = $assigneesCaster1->cast($value, $this);
1582-
15831573
$properties['assignees'] = $value;
15841574

15851575
after_assignees:
@@ -6839,15 +6829,10 @@ private function serializeObjectApiClients⚡️Client⚡️GitHubAE⚡️Schema
68396829

68406830

68416831
$assignees = $object->assignees;
6842-
static $assigneesSerializer0;
68436832

6844-
if ($assigneesSerializer0 === null) {
6845-
$assigneesSerializer0 = new \EventSauce\ObjectHydrator\PropertyCasters\CastListToType(...array (
6846-
0 => 'ApiClients\\Client\\GitHubAE\\Schema\\WebhookCheckSuiteCompleted\\ActionsMeta',
6847-
));
6833+
if ($assignees === null) {
6834+
goto after_assignees;
68486835
}
6849-
6850-
$assignees = $assigneesSerializer0->serialize($assignees, $this);
68516836
after_assignees: $result['assignees'] = $assignees;
68526837

68536838

0 commit comments

Comments
 (0)