Merge pull request #1225 from php-api-clients/GitHubEnterpriseCloud/from-1.1.4-a64005d8253466da5566a833f48e8713-from-1.1.4-a64005d8253466da5566a833f48e8713

WyriHaximus · web-flow · commit 5c0435a521c9 · 2024-07-04T07:25:07.000+02:00
diff --git a/clients/GitHubEnterpriseCloud/etc/openapi-client-generator.state b/clients/GitHubEnterpriseCloud/etc/openapi-client-generator.state
@@ -1,5 +1,5 @@
 {
-    "specHash": "4fef0f9e03cf11aed96c1dfc31630f25",
+    "specHash": "a64005d8253466da5566a833f48e8713",
     "generatedFiles": {
         "files": [
             {
@@ -4976,7 +4976,7 @@
             },
             {
                 "name": ".\/clients\/GitHubEnterpriseCloud\/etc\/..\/\/src\/\/Schema\/Teams\/AddOrUpdateRepoPermissionsInOrg\/Request\/ApplicationJson.php",
-                "hash": "b70adabc6ddfc0ac4e9c2b70274585de"
+                "hash": "1bb3f932e5c0e3c302221694249d0154"
             },
             {
                 "name": ".\/clients\/GitHubEnterpriseCloud\/etc\/..\/\/src\/\/Schema\/Teams\/CreateOrUpdateIdpGroupConnectionsInOrg\/Request\/ApplicationJson.php",
@@ -5948,7 +5948,7 @@
             },
             {
                 "name": ".\/clients\/GitHubEnterpriseCloud\/etc\/..\/\/src\/\/Operation\/Orgs.php",
-                "hash": "81c433e68c1b12a3319d411b17dcbc39"
+                "hash": "9a93d9aa406ccbbe614cafde1188f2ea"
             },
             {
                 "name": ".\/clients\/GitHubEnterpriseCloud\/etc\/..\/\/src\/\/Operation\/Oidc.php",
@@ -16672,7 +16672,7 @@
             },
             {
                 "name": ".\/clients\/GitHubEnterpriseCloud\/etc\/..\/\/src\/\/Internal\/Operator\/Orgs\/AddSecurityManagerTeam.php",
-                "hash": "31009d08df387284e07148fda5ff10e0"
+                "hash": "17f82d441ecc7d250849d4406db81c4e"
             },
             {
                 "name": ".\/clients\/GitHubEnterpriseCloud\/etc\/..\/\/src\/\/Internal\/Operation\/Orgs\/RemoveSecurityManagerTeam.php",
@@ -26572,7 +26572,7 @@
             },
             {
                 "name": ".\/clients\/GitHubEnterpriseCloud\/etc\/..\/\/src\/\/Internal\/Router\/Put\/Orgs.php",
-                "hash": "3660de9e7e30c96c607d0939dc1c2d5a"
+                "hash": "a135b174133165f7bc7d942f2c7d11ce"
             },
             {
                 "name": ".\/clients\/GitHubEnterpriseCloud\/etc\/..\/\/src\/\/Internal\/Router\/Put\/Codespaces.php",
@@ -26824,7 +26824,7 @@
             },
             {
                 "name": ".\/clients\/GitHubEnterpriseCloud\/etc\/..\/\/src\/\/Internal\/Router\/Put\/Six.php",
-                "hash": "f668b3e92266043081391c184157b062"
+                "hash": "3576153c2e0e06663de2723fc31d948c"
             },
             {
                 "name": ".\/clients\/GitHubEnterpriseCloud\/etc\/..\/\/src\/\/Internal\/Router\/Put\/Eight.php",
@@ -29872,11 +29872,11 @@
             },
             {
                 "name": ".\/clients\/GitHubEnterpriseCloud\/etc\/..\/\/src\/\/PHPStan\/ClientCallReturnTypes.php",
-                "hash": "1c7d61859ae5740aa03b87e2aee417ab"
+                "hash": "8c7f8e1a0105b2d7f1b6584917827fe6"
             },
             {
                 "name": ".\/clients\/GitHubEnterpriseCloud\/etc\/..\/\/tests\/\/Types\/ClientCallReturnTypes.php",
-                "hash": "995c5db408fc8b14c01a2e3fb980e5a8"
+                "hash": "99a2844d0f28bf7cd062b18aee15340a"
             },
             {
                 "name": ".\/clients\/GitHubEnterpriseCloud\/etc\/..\/\/src\/\/..\/etc\/phpstan-extension.neon",
diff --git a/clients/GitHubEnterpriseCloud/src/Internal/Operator/Orgs/AddSecurityManagerTeam.php b/clients/GitHubEnterpriseCloud/src/Internal/Operator/Orgs/AddSecurityManagerTeam.php
@@ -22,6 +22,7 @@ public function __construct(private Browser $browser, private AuthenticationInte
     {
     }
 
+    /** @return */
     public function call(string $org, string $teamSlug): WithoutBody
     {
         $operation = new \ApiClients\Client\GitHubEnterpriseCloud\Internal\Operation\Orgs\AddSecurityManagerTeam($org, $teamSlug);
diff --git a/clients/GitHubEnterpriseCloud/src/Internal/Router/Put/Orgs.php b/clients/GitHubEnterpriseCloud/src/Internal/Router/Put/Orgs.php
@@ -181,6 +181,7 @@ public function createOrUpdateCustomProperty(array $params): OrgCustomProperty
         return $operator->call($arguments['org'], $arguments['custom_property_name'], $params);
     }
 
+    /** @return */
     public function addSecurityManagerTeam(array $params): WithoutBody
     {
         $arguments = [];
diff --git a/clients/GitHubEnterpriseCloud/src/Internal/Router/Put/Six.php b/clients/GitHubEnterpriseCloud/src/Internal/Router/Put/Six.php
@@ -20,7 +20,6 @@ public function __construct(private Routers $routers)
     {
     }
 
-    /** @return |\ApiClients\Tools\OpenApiClient\Utils\Response\WithoutBody */
     public function call(string $call, array $params, array $pathChunks): WithoutBody|EmptyObject|OrgCustomProperty|RepositoryInvitation|FileCommit|Environment|RepositoryRuleset
     {
         if ($pathChunks[0] === '') {
diff --git a/clients/GitHubEnterpriseCloud/src/Operation/Orgs.php b/clients/GitHubEnterpriseCloud/src/Operation/Orgs.php
@@ -625,6 +625,7 @@ public function listSecurityManagerTeams(string $org): iterable
         return $this->operators->orgs👷ListSecurityManagerTeams()->call($org);
     }
 
+    /** @return */
     public function addSecurityManagerTeam(string $org, string $teamSlug): WithoutBody
     {
         return $this->operators->orgs👷AddSecurityManagerTeam()->call($org, $teamSlug);
diff --git a/clients/GitHubEnterpriseCloud/src/PHPStan/ClientCallReturnTypes.php b/clients/GitHubEnterpriseCloud/src/PHPStan/ClientCallReturnTypes.php
@@ -1712,7 +1712,7 @@ public function getTypeFromMethodCall(MethodReflection $methodReflection, Method
         }
 
         if ($call === 'PUT /orgs/{org}/security-managers/teams/{team_slug}') {
-            return $this->typeResolver->resolve('\\ApiClients\\Tools\\OpenApiClient\\Utils\\Response\\WithoutBody');
+            return $this->typeResolver->resolve('');
         }
 
         if ($call === 'DELETE /orgs/{org}/security-managers/teams/{team_slug}') {
diff --git a/clients/GitHubEnterpriseCloud/src/Schema/Teams/AddOrUpdateRepoPermissionsInOrg/Request/ApplicationJson.php b/clients/GitHubEnterpriseCloud/src/Schema/Teams/AddOrUpdateRepoPermissionsInOrg/Request/ApplicationJson.php
@@ -11,8 +11,7 @@
     "properties": {
         "permission": {
             "type": "string",
-            "description": "The permission to grant the team on this repository. We accept the following permissions to be set: `pull`, `triage`, `push`, `maintain`, `admin` and you can also specify a custom repository role name, if the owning organization has defined any. If no permission is specified, the team\'s `permission` attribute will be used to determine what permission to grant the team on this repository.",
-            "default": "push"
+            "description": "The permission to grant the team on this repository. We accept the following permissions to be set: `pull`, `triage`, `push`, `maintain`, `admin` and you can also specify a custom repository role name, if the owning organization has defined any. If no permission is specified, the team\'s `permission` attribute will be used to determine what permission to grant the team on this repository."
         }
     }
 }';
diff --git a/clients/GitHubEnterpriseCloud/tests/Types/ClientCallReturnTypes.php b/clients/GitHubEnterpriseCloud/tests/Types/ClientCallReturnTypes.php
@@ -434,7 +434,7 @@ function authHeader(): string
 assertType('Observable<Schema\\OrganizationSecretScanningAlert>', $client->call('LIST /orgs/{org}/secret-scanning/alerts'));
 assertType('Observable<Schema\\RepositoryAdvisory>', $client->call('GET /orgs/{org}/security-advisories'));
 assertType('Observable<Schema\\TeamSimple>', $client->call('GET /orgs/{org}/security-managers'));
-assertType('\\ApiClients\\Tools\\OpenApiClient\\Utils\\Response\\WithoutBody', $client->call('PUT /orgs/{org}/security-managers/teams/{team_slug}'));
+assertType('', $client->call('PUT /orgs/{org}/security-managers/teams/{team_slug}'));
 assertType('', $client->call('DELETE /orgs/{org}/security-managers/teams/{team_slug}'));
 assertType('', $client->call('GET /orgs/{org}/settings/billing/actions'));
 assertType('', $client->call('GET /orgs/{org}/settings/billing/advanced-security'));
diff --git a/etc/specs/GitHubEnterpriseCloud/current.spec.yaml b/etc/specs/GitHubEnterpriseCloud/current.spec.yaml
@@ -10362,6 +10362,8 @@ paths:
         For more information about setting up a Copilot subscription, see "[Setting up a Copilot subscription for your organization](https://docs.github.com/enterprise-cloud@latest//billing/managing-billing-for-github-copilot/managing-your-github-copilot-subscription-for-your-organization-or-enterprise)".
         For more information about setting a suggestion matching policy, see "[Configuring suggestion matching policies for GitHub Copilot in your organization](https://docs.github.com/enterprise-cloud@latest//copilot/managing-copilot/managing-policies-for-github-copilot-in-your-organization#configuring-suggestion-matching-policies-for-github-copilot-in-your-organization)".
 
+        The response will contain the total number of new seats that were created and existing seats that were refreshed.
+
         OAuth app tokens and personal access tokens (classic) need either the `manage_billing:copilot` or `admin:org` scopes to use this endpoint.
       tags:
       - copilot
@@ -10525,6 +10527,8 @@ paths:
         For more information about setting up a Copilot subscription, see "[Setting up a Copilot subscription for your organization](https://docs.github.com/enterprise-cloud@latest//billing/managing-billing-for-github-copilot/managing-your-github-copilot-subscription-for-your-organization-or-enterprise)".
         For more information about setting a suggestion matching policy, see "[Configuring suggestion matching policies for GitHub Copilot in your organization](https://docs.github.com/enterprise-cloud@latest//copilot/managing-copilot/managing-policies-for-github-copilot-in-your-organization#configuring-suggestion-matching-policies-for-github-copilot-in-your-organization)".
 
+        The response will contain the total number of new seats that were created and existing seats that were refreshed.
+
         OAuth app tokens and personal access tokens (classic) need either the `manage_billing:copilot` or `admin:org` scopes to use this endpoint.
       tags:
       - copilot
@@ -18453,7 +18457,6 @@ paths:
                     If no permission is specified, the team''s `permission` attribute
                     will be used to determine what permission to grant the team on
                     this repository.'
-                  default: push
             examples:
               default:
                 summary: Adding a team to an organization repository with the write

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`{`
`2`		`- "specHash": "4fef0f9e03cf11aed96c1dfc31630f25",`
	`2`	`+ "specHash": "a64005d8253466da5566a833f48e8713",`
`3`	`3`	`"generatedFiles": {`
`4`	`4`	`"files": [`
`5`	`5`	`{`
`@@ -4976,7 +4976,7 @@`
`4976`	`4976`	`},`
`4977`	`4977`	`{`
`4978`	`4978`	`"name": ".\/clients\/GitHubEnterpriseCloud\/etc\/..\/\/src\/\/Schema\/Teams\/AddOrUpdateRepoPermissionsInOrg\/Request\/ApplicationJson.php",`
`4979`		`- "hash": "b70adabc6ddfc0ac4e9c2b70274585de"`
	`4979`	`+ "hash": "1bb3f932e5c0e3c302221694249d0154"`
`4980`	`4980`	`},`
`4981`	`4981`	`{`
`4982`	`4982`	`"name": ".\/clients\/GitHubEnterpriseCloud\/etc\/..\/\/src\/\/Schema\/Teams\/CreateOrUpdateIdpGroupConnectionsInOrg\/Request\/ApplicationJson.php",`
`@@ -5948,7 +5948,7 @@`
`5948`	`5948`	`},`
`5949`	`5949`	`{`
`5950`	`5950`	`"name": ".\/clients\/GitHubEnterpriseCloud\/etc\/..\/\/src\/\/Operation\/Orgs.php",`
`5951`		`- "hash": "81c433e68c1b12a3319d411b17dcbc39"`
	`5951`	`+ "hash": "9a93d9aa406ccbbe614cafde1188f2ea"`
`5952`	`5952`	`},`
`5953`	`5953`	`{`
`5954`	`5954`	`"name": ".\/clients\/GitHubEnterpriseCloud\/etc\/..\/\/src\/\/Operation\/Oidc.php",`
`@@ -16672,7 +16672,7 @@`
`16672`	`16672`	`},`
`16673`	`16673`	`{`
`16674`	`16674`	`"name": ".\/clients\/GitHubEnterpriseCloud\/etc\/..\/\/src\/\/Internal\/Operator\/Orgs\/AddSecurityManagerTeam.php",`
`16675`		`- "hash": "31009d08df387284e07148fda5ff10e0"`
	`16675`	`+ "hash": "17f82d441ecc7d250849d4406db81c4e"`
`16676`	`16676`	`},`
`16677`	`16677`	`{`
`16678`	`16678`	`"name": ".\/clients\/GitHubEnterpriseCloud\/etc\/..\/\/src\/\/Internal\/Operation\/Orgs\/RemoveSecurityManagerTeam.php",`
`@@ -26572,7 +26572,7 @@`
`26572`	`26572`	`},`
`26573`	`26573`	`{`
`26574`	`26574`	`"name": ".\/clients\/GitHubEnterpriseCloud\/etc\/..\/\/src\/\/Internal\/Router\/Put\/Orgs.php",`
`26575`		`- "hash": "3660de9e7e30c96c607d0939dc1c2d5a"`
	`26575`	`+ "hash": "a135b174133165f7bc7d942f2c7d11ce"`
`26576`	`26576`	`},`
`26577`	`26577`	`{`
`26578`	`26578`	`"name": ".\/clients\/GitHubEnterpriseCloud\/etc\/..\/\/src\/\/Internal\/Router\/Put\/Codespaces.php",`
`@@ -26824,7 +26824,7 @@`
`26824`	`26824`	`},`
`26825`	`26825`	`{`
`26826`	`26826`	`"name": ".\/clients\/GitHubEnterpriseCloud\/etc\/..\/\/src\/\/Internal\/Router\/Put\/Six.php",`
`26827`		`- "hash": "f668b3e92266043081391c184157b062"`
	`26827`	`+ "hash": "3576153c2e0e06663de2723fc31d948c"`
`26828`	`26828`	`},`
`26829`	`26829`	`{`
`26830`	`26830`	`"name": ".\/clients\/GitHubEnterpriseCloud\/etc\/..\/\/src\/\/Internal\/Router\/Put\/Eight.php",`
`@@ -29872,11 +29872,11 @@`
`29872`	`29872`	`},`
`29873`	`29873`	`{`
`29874`	`29874`	`"name": ".\/clients\/GitHubEnterpriseCloud\/etc\/..\/\/src\/\/PHPStan\/ClientCallReturnTypes.php",`
`29875`		`- "hash": "1c7d61859ae5740aa03b87e2aee417ab"`
	`29875`	`+ "hash": "8c7f8e1a0105b2d7f1b6584917827fe6"`
`29876`	`29876`	`},`
`29877`	`29877`	`{`
`29878`	`29878`	`"name": ".\/clients\/GitHubEnterpriseCloud\/etc\/..\/\/tests\/\/Types\/ClientCallReturnTypes.php",`
`29879`		`- "hash": "995c5db408fc8b14c01a2e3fb980e5a8"`
	`29879`	`+ "hash": "99a2844d0f28bf7cd062b18aee15340a"`
`29880`	`29880`	`},`
`29881`	`29881`	`{`
`29882`	`29882`	`"name": ".\/clients\/GitHubEnterpriseCloud\/etc\/..\/\/src\/\/..\/etc\/phpstan-extension.neon",`
Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,7 @@ public function __construct(private Browser $browser, private AuthenticationInte`
`22`	`22`	`{`
`23`	`23`	`}`
`24`	`24`
	`25`	`+ /** @return */`
`25`	`26`	`public function call(string $org, string $teamSlug): WithoutBody`
`26`	`27`	`{`
`27`	`28`	`$operation = new \ApiClients\Client\GitHubEnterpriseCloud\Internal\Operation\Orgs\AddSecurityManagerTeam($org, $teamSlug);`
Original file line number	Diff line number	Diff line change
`@@ -181,6 +181,7 @@ public function createOrUpdateCustomProperty(array $params): OrgCustomProperty`
`181`	`181`	`return $operator->call($arguments['org'], $arguments['custom_property_name'], $params);`
`182`	`182`	`}`
`183`	`183`
	`184`	`+ /** @return */`
`184`	`185`	`public function addSecurityManagerTeam(array $params): WithoutBody`
`185`	`186`	`{`
`186`	`187`	`$arguments = [];`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,6 @@ public function __construct(private Routers $routers)`
`20`	`20`	`{`
`21`	`21`	`}`
`22`	`22`
`23`		`- /** @return \|\ApiClients\Tools\OpenApiClient\Utils\Response\WithoutBody */`
`24`	`23`	`public function call(string $call, array $params, array $pathChunks): WithoutBody\|EmptyObject\|OrgCustomProperty\|RepositoryInvitation\|FileCommit\|Environment\|RepositoryRuleset`
`25`	`24`	`{`
`26`	`25`	`if ($pathChunks[0] === '') {`
Original file line number	Diff line number	Diff line change
`@@ -625,6 +625,7 @@ public function listSecurityManagerTeams(string $org): iterable`
`625`	`625`	`return $this->operators->orgs👷ListSecurityManagerTeams()->call($org);`
`626`	`626`	`}`
`627`	`627`
	`628`	`+ /** @return */`
`628`	`629`	`public function addSecurityManagerTeam(string $org, string $teamSlug): WithoutBody`
`629`	`630`	`{`
`630`	`631`	`return $this->operators->orgs👷AddSecurityManagerTeam()->call($org, $teamSlug);`
Original file line number	Diff line number	Diff line change
`@@ -1712,7 +1712,7 @@ public function getTypeFromMethodCall(MethodReflection $methodReflection, Method`
`1712`	`1712`	`}`
`1713`	`1713`
`1714`	`1714`	`if ($call === 'PUT /orgs/{org}/security-managers/teams/{team_slug}') {`
`1715`		`- return $this->typeResolver->resolve('\\ApiClients\\Tools\\OpenApiClient\\Utils\\Response\\WithoutBody');`
	`1715`	`+ return $this->typeResolver->resolve('');`
`1716`	`1716`	`}`
`1717`	`1717`
`1718`	`1718`	`if ($call === 'DELETE /orgs/{org}/security-managers/teams/{team_slug}') {`
Original file line number	Diff line number	Diff line change
`@@ -11,8 +11,7 @@`
`11`	`11`	`"properties": {`
`12`	`12`	`"permission": {`
`13`	`13`	`"type": "string",`
`14`		- "description": "The permission to grant the team on this repository. We accept the following permissions to be set: `pull`, `triage`, `push`, `maintain`, `admin` and you can also specify a custom repository role name, if the owning organization has defined any. If no permission is specified, the team\'s `permission` attribute will be used to determine what permission to grant the team on this repository.",
`15`		`- "default": "push"`
	`14`	+ "description": "The permission to grant the team on this repository. We accept the following permissions to be set: `pull`, `triage`, `push`, `maintain`, `admin` and you can also specify a custom repository role name, if the owning organization has defined any. If no permission is specified, the team\'s `permission` attribute will be used to determine what permission to grant the team on this repository."
`16`	`15`	`}`
`17`	`16`	`}`
`18`	`17`	`}';`