Skip to content

Commit 45340e7

Browse files
authored
Merge pull request #123 from php-api-clients/upgrade-array-merging
Upgrade array merging
2 parents 29b455e + 99b6983 commit 45340e7

File tree

3 files changed

+50
-55
lines changed

3 files changed

+50
-55
lines changed

composer.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@
3434
"api-clients/contracts": "dev-main",
3535
"eventsauce/object-hydrator": "^1.2",
3636
"react/async": "^4.0",
37-
"rikudou/array-merge-recursive": "^1.0",
38-
"wyrihaximus/react-awaitable-observable": "^1.0"
37+
"wyrihaximus/react-awaitable-observable": "^1.0",
38+
"ckr/arraymerger": "^3.0"
3939
},
4040
"autoload": {
4141
"psr-4": {

composer.lock

Lines changed: 44 additions & 47 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Gatherer/Property.php

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,10 @@
22

33
namespace ApiClients\Tools\OpenApiClientGenerator\Gatherer;
44

5-
use ApiClients\Tools\OpenApiClientGenerator\Utils;
6-
use ApiClients\Tools\OpenApiClientGenerator\Representation\PropertyType;
75
use ApiClients\Tools\OpenApiClientGenerator\Registry\Schema as SchemaRegistry;
6+
use ApiClients\Tools\OpenApiClientGenerator\Representation\PropertyType;
87
use cebe\openapi\spec\Schema as baseSchema;
9-
use Jawira\CaseConverter\Convert;
10-
use function Rikudou\ArrayMergeRecursive\array_merge_recursive;
8+
use Ckr\Util\ArrayMerger;
119

1210
final class Property
1311
{
@@ -63,7 +61,7 @@ private static function generateExampleData(mixed $exampleData, PropertyType $ty
6361
{
6462
if ($type->type === 'array') {
6563
if ($type->payload instanceof \ApiClients\Tools\OpenApiClientGenerator\Representation\Schema) {
66-
$exampleData = array_merge_recursive($type->payload->example, $exampleData ?? []);
64+
$exampleData = ArrayMerger::doMerge($type->payload->example, $exampleData ?? [], ArrayMerger::FLAG_OVERWRITE_NUMERIC_KEY);
6765
} else if ($type->payload instanceof PropertyType) {
6866
$exampleData = self::generateExampleData($exampleData, $type->payload, $propertyName);
6967
}
@@ -72,7 +70,7 @@ private static function generateExampleData(mixed $exampleData, PropertyType $ty
7270

7371

7472
if ($type->payload instanceof \ApiClients\Tools\OpenApiClientGenerator\Representation\Schema) {
75-
return array_merge_recursive($type->payload->example, is_array($exampleData) ? $exampleData : []);
73+
return ArrayMerger::doMerge($type->payload->example, is_array($exampleData) ? $exampleData : [], ArrayMerger::FLAG_OVERWRITE_NUMERIC_KEY);
7674
} else if ($exampleData === null && $type->type=== 'scalar') {
7775
if ($type->payload === 'int') {
7876
return 13;

0 commit comments

Comments
 (0)