Support the use of aliases

Author: WyriHaximus

openapi-client.yaml

@@ -4,6 +4,7 @@ namespace: ApiClients\Client\Github
 destination: generated
 schemas:
   allowDuplication: true
+  useAliasesForDuplication: true
 voter:
   listOperation:
     - ApiClients\Tools\OpenApiClientGenerator\Voter\ListOperation\PageAndPerPageInQuery

src/Configuration/Schemas.php

@@ -9,6 +9,8 @@
     public function __construct(
         #[MapFrom('allowDuplication')]
         public bool $allowDuplication,
+        #[MapFrom('useAliasesForDuplication')]
+        public bool $useAliasesForDuplication,
     ) {
     }
 }

src/Generator.php

@@ -104,10 +104,10 @@ public function generate(string $namespace, string $destinationPath, Configurati
      */
     private function all(string $namespace, string $rootPath, Configuration $configuration): iterable
     {
-        $schemaRegistry = new SchemaRegistry();
-        if ($configuration->schemas !== null && $configuration->schemas->allowDuplication !== null) {
-            $schemaRegistry->setAllowDuplicatedSchemas($configuration->schemas->allowDuplication);
-        }
+        $schemaRegistry = new SchemaRegistry(
+            $configuration->schemas !== null && $configuration->schemas->allowDuplication !== null ? $configuration->schemas->allowDuplication : false,
+            $configuration->schemas !== null && $configuration->schemas->useAliasesForDuplication !== null ? $configuration->schemas->useAliasesForDuplication : false,
+        );
         $schemas = [];
         $throwableSchemaRegistry = new ThrowableSchema();
         if (count($this->spec->components->schemas ?? []) > 0) {
@@ -171,6 +171,7 @@ private function all(string $namespace, string $rootPath, Configuration $configu
             yield from Schema::generate(
                 $namespace,
                 $schema,
+                [...$schemaRegistry->aliasesForClassName($schema->className)],
             );
             if ($throwableSchemaRegistry->has($schema->className)) {
                 yield from Error::generate(

src/Generator/Schema.php

@@ -26,10 +26,15 @@ final class Schema
      * @param OpenAPiSchema $schema
      * @return iterable<Node>
      */
-    public static function generate(string $namespace, \ApiClients\Tools\OpenApiClientGenerator\Representation\Schema $schema): iterable
+    public static function generate(string $namespace, \ApiClients\Tools\OpenApiClientGenerator\Representation\Schema $schema, array $aliases): iterable
     {
+        $className = $schema->className;
+        if (count($aliases) > 0) {
+            $className = 'AliasAbstract\\Abstract' . md5(json_encode($schema->schema->getSerializableData()));
+            $aliases[] = $schema->className;
+        }
         $factory = new BuilderFactory();
-        $stmt = $factory->namespace(trim(Utils::dirname($namespace . '\\Schema\\' . $schema->className), '\\'));
+        $stmt = $factory->namespace(trim(Utils::dirname($namespace . '\\Schema\\' . $className), '\\'));
 
         $schemaJson = new Node\Stmt\ClassConst(
             [
@@ -43,7 +48,14 @@ public static function generate(string $namespace, \ApiClients\Tools\OpenApiClie
             Class_::MODIFIER_PUBLIC
         );
 
-        $class = $factory->class(trim(Utils::basename($schema->className), '\\'))->makeFinal()->makeReadonly()->addStmt(
+        $class = $factory->class(trim(Utils::basename($className), '\\'))->makeReadonly();
+
+        if (count($aliases) === 0) {
+            $class = $class->makeFinal();
+        } else {
+            $class = $class->makeAbstract();
+        }
+        $class->addStmt(
             $schemaJson
         )->addStmt(
             new Node\Stmt\ClassConst(
@@ -146,6 +158,14 @@ public static function generate(string $namespace, \ApiClients\Tools\OpenApiClie
         $class->addStmt($constructor);
 
 
-        yield new File($namespace . 'Schema\\' . $schema->className, $stmt->addStmt($class)->getNode());
+        yield new File($namespace . 'Schema\\' . $className, $stmt->addStmt($class)->getNode());
+
+        foreach ($aliases as $alias) {
+            $aliasTms = $factory->namespace(trim(Utils::dirname($namespace . '\\Schema\\' . $alias), '\\'));
+
+            $aliasClass = $factory->class(trim(Utils::basename($alias), '\\'))->makeFinal()->makeReadonly()->extend('Schema\\' . $className);
+
+            yield new File($namespace . 'Schema\\' . $alias, $aliasTms->addStmt($aliasClass)->getNode());
+        }
     }
 }

src/Registry/Schema.php

@@ -25,12 +25,16 @@ final class Schema
      * @var array<string, class-string>
      */
     private array $unknownSchemasJson = [];
+    /**
+     * @var array<class-string, array<class-string>>
+     */
+    private array $aliasses = [];
 
-    private bool $allowDuplicatedSchemas = false;
-
-    public function setAllowDuplicatedSchemas(bool $allow): void
+    public function __construct(
+        private readonly bool $allowDuplicatedSchemas,
+        private readonly bool $useAliasesForDuplication,
+    )
     {
-        $this->allowDuplicatedSchemas = $allow;
     }
 
     public function addClassName(string $className, openAPISchema $schema): void
@@ -62,6 +66,19 @@ public function get(openAPISchema $schema, string $fallbackName): string
         }
 
         $className = Utils::fixKeyword($fallbackName);
+
+        if ($this->allowDuplicatedSchemas && $this->useAliasesForDuplication && array_key_exists($json, $this->json)) {
+            $this->aliasses[$this->json[$json]][] = $className;
+
+            return $className;
+        }
+
+        if ($this->allowDuplicatedSchemas && $this->useAliasesForDuplication && array_key_exists($json, $this->unknownSchemasJson)) {
+            $this->aliasses[$this->unknownSchemasJson[$json]][] = $className;
+
+            return $className;
+        }
+
         $suffix = 'a';
         while (array_key_exists($className, $this->unknownSchemas)) {
             $className = Utils::fixKeyword($fallbackName . strtoupper($suffix++));
@@ -88,4 +105,11 @@ public function unknownSchemas(): iterable
         $this->unknownSchemas = [];
         yield from $unknownSchemas;
     }
+
+    public function aliasesForClassName(string $classname): iterable
+    {
+        if (array_key_exists($classname, $this->aliasses)) {
+            yield from array_unique($this->aliasses[$classname]);
+        }
+    }
 }