Created interface for tests

Author: WyriHaximus

src/AsyncClient.php

@@ -9,21 +9,18 @@
 use ApiClients\Foundation\Oauth1\Options as Oauth1Options;
 use ApiClients\Foundation\Options;
 use ApiClients\Foundation\Transport\CommandBus\Command\RequestCommand;
-use ApiClients\Foundation\Transport\CommandBus\Command\StreamingRequestCommand;
 use ApiClients\Foundation\Transport\Options as TransportOptions;
 use ApiClients\Tools\CommandBus\CommandBus;
+use ApiClients\Tools\CommandBus\CommandBusInterface;
 use ApiClients\Tools\Psr7\Oauth1\Definition;
 use GuzzleHttp\Psr7\Request;
-use Psr\Http\Message\RequestInterface;
 use Psr\Http\Message\ResponseInterface;
 use React\EventLoop\LoopInterface;
 use React\Promise\PromiseInterface;
-use Rx\Extra\Operator\CutOperator;
 use Rx\Observable;
-use Rx\React\Promise;
 use function React\Promise\resolve;
 
-final class AsyncClient
+final class AsyncClient implements AsyncClientInterface
 {
     /**
      * @var string
@@ -111,9 +108,9 @@ public function withOutAccessToken(): AsyncClient
         );
     }
 
-    public function getCommandBus(): CommandBus
+    public function getCommandBus(): CommandBusInterface
     {
-        return $this->client->getFromContainer(CommandBus::class);
+        return $this->client->getFromContainer(CommandBusInterface::class);
     }
 
     public function user(string $user): PromiseInterface

src/AsyncClientInterface.php

@@ -0,0 +1,18 @@
+<?php declare(strict_types=1);
+
+namespace ApiClients\Client\Twitter;
+
+use ApiClients\Tools\CommandBus\CommandBusInterface;
+use ApiClients\Tools\Psr7\Oauth1\Definition;
+use React\Promise\PromiseInterface;
+use Rx\Observable;
+use function React\Promise\resolve;
+
+interface AsyncClientInterface
+{
+    public function withAccessToken(string $accessToken, string $accessTokenSecret): AsyncClient;
+    public function withOutAccessToken(): AsyncClient;
+    public function getCommandBus(): CommandBusInterface;
+    public function user(string $user): PromiseInterface;
+    public function stream(): AsyncStreamingClient;
+}

src/AsyncStreamingClient.php

@@ -3,26 +3,18 @@
 namespace ApiClients\Client\Twitter;
 
 use ApiClients\Foundation\Client;
-use ApiClients\Foundation\Factory;
 use ApiClients\Foundation\Hydrator\CommandBus\Command\HydrateCommand;
-use ApiClients\Foundation\Oauth1\Middleware\Oauth1Middleware;
-use ApiClients\Foundation\Oauth1\Options as Oauth1Options;
-use ApiClients\Foundation\Options;
-use ApiClients\Foundation\Transport\CommandBus\Command\RequestCommand;
 use ApiClients\Foundation\Transport\CommandBus\Command\StreamingRequestCommand;
-use ApiClients\Foundation\Transport\Options as TransportOptions;
 use ApiClients\Tools\Psr7\Oauth1\Definition;
 use GuzzleHttp\Psr7\Request;
 use Psr\Http\Message\RequestInterface;
-use Psr\Http\Message\ResponseInterface;
 use React\EventLoop\LoopInterface;
-use React\Promise\PromiseInterface;
 use Rx\Extra\Operator\CutOperator;
 use Rx\Observable;
 use Rx\React\Promise;
 use function React\Promise\resolve;
 
-final class AsyncStreamingClient
+final class AsyncStreamingClient implements AsyncStreamingClientInterface
 {
     const STREAM_DELIMITER = "\r\n";
 

src/AsyncStreamingClientInterface.php

@@ -0,0 +1,11 @@
+<?php declare(strict_types=1);
+
+namespace ApiClients\Client\Twitter;
+
+use Rx\Observable;
+
+interface AsyncStreamingClientInterface
+{
+    public function sample(): Observable;
+    public function filtered(array $filter = []): Observable;
+}

src/Client.php

@@ -8,7 +8,7 @@
 use function Clue\React\Block\await;
 use React\EventLoop\LoopInterface;
 
-final class Client
+final class Client implements ClientInterface
 {
     /**
      * @var LoopInterface

src/ClientInterface.php

@@ -0,0 +1,18 @@
+<?php declare(strict_types=1);
+
+namespace ApiClients\Client\Twitter;
+
+use ApiClients\Client\Twitter\Resource\TweetInterface;
+use ApiClients\Client\Twitter\Resource\UserInterface;
+use React\EventLoop\Factory as LoopFactory;
+use function Clue\React\Block\await;
+use React\EventLoop\LoopInterface;
+
+interface ClientInterface
+{
+    public function withAccessToken(string $accessToken, string $accessTokenSecret): Client;
+    public function withOutAccessToken(): Client;
+    public function stream(): StreamingClient;
+    public function tweet(string $tweet): TweetInterface;
+    public function user(string $tweet): UserInterface;
+}

src/StreamingClient.php

@@ -4,26 +4,26 @@
 
 use ApiClients\Foundation\Hydrator\CommandBus\Command\BuildSyncFromAsyncCommand;
 use ApiClients\Foundation\Resource\ResourceInterface;
-use ApiClients\Tools\CommandBus\CommandBus;
+use ApiClients\Tools\CommandBus\CommandBusInterface;
 use React\EventLoop\LoopInterface;
 use ReflectionObject;
 use Rx\ObservableInterface;
 use Rx\React\Promise;
 
-final class StreamingClient
+final class StreamingClient implements StreamingClientInterface
 {
     /**
      * @var LoopInterface
      */
     protected $loop;
 
     /**
-     * @var CommandBus
+     * @var CommandBusInterface
      */
     protected $commandBus;
 
     /**
-     * @var AsyncStreamingClient
+     * @var AsyncStreamingClientInterface
      */
     protected $client;
 
@@ -35,11 +35,14 @@ final class StreamingClient
     /**
      * StreamingClient constructor.
      * @param LoopInterface $loop
-     * @param CommandBus $commandBus
-     * @param AsyncStreamingClient $client
+     * @param CommandBusInterface $commandBus
+     * @param AsyncStreamingClientInterface $client
      */
-    public function __construct(LoopInterface $loop, CommandBus $commandBus, AsyncStreamingClient $client)
-    {
+    public function __construct(
+        LoopInterface $loop,
+        CommandBusInterface $commandBus,
+        AsyncStreamingClientInterface $client
+    ) {
         $this->loop = $loop;
         $this->commandBus = $commandBus;
         $this->client = $client;

src/StreamingClientInterface.php

@@ -0,0 +1,11 @@
+<?php declare(strict_types=1);
+
+namespace ApiClients\Client\Twitter;
+
+use Rx\Observable;
+
+interface StreamingClientInterface
+{
+    public function sample(callable $listener);
+    public function filtered(callable $listener, array $filter = []);
+}

tests/StreamingClientTest.php

@@ -2,18 +2,67 @@
 
 namespace ApiClients\Tests\Client\Twitter;
 
-use ApiClients\Client\Twitter\Client;
+use ApiClients\Client\Twitter\AsyncStreamingClient;
+use ApiClients\Client\Twitter\AsyncStreamingClientInterface;
+use ApiClients\Client\Twitter\StreamingClient;
+use ApiClients\Foundation\Client;
+use ApiClients\Foundation\Hydrator\CommandBus\Command\BuildSyncFromAsyncCommand;
+use ApiClients\Foundation\Transport\CommandBus\Command\StreamingRequestCommand;
+use ApiClients\Tools\CommandBus\CommandBusInterface;
 use ApiClients\Tools\TestUtilities\TestCase;
+use DI\ContainerBuilder;
+use Prophecy\Argument;
+use React\EventLoop\Factory;
+use React\EventLoop\LoopInterface;
+use Rx\Observable;
+use Rx\ObservableInterface;
 
-class ClientTest extends TestCase
+class StreamingClientTest extends TestCase
 {
-    public function testImmutability()
+    public function streamingClientProvider()
     {
-        $client = new Client('foo', 'bar');
-        $newClient = $client->withAccessToken('beer', 'baz');
-        $this->assertNotSame($client, $newClient);
-        $anotherNewClient = $newClient->withOutAccessToken();
-        $this->assertNotSame($client, $anotherNewClient);
-        $this->assertNotSame($newClient, $anotherNewClient);
+        yield [
+            'sample',
+            [],
+        ];
+
+        yield [
+            'filtered',
+            [
+                [
+                    'follow' => 'php_api_clients',
+                ],
+            ],
+        ];
+    }
+
+    /**
+     * @dataProvider streamingClientProvider
+     */
+    public function testStreamingClient(string $method, array $args)
+    {
+        $listener = function () {};
+        $loop = Factory::create();
+        $commandBus = $this->prophesize(CommandBusInterface::class);
+        $commandBus->handle(Argument::type(BuildSyncFromAsyncCommand::class))->willReturn(\React\Promise\reject());
+        /*$container = ContainerBuilder::buildDevContainer();
+        $container->set(LoopInterface::class, Factory::create());
+        $container->set(CommandBusInterface::class, $commandBus->reveal());
+        $client = new Client($container);*/
+        $observableSecond = $this->prophesize(Observable::class);
+        $observableSecond->flatMap($listener, Argument::type('callable'));
+        $observableFirst = $this->prophesize(Observable::class);
+        $observableFirst->flatMap(Argument::type('callable'))->willReturn($observableSecond->reveal());
+        $asyncStreamingClient = $this->prophesize(AsyncStreamingClientInterface::class);
+        $asyncStreamingClient->$method(...$args)->willReturn($observableFirst->reveal());
+        $streamingClient = new StreamingClient(
+            $loop,
+            $commandBus->reveal(),
+            $asyncStreamingClient->reveal()
+        );
+        $streamingClient->$method(
+            $listener,
+            ...$args
+        );
     }
 }