Added tests for the extension

Author: Nyholm

.gitignore

@@ -1,37 +1,7 @@
-# Cache and logs (Symfony2)
-/app/cache/*
-/app/logs/*
-!app/cache/.gitkeep
-!app/logs/.gitkeep
-
-# Cache and logs (Symfony3)
-/var/cache/*
-/var/logs/*
-!var/cache/.gitkeep
-!var/logs/.gitkeep
-
-# Parameters
-/app/config/parameters.yml
-/app/config/parameters.ini
-
-# Managed by Composer
-/app/bootstrap.php.cache
-/var/bootstrap.php.cache
-/bin/*
-!bin/console
-!bin/symfony_requirements
-/vendor/
-
-# Assets and user uploads
-/web/bundles/
-/web/uploads/
-
-# PHPUnit
-/app/phpunit.xml
-/phpunit.xml
+build
+phpunit.xml
+vendor
+composer.lock
+/composer.phar
 
-# Build data
-/build/
 
-# Composer PHAR
-/composer.phar

composer.json

@@ -23,7 +23,7 @@
         "php-cache/doctrine-cache":      "dev-master"
     },
     "require-dev":  {
-        "phpunit/phpunit": "^5.1|^4.0",
+        "phpunit/phpunit": "5.0.*|^4.0",
         "matthiasnoback/symfony-dependency-injection-test": "0.7.*"
     },
     "autoload":     {

src/DependencyInjection/Configuration.php

@@ -13,21 +13,6 @@
  */
 class Configuration implements ConfigurationInterface
 {
-    /**
-     * @var bool
-     */
-    private $debug;
-
-    /**
-     * Constructor.
-     *
-     * @param Boolean $debug Whether to use the debug mode
-     */
-    public function __construct($debug)
-    {
-        $this->debug = (Boolean) $debug;
-    }
-
     /**
      * Generates the configuration tree builder.
      *
@@ -55,11 +40,10 @@ private function getClustersNode()
 
         $node
             ->requiresAtLeastOneElement()
-            ->addDefaultChildrenIfNoneSet('default')
             ->useAttributeAsKey('name')
             ->prototype('array')
                 ->children()
-                    ->enumNode('type')
+                    ->enumNode('type')->isRequired()
                         ->values(array('redis', 'php_file', 'file_system', 'array', 'memcached', 'apc'))
                     ->end()
                     ->scalarNode('id')

src/DependencyInjection/DoctrineCacheExtension.php

@@ -22,7 +22,7 @@ class DoctrineCacheExtension extends Extension
      */
     public function load(array $configs, ContainerBuilder $container)
     {
-        $configuration = new Configuration($container->getParameter('kernel.debug'));
+        $configuration = new Configuration();
         $config = $this->processConfiguration($configuration, $configs);
 
         $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));

tests/DependencyInjection/DoctrineCacheExtensionTest.php

@@ -15,9 +15,10 @@ protected function getContainerExtensions()
         );
     }
 
-    public function after_loading_the_correct_parameter_has_been_set()
+    public function testThatProvidersExists()
     {
-        $this->load();
+        $providers = array('foo' => ['type'=>'apc']);
+        $this->load(array('providers' => $providers));
 
         $this->assertContainerBuilderHasParameter('doctrine_cache.providers');
     }