Better option validation for filesystem

Nyholm · Nyholm · commit 9b88a4f7c918 · 2016-01-20T09:13:28.000+01:00
diff --git a/src/Factory/FilesystemFactory.php b/src/Factory/FilesystemFactory.php
@@ -28,18 +28,16 @@ class FilesystemFactory extends AbstractAdapterFactory
      */
     public function getAdapter(array $config)
     {
-        return new FilesystemCachePool($config['flysystem']);
+        return new FilesystemCachePool($config['flysystem_service']);
     }
 
     /**
      * {@inheritdoc}
      */
     protected static function configureOptionResolver(OptionsResolver $resolver)
     {
-        $resolver->setDefaults([
-            'flysystem_service' => null,
-        ]);
+        $resolver->setRequired(['flysystem_service']);
 
-        $resolver->setAllowedTypes('host', ['string', 'object']);
+        $resolver->setAllowedTypes('flysystem_service', ['string', 'object']);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -28,18 +28,16 @@ class FilesystemFactory extends AbstractAdapterFactory`
`28`	`28`	`*/`
`29`	`29`	`public function getAdapter(array $config)`
`30`	`30`	`{`
`31`		`- return new FilesystemCachePool($config['flysystem']);`
	`31`	`+ return new FilesystemCachePool($config['flysystem_service']);`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`/**`
`35`	`35`	`* {@inheritdoc}`
`36`	`36`	`*/`
`37`	`37`	`protected static function configureOptionResolver(OptionsResolver $resolver)`
`38`	`38`	`{`
`39`		`- $resolver->setDefaults([`
`40`		`- 'flysystem_service' => null,`
`41`		`- ]);`
	`39`	`+ $resolver->setRequired(['flysystem_service']);`
`42`	`40`
`43`		`- $resolver->setAllowedTypes('host', ['string', 'object']);`
	`41`	`+ $resolver->setAllowedTypes('flysystem_service', ['string', 'object']);`
`44`	`42`	`}`
`45`	`43`	`}`