Saving an expired value should be the same as removing that value (#49)

Nyholm · Nyholm · commit 8e4cd488fda8 · 2016-04-24T10:43:10.000+02:00
* Saving an expired value should be the same as removing that value

* Updated tests version
diff --git a/AbstractCachePool.php b/AbstractCachePool.php
@@ -180,6 +180,10 @@ public function save(CacheItemInterface $item)
         if ($item instanceof HasExpirationDateInterface) {
             if (null !== $expirationDate = $item->getExpirationDate()) {
                 $timeToLive = $expirationDate->getTimestamp() - time();
+
+                if ($timeToLive < 0) {
+                    return $this->deleteItem($item->getKey());
+                }
             }
         }
 
diff --git a/composer.json b/composer.json
@@ -29,7 +29,7 @@
     },
     "require-dev":       {
         "phpunit/phpunit":         "^4.0|^5.1",
-        "cache/integration-tests": "^0.9"
+        "cache/integration-tests": "^0.10"
     },
     "autoload":          {
         "psr-4": {

Original file line number	Diff line number	Diff line change
`@@ -180,6 +180,10 @@ public function save(CacheItemInterface $item)`
`180`	`180`	`if ($item instanceof HasExpirationDateInterface) {`
`181`	`181`	`if (null !== $expirationDate = $item->getExpirationDate()) {`
`182`	`182`	`$timeToLive = $expirationDate->getTimestamp() - time();`
	`183`	`+`
	`184`	`+ if ($timeToLive < 0) {`
	`185`	`+ return $this->deleteItem($item->getKey());`
	`186`	`+ }`
`183`	`187`	`}`
`184`	`188`	`}`
`185`	`189`