Moving LoggingCachePool to compiler pass

Author: cryptiklemur

src/DependencyInjection/CacheExtension.php

@@ -35,8 +35,6 @@ public function load(array $configs, ContainerBuilder $container)
         $config = $this->processConfiguration(new Configuration(), $configs);
 
         if ($container->getParameter('kernel.debug')) {
-            $this->transformLoggableCachePools($container);
-
             $container->register('data_collector.cache', CacheDataCollector::class)
                 ->addTag('data_collector', ['template' => CacheDataCollector::TEMPLATE, 'id' => 'cache']);
         }
@@ -53,16 +51,4 @@ public function getAlias()
     {
         return 'cache';
     }
-
-    private function transformLoggableCachePools(ContainerBuilder $container)
-    {
-        $serviceIds = $container->findTaggedServiceIds('cache.provider');
-        foreach (array_keys($serviceIds) as $id) {
-            $container->setDefinition($id.'.logged', $container->findDefinition($id));
-            $def = $container->register($id.'.logger', LoggingCachePool::class);
-            $def->addArgument(new Reference($id));
-
-            $container->setAlias($id, $id.'.logger');
-        }
-    }
 }

src/DependencyInjection/Compiler/DataCollectorCompilerPass.php

@@ -25,6 +25,8 @@ class DataCollectorCompilerPass extends BaseCompilerPass
      */
     protected function prepare()
     {
+        $this->transformLoggableCachePools();
+
         $instances = $this->container->getParameter($this->getAlias() . '.instance');
 
         $definition = $this->container->getDefinition('data_collector.cache');
@@ -36,4 +38,21 @@ protected function prepare()
 
         $this->container->setDefinition('data_collector.cache', $definition);
     }
+
+    private function transformLoggableCachePools()
+    {
+        $serviceIds = $this->container->findTaggedServiceIds('cache.provider');
+        foreach (array_keys($serviceIds) as $id) {
+
+            // Duplicating definition to $originalServiceId.logged
+            $this->container->setDefinition($id.'.logged', $this->container->findDefinition($id));
+
+            // Creating a LoggingCachePool instance, and passing it the new definition from above
+            $def = $this->container->register($id.'.logger', LoggingCachePool::class);
+            $def->addArgument(new Reference($id.'.logged'));
+
+            // Overwrite the original service id with the new LoggingCachePool instance
+            $this->container->setAlias($id, $id.'.logger');
+        }
+    }
 }