Merge pull request #5 from Nyholm/patch-1

Bugfix, we should return false if fetch fails

Author: cryptiklemur

src/DoctrineCacheBridge.php

@@ -43,7 +43,13 @@ public function __construct(CacheItemPoolInterface $cachePool)
      */
     public function fetch($id)
     {
-        return $this->cachePool->getItem($id)->get();
+        $item = $this->cachePool->getItem($id);
+
+        if ($item->isHit()) {
+            return $item->get();
+        }
+
+        return false;
     }
 
     /**

tests/DoctrineCacheBridgeTest.php

@@ -53,15 +53,23 @@ public function testConstructor()
 
     public function testFetch()
     {
-        $this->itemMock->shouldReceive('get')->times(2)->andReturn(null, 'some_value');
+        $this->itemMock->shouldReceive('isHit')->times(1)->andReturn(true);
+        $this->itemMock->shouldReceive('get')->times(1)->andReturn('some_value');
 
-        $this->mock->shouldReceive('getItem')->withArgs(['no_item'])->andReturn($this->itemMock);
         $this->mock->shouldReceive('getItem')->withArgs(['some_item'])->andReturn($this->itemMock);
 
-        $this->assertEmpty($this->bridge->fetch('no_item'));
         $this->assertEquals('some_value', $this->bridge->fetch('some_item'));
     }
 
+    public function testFetchMiss()
+    {
+        $this->itemMock->shouldReceive('isHit')->times(1)->andReturn(false);
+
+        $this->mock->shouldReceive('getItem')->withArgs(['no_item'])->andReturn($this->itemMock);
+
+        $this->assertFalse($this->bridge->fetch('no_item'));
+    }
+
     public function testContains()
     {
         $this->mock->shouldReceive('hasItem')->withArgs(['no_item'])->andReturn(false);