Remove file exists check as not required (#112)

* Updated way filename is generated to allow all cache keys to work.

* fixed code style

* Removed un-required file exists check.

* fixed code for StyleCi

* removed filename fix

* removed tests relating to filename fix

* styleCi... is there an auto fix script?

* add extra check for failed unserialize.

* StyleCI tidy up

* StyleCI tidy up

Author: guyradford

FilesystemCachePool.php

@@ -9,7 +9,6 @@
  * with this source code in the file LICENSE.
  */
 
-
 namespace Cache\Adapter\Filesystem;
 
 use Cache\Adapter\Common\AbstractCachePool;
@@ -68,12 +67,12 @@ protected function fetchObjectFromCache($key)
     {
         $empty = [false, null, []];
         $file  = $this->getFilePath($key);
-        if (!$this->filesystem->has($file)) {
-            return $empty;
-        }
 
         try {
-            $data = unserialize($this->filesystem->read($file));
+            $data = @unserialize($this->filesystem->read($file));
+            if ($data === false) {
+                return $empty;
+            }
         } catch (FileNotFoundException $e) {
             return $empty;
         }
@@ -153,7 +152,7 @@ protected function storeItemInCache(CacheItemInterface $item, $ttl)
     private function getFilePath($key)
     {
         if (!preg_match('|^[a-zA-Z0-9_\.! ]+$|', $key)) {
-            throw new InvalidArgumentException(sprintf('Invalid key "%s". Valid keys must match [a-zA-Z0-9_\.! ].', $key));
+            throw new InvalidArgumentException(sprintf('Invalid key "%s". Valid filenames must match [a-zA-Z0-9_\.! ].', $key));
         }
 
         return sprintf('%s/%s', $this->folder, $key);

Tests/FilesystemCachePoolTest.php

@@ -9,7 +9,6 @@
  * with this source code in the file LICENSE.
  */
 
-
 namespace Cache\Adapter\Filesystem\Tests;
 
 /**
@@ -54,4 +53,16 @@ public function testChangeFolder()
         $pool->save($pool->getItem('test_path'));
         $this->assertTrue($this->getFilesystem()->has('foobar/test_path'));
     }
+
+    public function testCorruptedCacheFileHandledNicely()
+    {
+        $pool = $this->createCachePool();
+
+        $this->getFilesystem()->write('cache/corrupt', 'corrupt data');
+
+        $item = $pool->getItem('corrupt');
+        $this->assertFalse($item->isHit());
+
+        $this->getFilesystem()->delete('cache/corrupt');
+    }
 }