Merge pull request #1 from nicholasruunu/master

Memcache adapter

Author: Nyholm

.travis-php.ini

@@ -0,0 +1 @@
+extension = memcache.so

.travis.yml

@@ -1,25 +1,29 @@
 language: php
 php:
-  - 7.0
-  - 5.6
-  - 5.5
-  - hhvm
+  - "5.6"
+  - "5.5"
+  - "hhvm"
 
 sudo: false
 
+services:
+  - memcached
+
 matrix:
   fast_finish: true
 
 before_install:
-    - if [[ $TRAVIS_PHP_VERSION != 'hhvm' ]]; then phpenv config-rm xdebug.ini; fi;
-    - pip install --user codecov
+  - sh -c 'if [ "$TRAVIS_PHP_VERSION" != "hhvm" ]; then phpenv config-rm xdebug.ini; fi;'
+  - pip install --user codecov
 
 before_script:
+   # Need to activate memchache extension explictly to work with all versions.
+  - sh -c 'if [ "$TRAVIS_PHP_VERSION" != "hhvm" ]; then phpenv config-add .travis-php.ini; fi;'
   - travis_retry composer self-update
   - travis_retry composer install --prefer-source --no-interaction
 
 script:
-    - php -dzend_extension=xdebug.so vendor/bin/phpunit --coverage-clover=coverage.xml
+  - php -dzend_extension=xdebug.so vendor/bin/phpunit --coverage-clover=coverage.xml
 
 after_success:
-    - codecov
+  - codecov

composer.json

@@ -27,7 +27,8 @@
     ],
     "require":
     {
-        "php":                  "^5.5|7.0",
+        "php":                  "^5.5",
+        "ext-memcache":         "*",
         "psr/cache":            "1.0.0",
         "cache/adapter-common": "^0.1",
         "cache/taggable-cache": "^0.2"

src/ApcCachePool.php src/MemcacheCachePool.phpsrc/ApcCachePool.php renamed to src/MemcacheCachePool.php

@@ -12,30 +12,40 @@
 namespace Cache\Adapter\Memcache;
 
 use Cache\Adapter\Common\AbstractCachePool;
+use Memcache;
 use Psr\Cache\CacheItemInterface;
 
-/**
- *
- */
 class MemcacheCachePool extends AbstractCachePool
 {
+    /**
+     * @var Memcache
+     */
+    private $cache;
+
+    public function __construct(Memcache $cache)
+    {
+        $this->cache = $cache;
+    }
+
     protected function fetchObjectFromCache($key)
     {
-        return false;
+        return $this->cache->get($key);
     }
 
     protected function clearAllObjectsFromCache()
     {
-        return true;
+        return $this->cache->flush();
     }
 
     protected function clearOneObjectFromCache($key)
     {
+        $this->cache->delete($key);
+
         return true;
     }
 
     protected function storeItemInCache($key, CacheItemInterface $item, $ttl)
     {
-        return true;
+        return $this->cache->set($key, $item, 0, $ttl ?: 0);
     }
 }

tests/IntegrationPoolTest.php

@@ -13,11 +13,24 @@
 
 use Cache\Adapter\Memcache\MemcacheCachePool;
 use Cache\IntegrationTests\CachePoolTest;
+use Memcache;
 
 class IntegrationPoolTest extends CachePoolTest
 {
+    private $client;
+
     public function createCachePool()
     {
-        return new MemcacheCachePool();
+        return new MemcacheCachePool($this->getClient());
+    }
+
+    private function getClient()
+    {
+        if ($this->client === null) {
+            $this->client = new Memcache;
+            $this->client->connect('localhost', 11211);
+        }
+
+        return $this->client;
     }
 }

tests/IntegrationTagTest.php

@@ -13,11 +13,24 @@
 
 use Cache\Adapter\Memcache\MemcacheCachePool;
 use Cache\IntegrationTests\TaggableCachePoolTest;
+use Memcache;
 
 class IntegrationTagTest extends TaggableCachePoolTest
 {
+    private $client;
+
     public function createCachePool()
     {
-        return new MemcacheCachePool();
+        return new MemcacheCachePool($this->getClient());
+    }
+
+    private function getClient()
+    {
+        if ($this->client === null) {
+            $this->client = new Memcache;
+            $this->client->connect('localhost', 11211);
+        }
+
+        return $this->client;
     }
 }