Merge pull request #4 from basakest/batch-adapter

feat: support Casbin BatchAdapter interface

Author: leeqvip

src/Adapter.php

@@ -4,6 +4,7 @@
 
 use Casbin\Exceptions\CasbinException;
 use Casbin\Persist\Adapter as AdapterContract;
+use Casbin\Persist\BatchAdapter as BatchAdapterContract;
 use Casbin\Persist\AdapterHelper;
 use Cake\ORM\TableRegistry;
 use CasbinAdapter\Cake\Model\Table\CasbinRuleTable;
@@ -13,7 +14,7 @@
  *
  * @author [email protected]
  */
-class Adapter implements AdapterContract
+class Adapter implements AdapterContract, BatchAdapterContract
 {
     use AdapterHelper;
 
@@ -85,6 +86,54 @@ public function removeFilteredPolicy($sec, $ptype, $fieldIndex, ...$fieldValues)
         throw new CasbinException('not implemented');
     }
 
+    /**
+     * Adds a policy rules to the storage.
+     * This is part of the Auto-Save feature.
+     *
+     * @param string $sec
+     * @param string $ptype
+     * @param string[][] $rules
+     */
+    public function addPolicies(string $sec, string $ptype, array $rules): void
+    {
+        $cols = [];
+        $i = 0;
+
+        foreach ($rules as $rule) {
+            $temp['`ptype`'] = $ptype;
+            foreach ($rule as $key => $value) {
+                $temp['`v'. strval($key) . '`'] = $value;
+            }
+            $cols[$i++] = $temp ?? [];
+            $temp = [];
+        }
+        $entities = $this->table->newEntity($cols);
+        $this->table->saveMany($entities);
+    }
+
+    /**
+     * Removes policy rules from the storage.
+     * This is part of the Auto-Save feature.
+     *
+     * @param string $sec
+     * @param string $ptype
+     * @param string[][] $rules
+     */
+    public function removePolicies(string $sec, string $ptype, array $rules): void
+    {
+        $this->table->getConnection()->transactional(function () use ($ptype, $rules) {
+            foreach ($rules as $rule) {
+                $entity = $this->table->find();
+
+                foreach ($rule as $key => $value) {
+                    $entity->where(['v' . strval($key) => $value]);
+                }
+                $entity = $entity->first();
+                $this->table->delete($entity, ['atomic' => false]);
+            }
+        });
+    }
+
     protected function getTable()
     {
         return  TableRegistry::getTableLocator()->get('CasbinRule', [

src/Casbin.php

@@ -27,7 +27,7 @@ public function __construct($config = [])
         $config = Configure::consume('Casbin');
 
         $this->config = $this->mergeConfig(
-            require_once dirname(__DIR__).'/config/casbin.php',
+            require dirname(__DIR__).'/config/casbin.php',
             $config
         );
         if (is_string($config['adapter'])) {

tests/DatabaseAdapterTest.php

@@ -86,4 +86,51 @@ public function testAddPolicy()
         $e->addPermissionForUser('eve', 'data3', 'read');
         $this->assertTrue($e->enforce('eve', 'data3', 'read'));
     }
+
+    public function testAddPolicies()
+    {
+        $policies = [
+            ['u1', 'd1', 'read'],
+            ['u2', 'd2', 'read'],
+            ['u3', 'd3', 'read'],
+        ];
+        $e = $this->getEnforcer();
+        $e->clearPolicy();
+        $this->assertEquals([], $e->getPolicy());
+        $e->addPolicies($policies);
+        $this->assertEquals($policies, $e->getPolicy());
+    }
+
+    public function testRemovePolicy()
+    {
+        $e = $this->getEnforcer();
+        $this->assertFalse($e->enforce('alice', 'data5', 'read'));
+
+        $e->addPermissionForUser('alice', 'data5', 'read');
+        $this->assertTrue($e->enforce('alice', 'data5', 'read'));
+
+        $e->deletePermissionForUser('alice', 'data5', 'read');
+        $this->assertFalse($e->enforce('alice', 'data5', 'read'));
+    }
+
+    public function testRemovePolicies()
+    {
+        $e = $this->getEnforcer();
+        $this->assertEquals([
+            ['alice', 'data1', 'read'],
+            ['bob', 'data2', 'write'],
+            ['data2_admin', 'data2', 'read'],
+            ['data2_admin', 'data2', 'write'],
+        ], $e->getPolicy());
+
+        $e->removePolicies([
+            ['data2_admin', 'data2', 'read'],
+            ['data2_admin', 'data2', 'write'],
+        ]);
+
+        $this->assertEquals([
+            ['alice', 'data1', 'read'],
+            ['bob', 'data2', 'write']
+        ], $e->getPolicy());
+    }
 }