Add none option or array declaration.

Author: dereuromark

PhpCollective/Sniffs/Formatting/ArrayDeclarationSniff.php

@@ -657,10 +657,8 @@ protected function processMultiLineIndentation(File $phpcsFile, int $arrayStart,
                             continue;
                         }
 
-                        // In 'assoc' mode, only fix associative items
-                        if ($this->multiLineIndentationMode === 'assoc' && !$p['is_associative']) {
-                            continue;
-                        }
+                        // In 'assoc' mode, when we have mixed items on a line, we need to fix all of them
+                        // Don't skip non-associative items when they're on the same line as associative ones
 
                         $targetPtr = $p['key'] ?? $p['value'];
 

tests/PhpCollective/Sniffs/Formatting/ArrayDeclarationSniffTest.php

@@ -17,7 +17,7 @@ class ArrayDeclarationSniffTest extends TestCase
      */
     public function testDocBlockConstSniffer(): void
     {
-        $this->assertSnifferFindsErrors(new ArrayDeclarationSniff(), 3);
+        $this->assertSnifferFindsErrors(new ArrayDeclarationSniff(), 4);
     }
 
     /**

tests/_data/ArrayDeclaration/after.php

@@ -28,5 +28,13 @@ public function test(): void
             'first' => ['a', 'b'],
             'second' => ['c', 'd'],
         ];
+
+        // Mixed associative and non-associative items - SHOULD be flagged
+        $url = [
+            'controller' => 'ControllerName',
+            'action' => 'view',
+            $uuid,
+            '?' => ['pdf' => 1],
+        ];
     }
 }

tests/_data/ArrayDeclaration/before.php

@@ -24,5 +24,12 @@ public function test(): void
         $multi = [
             'first' => ['a', 'b'], 'second' => ['c', 'd'],
         ];
+
+        // Mixed associative and non-associative items - SHOULD be flagged
+        $url = [
+            'controller' => 'ControllerName',
+            'action' => 'view', $uuid,
+            '?' => ['pdf' => 1],
+        ];
     }
 }