Skip to content

Commit 25a0861

Browse files
committed
Fixing risky tests
Makring tests that have no assertions with the annotation to suppress phpunits warning around risky tests closes 1370
1 parent 2375961 commit 25a0861

File tree

4 files changed

+15
-0
lines changed

4 files changed

+15
-0
lines changed

Tests/DbalConsumerTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,9 @@ public function testShouldImplementConsumerInterface()
2828
$this->assertClassImplements(Consumer::class, DbalConsumer::class);
2929
}
3030

31+
/**
32+
* @doesNotPerformAssertions
33+
*/
3134
public function testCouldBeConstructedWithRequiredArguments()
3235
{
3336
new DbalConsumer($this->createContextMock(), new DbalDestination('queue'));

Tests/DbalContextTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,9 @@ public function testShouldImplementContextInterface()
2727
$this->assertClassImplements(Context::class, DbalContext::class);
2828
}
2929

30+
/**
31+
* @doesNotPerformAssertions
32+
*/
3033
public function testCouldBeConstructedWithRequiredArguments()
3134
{
3235
new DbalContext($this->createConnectionMock());

Tests/DbalProducerTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@ public function testShouldImplementProducerInterface()
2121
$this->assertClassImplements(Producer::class, DbalProducer::class);
2222
}
2323

24+
/**
25+
* @doesNotPerformAssertions
26+
*/
2427
public function testCouldBeConstructedWithRequiredArguments()
2528
{
2629
new DbalProducer($this->createContextMock());

Tests/DbalSubscriptionConsumerTest.php

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,9 @@ public function testShouldImplementSubscriptionConsumerInterface()
2525
$this->assertTrue($rc->implementsInterface(SubscriptionConsumer::class));
2626
}
2727

28+
/**
29+
* @doesNotPerformAssertions
30+
*/
2831
public function testCouldBeConstructedWithDbalContextAsFirstArgument()
2932
{
3033
new DbalSubscriptionConsumer($this->createDbalContextMock());
@@ -66,6 +69,9 @@ public function testThrowsIfTrySubscribeAnotherConsumerToAlreadySubscribedQueue(
6669
$subscriptionConsumer->subscribe($barConsumer, $barCallback);
6770
}
6871

72+
/**
73+
* @doesNotPerformAssertions
74+
*/
6975
public function testShouldAllowSubscribeSameConsumerAndCallbackSecondTime()
7076
{
7177
$subscriptionConsumer = new DbalSubscriptionConsumer($this->createDbalContextMock());

0 commit comments

Comments
 (0)