Pass PSR-18 compliant HTTP client to FeedIo facade

Author: bezin

src/FeedIo/Adapter/Client.php

@@ -11,23 +11,10 @@
 
 class Client implements ClientInterface
 {
-    public const DEFAULT_USER_AGENT = 'Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.9.1.1) Gecko/20090715 Firefox/3.5.1';
-
-    public function __construct(private PsrClientInterface $client, private string $userAgent = self::DEFAULT_USER_AGENT)
+    public function __construct(private PsrClientInterface $client)
     {
     }
 
-    /**
-     * @param string $userAgent The new user-agent
-     * @return self
-     */
-    public function setUserAgent(string $userAgent): Client
-    {
-        $this->userAgent = $userAgent;
-
-        return $this;
-    }
-
     /**
      * @param string $url
      * @param DateTime|null $modifiedSince
@@ -81,7 +68,6 @@ protected function getHeaders(DateTime $modifiedSince = null): array
     {
         $headers = [
             'Accept-Encoding' => 'gzip, deflate',
-            'User-Agent' => $this->userAgent,
         ];
 
         if ($modifiedSince) {

src/FeedIo/FeedIo.php

@@ -5,11 +5,11 @@
 namespace FeedIo;
 
 use DateTime;
-use FeedIo\Adapter\ClientInterface;
-use FeedIo\Adapter\NullClient;
+use FeedIo\Adapter\Client;
 use FeedIo\Http\ResponseBuilder;
 use FeedIo\Reader\Result;
 use FeedIo\Rule\DateTimeBuilderInterface;
+use Psr\Http\Client\ClientInterface;
 use Psr\Http\Message\ResponseInterface;
 use Psr\Log\LoggerInterface;
 use Psr\Log\NullLogger;
@@ -67,10 +67,14 @@ class FeedIo
     protected Reader $reader;
 
     public function __construct(
-        protected ClientInterface $client = new NullClient(),
+        ?ClientInterface $client = null,
         protected LoggerInterface $logger = new NullLogger(),
         protected ?SpecificationInterface $specification = null,
     ) {
+        if (is_null($client)) {
+            throw new \Exception('You must provide a PSR18-compliant HTTP client');
+        }
+        $this->client = new Client($client);
         if (is_null($this->specification)) {
             $this->specification = new Specification($this->logger);
         }