fix implicit null with rector

Author: Grotax

.github/workflows/phpstan-baseline.yml

@@ -30,4 +30,4 @@ jobs:
         fi
         
     - name: Run PHPStan with baseline
-      run: vendor/bin/phpstan analyse --error-format=github
+      run: vendor/bin/phpstan analyse --error-format=github

src/FeedIo/Adapter/ClientInterface.php

@@ -21,5 +21,5 @@ interface ClientInterface
      * @throws \FeedIo\Adapter\ServerErrorException
      * @return \FeedIo\Adapter\ResponseInterface
      */
-    public function getResponse(string $url, DateTime $modifiedSince = null): ResponseInterface;
+    public function getResponse(string $url, ?DateTime $modifiedSince = null): ResponseInterface;
 }

src/FeedIo/Adapter/FileSystem/Client.php

@@ -20,7 +20,7 @@ class Client implements ClientInterface
      * @return \FeedIo\Adapter\ResponseInterface
      *@throws \FeedIo\Adapter\NotFoundException
      */
-    public function getResponse(string $path, DateTime $modifiedSince = null): ResponseInterface
+    public function getResponse(string $path, ?DateTime $modifiedSince = null): ResponseInterface
     {
         if (file_exists($path)) {
             return new Response(

src/FeedIo/Adapter/Http/Client.php

@@ -25,7 +25,7 @@ public function __construct(private readonly PsrClientInterface $client)
      * @return ResponseInterface
      * @throws ClientExceptionInterface
      */
-    public function getResponse(string $url, DateTime $modifiedSince = null): ResponseInterface
+    public function getResponse(string $url, ?DateTime $modifiedSince = null): ResponseInterface
     {
         if ($modifiedSince) {
             $headResponse = $this->request('HEAD', $url, $modifiedSince);
@@ -44,7 +44,7 @@ public function getResponse(string $url, DateTime $modifiedSince = null): Respon
      * @return ResponseInterface
      * @throws ClientExceptionInterface
      */
-    protected function request(string $method, string $url, DateTime $modifiedSince = null): ResponseInterface
+    protected function request(string $method, string $url, ?DateTime $modifiedSince = null): ResponseInterface
     {
         $headers = [];
 

src/FeedIo/Adapter/NullClient.php

@@ -16,7 +16,7 @@ class NullClient implements ClientInterface
      * @param  DateTime|null                         $modifiedSince
      * @return \FeedIo\Adapter\ResponseInterface
      */
-    public function getResponse(string $url, DateTime $modifiedSince = null): ResponseInterface
+    public function getResponse(string $url, ?DateTime $modifiedSince = null): ResponseInterface
     {
         return new NullResponse();
     }

src/FeedIo/Explorer.php

@@ -36,7 +36,7 @@ public function discover(string $url): array
         return $feeds;
     }
 
-    protected function extractFeeds(string $html, string $url = null): array    
+    protected function extractFeeds(string $html, ?string $url = null): array    
     {
         $dom = new DOMDocument();
         $dom->loadHTML($html);

src/FeedIo/Feed.php

@@ -49,7 +49,7 @@ public function getUrl(): ?string
      * @param string|null $url
      * @return FeedInterface
      */
-    public function setUrl(string $url = null): FeedInterface
+    public function setUrl(?string $url = null): FeedInterface
     {
         $this->url = $url;
 
@@ -64,7 +64,7 @@ public function getDescription(): ?string
         return $this->description;
     }
 
-    public function setDescription(string $description = null): FeedInterface
+    public function setDescription(?string $description = null): FeedInterface
     {
         $this->description = $description;
 
@@ -76,7 +76,7 @@ public function getLanguage(): ?string
         return $this->language;
     }
 
-    public function setLanguage(string $language = null): FeedInterface
+    public function setLanguage(?string $language = null): FeedInterface
     {
         $this->language = $language;
 
@@ -88,7 +88,7 @@ public function getLogo(): ?string
         return $this->logo;
     }
 
-    public function setLogo(string $logo = null): FeedInterface
+    public function setLogo(?string $logo = null): FeedInterface
     {
         $this->logo = $logo;
 

src/FeedIo/Feed/Item.php

@@ -70,7 +70,7 @@ public function getSummary(): ?string
      * @param string|null $summary
      * @return ItemInterface
      */
-    public function setSummary(string $summary = null): ItemInterface
+    public function setSummary(?string $summary = null): ItemInterface
     {
         $this->summary = $summary;
 
@@ -90,7 +90,7 @@ public function getContent(): ?string
      * @param string|null $content
      * @return ItemInterface
      */
-    public function setContent(string $content = null): ItemInterface
+    public function setContent(?string $content = null): ItemInterface
     {
         $this->content = $content;
 

src/FeedIo/Feed/Item/Author.php

@@ -26,7 +26,7 @@ public function getName(): ?string
      * @param string|null $name
      * @return AuthorInterface
      */
-    public function setName(string $name = null): AuthorInterface
+    public function setName(?string $name = null): AuthorInterface
     {
         $this->name = $name;
 
@@ -45,7 +45,7 @@ public function getUri(): ?string
      * @param string|null $uri
      * @return AuthorInterface
      */
-    public function setUri(string $uri = null): AuthorInterface
+    public function setUri(?string $uri = null): AuthorInterface
     {
         $this->uri = $uri;
 
@@ -64,7 +64,7 @@ public function getEmail(): ?string
      * @param string|null $email
      * @return AuthorInterface
      */
-    public function setEmail(string $email = null): AuthorInterface
+    public function setEmail(?string $email = null): AuthorInterface
     {
         $this->email = $email;
 

src/FeedIo/Feed/Item/AuthorInterface.php

@@ -19,7 +19,7 @@ public function getName(): ?string;
      * @param  string $name
      * @return AuthorInterface
      */
-    public function setName(string $name = null): AuthorInterface;
+    public function setName(?string $name = null): AuthorInterface;
 
     /**
      * @return string
@@ -30,7 +30,7 @@ public function getUri(): ?string;
      * @param  string $uri
      * @return AuthorInterface
      */
-    public function setUri(string $uri = null): AuthorInterface;
+    public function setUri(?string $uri = null): AuthorInterface;
 
     /**
      * @return string
@@ -41,5 +41,5 @@ public function getEmail(): ?string;
      * @param  string $email
      * @return AuthorInterface
      */
-    public function setEmail(string $email = null): AuthorInterface;
+    public function setEmail(?string $email = null): AuthorInterface;
 }