Handle HTTP redirection responses in Client.php #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…L support; add tests for response behavior
There was a problem hiding this comment.
Pull Request Overview
This PR adds HTTP redirect handling capabilities to the FeedIo HTTP client with support for all standard redirect status codes (301, 302, 303, 307, 308), including protection against infinite redirect loops and relative URL resolution.
- Implements automatic following of HTTP redirects with configurable maximum limit (10 redirects)
- Adds support for both absolute and relative redirect URLs
- Preserves If-Modified-Since headers through redirect chains
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| src/FeedIo/Adapter/Http/Client.php | Adds redirect handling logic with MAX_REDIRECTS constant, handleRedirect method for processing redirect responses, and resolveRedirectUrl method for converting relative URLs to absolute |
| tests/FeedIo/Adapter/Http/ClientTest.php | Comprehensive test suite covering redirect scenarios including multiple redirects, different status codes, empty Location headers, and duration tracking |
| CHANGELOG.md | Documents the new HTTP redirect handling feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
… reject malicious redirect schemes
…n relative and absolute paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.