Skip to content

Commit afe3aa0

Browse files
committed
Apply fixed Coderrabitai review.
1 parent da959af commit afe3aa0

File tree

8 files changed

+7
-7864
lines changed

8 files changed

+7
-7864
lines changed

composer.lock

Lines changed: 0 additions & 7850 deletions
This file was deleted.

ecs.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,4 @@
9191
OrderedTraitsFixer::class,
9292
SingleQuoteFixer::class,
9393
]
94-
)
95-
->withSkip(
96-
[
97-
NullableTypeDeclarationFixer::class,
98-
]
9994
);

src/Config/Config.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ private function getByManager(string $key, mixed $value, mixed $default = null):
166166
*/
167167
private function getDefaultValue(string $key, mixed $default = null): mixed
168168
{
169-
$value = null === $default && array_key_exists($key, $this->defaults)
169+
$value = null === $default && array_key_exists($key, $this->defaults)
170170
? $this->defaults[$key]
171171
: $default;
172172

src/FoxyEvents.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44

55
namespace Foxy;
66

7-
use Event;
8-
97
abstract class FoxyEvents
108
{
119
/**

src/Solver/Solver.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@
1313
use Foxy\Asset\AssetManagerInterface;
1414
use Foxy\Config\Config;
1515
use Foxy\Event\{GetAssetsEvent, PostSolveEvent, PreSolveEvent};
16+
use Foxy\Exception\RuntimeException;
1617
use Foxy\Fallback\FallbackInterface;
1718
use Foxy\FoxyEvents;
1819
use Foxy\Util\AssetUtil;
19-
use RuntimeException;
2020

2121
use function basename;
2222
use function copy;

tests/Fallback/AssetFallbackTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ public function testRestoreThrowsWhenRemoveFails(): void
7676
->expects(self::once())
7777
->method('remove')
7878
->with('package.json')
79-
->willThrowException(new \RuntimeException('Remove failed.'));
79+
->willThrowException(new RuntimeException('Remove failed.'));
8080

8181
$this->assetFallback->save();
8282

tests/Fallback/ComposerFallbackTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ public function testRestore(array $packages): void
7878
$this->input
7979
->expects(self::any())
8080
->method('getOption')
81-
->willReturnCallback(fn($option): ?bool => 'verbose' === $option ? false : null);
81+
->willReturnCallback(fn($option): bool|null => 'verbose' === $option ? false : null);
8282

8383
$ed = $this->createMock(EventDispatcher::class);
8484

tests/Util/PackageUtilTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public function testConvertLockAlias(): void
4848
$convertedAliases = PackageUtil::convertLockAlias($lockData);
4949

5050
self::assertArrayHasKey('aliases', $convertedAliases);
51-
self::assertEquals($convertedAliases['aliases'], $expectedAliases);
51+
self::assertEquals($expectedAliases, $convertedAliases['aliases']);
5252
}
5353

5454
public function testLoadLockPackages(): void
@@ -75,8 +75,8 @@ public function testLoadLockPackages(): void
7575

7676
self::assertArrayHasKey('packages', $lockDataLoaded);
7777
self::assertArrayHasKey('packages-dev', $lockDataLoaded);
78-
self::assertEquals($lockDataLoaded['packages'], $expectedPackages);
79-
self::assertEquals($lockDataLoaded['packages-dev'], $expectedDevPackages);
78+
self::assertEquals($expectedPackages, $lockDataLoaded['packages']);
79+
self::assertEquals($expectedDevPackages, $lockDataLoaded['packages-dev']);
8080
}
8181

8282
public function testLoadLockPackagesWithoutPackages(): void

0 commit comments

Comments
 (0)