fix(tests): Simplify testRestoreWithIgnorePlatformReq and testRestoreWithIgnorePlatformReqs by extracting common setup logic.

Author: terabytesoftw

tests/Fallback/ComposerFallbackTest.php

@@ -156,69 +156,19 @@ public function testRestoreWithDisableOption(): void
      */
     public function testRestoreWithIgnorePlatformReq(string $optionName, mixed $optionValue): void
     {
-        $composerFile = 'composer.json';
-        $composerContent = '{}';
-        $lockFile = 'composer.lock';
-        $vendorDir = $this->cwd . '/vendor/';
         $packages = [['name' => 'foo/bar', 'version' => '1.0.0.0']];
 
-        file_put_contents($this->cwd . '/' . $composerFile, $composerContent);
-        file_put_contents(
-            $this->cwd . '/' . $lockFile,
-            json_encode(
-                [
-                    'content-hash' => 'HASH_VALUE',
-                    'packages' => $packages,
-                    'packages-dev' => [],
-                    'prefer-stable' => true,
-                ],
-                JSON_THROW_ON_ERROR,
-            ),
+        $this->setupRestoreEnvironment(
+            $packages,
+            fn($option): mixed => match ($option) {
+                'ignore-platform-reqs' => null,
+                $optionName => $optionValue,
+                'verbose' => false,
+                default => null,
+            },
         );
 
-        $this->input
-            ->expects(self::any())
-            ->method('getOption')
-            ->willReturnCallback(
-                fn($option): mixed => match ($option) {
-                    'ignore-platform-reqs' => null,
-                    $optionName => $optionValue,
-                    'verbose' => false,
-                    default => null,
-                },
-            );
-
-        $ed = $this->createMock(EventDispatcher::class);
-
-        $this->composer->expects(self::any())->method('getEventDispatcher')->willReturn($ed);
-
-        $rm = $this->createMock(RepositoryManager::class);
-
-        $this->composer->expects(self::any())->method('getRepositoryManager')->willReturn($rm);
-
-        $im = $this->createMock(InstallationManager::class);
-
-        $this->composer->expects(self::any())->method('getInstallationManager')->willReturn($im);
-        $this->io->expects(self::once())->method('write');
-
-        $locker = LockerUtil::getLocker($this->io, $im, $composerFile);
-
-        $this->composer->expects(self::atLeastOnce())->method('getLocker')->willReturn($locker);
-
-        $config = $this->getMockBuilder(\Composer\Config::class)
-            ->disableOriginalConstructor()
-            ->onlyMethods(['get'])
-            ->getMock();
-
-        $this->composer->expects(self::atLeastOnce())->method('getConfig')->willReturn($config);
-
-        $config
-            ->expects(self::atLeastOnce())
-            ->method('get')
-            ->willReturnCallback(fn($key, $default = null) => 'vendor-dir' === $key ? $vendorDir : $default);
-
         $this->installer->expects(self::once())->method('run');
-
         $this->composerFallback->save();
         $this->composerFallback->restore();
     }
@@ -230,68 +180,18 @@ public function testRestoreWithIgnorePlatformReq(string $optionName, mixed $opti
      */
     public function testRestoreWithIgnorePlatformReqs(string $optionName, mixed $optionValue): void
     {
-        $composerFile = 'composer.json';
-        $composerContent = '{}';
-        $lockFile = 'composer.lock';
-        $vendorDir = $this->cwd . '/vendor/';
         $packages = [['name' => 'foo/bar', 'version' => '1.0.0.0']];
 
-        file_put_contents($this->cwd . '/' . $composerFile, $composerContent);
-        file_put_contents(
-            $this->cwd . '/' . $lockFile,
-            json_encode(
-                [
-                    'content-hash' => 'HASH_VALUE',
-                    'packages' => $packages,
-                    'packages-dev' => [],
-                    'prefer-stable' => true,
-                ],
-                JSON_THROW_ON_ERROR,
-            ),
+        $this->setupRestoreEnvironment(
+            $packages,
+            fn($option): mixed => match ($option) {
+                $optionName => $optionValue,
+                'verbose' => false,
+                default => null,
+            },
         );
 
-        $this->input
-            ->expects(self::any())
-            ->method('getOption')
-            ->willReturnCallback(
-                fn($option): mixed => match ($option) {
-                    $optionName => $optionValue,
-                    'verbose' => false,
-                    default => null,
-                },
-            );
-
-        $ed = $this->createMock(EventDispatcher::class);
-
-        $this->composer->expects(self::any())->method('getEventDispatcher')->willReturn($ed);
-
-        $rm = $this->createMock(RepositoryManager::class);
-
-        $this->composer->expects(self::any())->method('getRepositoryManager')->willReturn($rm);
-
-        $im = $this->createMock(InstallationManager::class);
-
-        $this->composer->expects(self::any())->method('getInstallationManager')->willReturn($im);
-        $this->io->expects(self::once())->method('write');
-
-        $locker = LockerUtil::getLocker($this->io, $im, $composerFile);
-
-        $this->composer->expects(self::atLeastOnce())->method('getLocker')->willReturn($locker);
-
-        $config = $this->getMockBuilder(\Composer\Config::class)
-            ->disableOriginalConstructor()
-            ->onlyMethods(['get'])
-            ->getMock();
-
-        $this->composer->expects(self::atLeastOnce())->method('getConfig')->willReturn($config);
-
-        $config
-            ->expects(self::atLeastOnce())
-            ->method('get')
-            ->willReturnCallback(fn($key, $default = null) => 'vendor-dir' === $key ? $vendorDir : $default);
-
         $this->installer->expects(self::once())->method('run');
-
         $this->composerFallback->save();
         $this->composerFallback->restore();
     }
@@ -372,4 +272,60 @@ protected function tearDown(): void
         $this->oldCwd = null;
         $this->cwd = null;
     }
+
+    private function setupRestoreEnvironment(
+        array $packages,
+        callable $optionCallback,
+    ): void {
+        $composerFile = 'composer.json';
+        $composerContent = '{}';
+        $lockFile = 'composer.lock';
+        $vendorDir = $this->cwd . '/vendor/';
+
+        file_put_contents($this->cwd . '/' . $composerFile, $composerContent);
+        file_put_contents(
+            $this->cwd . '/' . $lockFile,
+            json_encode(
+                [
+                    'content-hash' => 'HASH_VALUE',
+                    'packages' => $packages,
+                    'packages-dev' => [],
+                    'prefer-stable' => true,
+                ],
+                JSON_THROW_ON_ERROR,
+            ),
+        );
+
+        $this->input
+            ->expects(self::any())
+            ->method('getOption')
+            ->willReturnCallback($optionCallback);
+
+        $eventDispatcher = $this->createMock(EventDispatcher::class);
+        $this->composer->expects(self::any())->method('getEventDispatcher')->willReturn($eventDispatcher);
+
+        $repositoryManager = $this->createMock(RepositoryManager::class);
+        $this->composer->expects(self::any())->method('getRepositoryManager')->willReturn($repositoryManager);
+
+        $installationManager = $this->createMock(InstallationManager::class);
+        $this->composer->expects(self::any())->method('getInstallationManager')->willReturn($installationManager);
+
+        $this->io->expects(self::once())->method('write');
+
+        $locker = LockerUtil::getLocker($this->io, $installationManager, $composerFile);
+
+        $this->composer->expects(self::atLeastOnce())->method('getLocker')->willReturn($locker);
+
+        $config = $this->getMockBuilder(\Composer\Config::class)
+            ->disableOriginalConstructor()
+            ->onlyMethods(['get'])
+            ->getMock();
+
+        $this->composer->expects(self::atLeastOnce())->method('getConfig')->willReturn($config);
+
+        $config
+            ->expects(self::atLeastOnce())
+            ->method('get')
+            ->willReturnCallback(fn($key, $default = null) => 'vendor-dir' === $key ? $vendorDir : $default);
+    }
 }