Skip to content

Commit 8f631d4

Browse files
committed
Move to-rad conversion in the call, so that we can reuse each C-function.
1 parent d585b9d commit 8f631d4

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

geospatial.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -102,15 +102,15 @@ double php_geo_haversine(double from_lat, double from_long, double to_lat, doubl
102102
double delta_lat, delta_long;
103103
double latH, longH, result;
104104

105-
delta_lat = (from_lat - to_lat) * GEO_DEG_TO_RAD;
106-
delta_long = (from_long - to_long) * GEO_DEG_TO_RAD;
105+
delta_lat = (from_lat - to_lat);
106+
delta_long = (from_long - to_long);
107107

108108
latH = sin(delta_lat * 0.5);
109109
latH *= latH;
110110
longH = sin(delta_long * 0.5);
111111
longH *= longH;
112112

113-
result = cos(from_lat * GEO_DEG_TO_RAD) * cos(to_lat * GEO_DEG_TO_RAD);
113+
result = cos(from_lat) * cos(to_lat);
114114
result = radius * 2.0 * asin(sqrt(latH + result * longH));
115115

116116
return result;
@@ -127,7 +127,7 @@ PHP_FUNCTION(haversine)
127127
return;
128128
}
129129

130-
RETURN_DOUBLE(php_geo_haversine(from_lat, from_long, to_lat, to_long, radius));
130+
RETURN_DOUBLE(php_geo_haversine(from_lat * GEO_DEG_TO_RAD, from_long * GEO_DEG_TO_RAD, to_lat * GEO_DEG_TO_RAD, to_long * GEO_DEG_TO_RAD, radius) / GEO_DEG_TO_RAD);
131131
}
132132
/* }}} */
133133

0 commit comments

Comments
 (0)