Pull-Request Feedback for "Wrapped php-http/cache-plugin Cache Listeners"

 - Reverted unwanted style changes (even though a additional space at
   string concat is really nice ;))

Author: Till Hildebrandt

tests/Unit/DependencyInjection/ConfigurationTest.php

@@ -96,7 +96,7 @@ protected function getConfiguration(): ConfigurationInterface
     public function testEmptyConfiguration(): void
     {
         $formats = array_map(function ($path) {
-            return __DIR__ . '/../../Resources/Fixtures/' . $path;
+            return __DIR__.'/../../Resources/Fixtures/'.$path;
         }, [
             'config/empty.yml',
             'config/empty.xml',
@@ -277,7 +277,7 @@ public function testSupportsAllConfigFormats(): void
         ];
 
         $formats = array_map(function ($path) {
-            return __DIR__ . '/../../Resources/Fixtures/' . $path;
+            return __DIR__.'/../../Resources/Fixtures/'.$path;
         }, [
             'config/full.yml',
             'config/full.xml',
@@ -291,7 +291,7 @@ public function testSupportsAllConfigFormats(): void
 
     public function testMissingClass(): void
     {
-        $file = __DIR__ . '/../../Resources/Fixtures/config/invalid_class.yml';
+        $file = __DIR__.'/../../Resources/Fixtures/config/invalid_class.yml';
 
         $this->expectException(InvalidConfigurationException::class);
         $this->expectExceptionMessage('Nonexisting\Class');
@@ -300,7 +300,7 @@ public function testMissingClass(): void
 
     public function testInvalidPlugin(): void
     {
-        $file = __DIR__ . '/../../Resources/Fixtures/config/invalid_plugin.yml';
+        $file = __DIR__.'/../../Resources/Fixtures/config/invalid_plugin.yml';
 
         $this->expectException(InvalidConfigurationException::class);
         $this->expectExceptionMessage('Unrecognized option "foobar" under "httplug.clients.acme.plugins.0"');
@@ -309,7 +309,7 @@ public function testInvalidPlugin(): void
 
     public function testInvalidAuthentication(): void
     {
-        $file = __DIR__ . '/../../Resources/Fixtures/config/invalid_auth.yml';
+        $file = __DIR__.'/../../Resources/Fixtures/config/invalid_auth.yml';
 
         $this->expectException(InvalidConfigurationException::class);
         $this->expectExceptionMessage('password, service, username');
@@ -321,7 +321,7 @@ public function testInvalidAuthentication(): void
      */
     public function testInvalidCacheConfig(): void
     {
-        $file = __DIR__ . '/../../Resources/Fixtures/config/invalid_cache_config.yml';
+        $file = __DIR__.'/../../Resources/Fixtures/config/invalid_cache_config.yml';
 
         $this->expectException(InvalidConfigurationException::class);
         $this->expectExceptionMessage('Invalid configuration for path "httplug.plugins.cache.config": You can\'t provide config option "respect_cache_headers" and "respect_response_cache_directives" simultaniously. Use "respect_response_cache_directives" instead.');
@@ -334,7 +334,7 @@ public function testInvalidCacheConfig(): void
     public function testBackwardCompatibility(): void
     {
         $formats = array_map(function ($path) {
-            return __DIR__ . '/../../Resources/Fixtures/' . $path;
+            return __DIR__.'/../../Resources/Fixtures/'.$path;
         }, [
             'config/bc/toolbar.yml',
             'config/bc/toolbar_auto.yml',
@@ -350,7 +350,7 @@ public function testBackwardCompatibility(): void
      */
     public function testCacheConfigDeprecationCompatibility(): void
     {
-        $file = __DIR__ . '/../../Resources/Fixtures/config/bc/cache_config.yml';
+        $file = __DIR__.'/../../Resources/Fixtures/config/bc/cache_config.yml';
         $config = $this->emptyConfig;
         $config['plugins']['cache'] = array_merge($config['plugins']['cache'], [
             'enabled' => true,
@@ -369,7 +369,7 @@ public function testCacheConfigDeprecationCompatibility(): void
      */
     public function testCacheConfigDeprecationCompatibilityIssue166(): void
     {
-        $file = __DIR__ . '/../../Resources/Fixtures/config/bc/issue-166.yml';
+        $file = __DIR__.'/../../Resources/Fixtures/config/bc/issue-166.yml';
         $config = $this->emptyConfig;
         $config['plugins']['cache'] = array_merge($config['plugins']['cache'], [
             'enabled' => true,
@@ -385,7 +385,7 @@ public function testCacheConfigDeprecationCompatibilityIssue166(): void
 
     public function testProfilingToolbarCollision(): void
     {
-        $file = __DIR__ . '/../../Resources/Fixtures/config/bc/profiling_toolbar.yml';
+        $file = __DIR__.'/../../Resources/Fixtures/config/bc/profiling_toolbar.yml';
 
         $this->expectException(InvalidConfigurationException::class);
         $this->expectExceptionMessage('Can\'t configure both "toolbar" and "profiling" section. The "toolbar" config is deprecated as of version 1.3.0, please only use "profiling".');
@@ -394,7 +394,7 @@ public function testProfilingToolbarCollision(): void
 
     public function testClientCacheConfigMustHavePool(): void
     {
-        $file = __DIR__ . '/../../Resources/Fixtures/config/client_cache_config_with_no_pool.yml';
+        $file = __DIR__.'/../../Resources/Fixtures/config/client_cache_config_with_no_pool.yml';
 
         $this->expectException(InvalidConfigurationException::class);
         $this->expectExceptionMessage('The child node "cache_pool" at path "httplug.clients.test.plugins.0.cache" must be configured.');
@@ -403,7 +403,7 @@ public function testClientCacheConfigMustHavePool(): void
 
     public function testCacheConfigMustHavePool(): void
     {
-        $file = __DIR__ . '/../../Resources/Fixtures/config/cache_config_with_no_pool.yml';
+        $file = __DIR__.'/../../Resources/Fixtures/config/cache_config_with_no_pool.yml';
 
         $this->expectException(InvalidConfigurationException::class);
         $this->expectExceptionMessage('The child node "cache_pool" at path "httplug.plugins.cache" must be configured.');
@@ -412,15 +412,15 @@ public function testCacheConfigMustHavePool(): void
 
     public function testLimitlessCapturedBodyLength(): void
     {
-        $file = __DIR__ . '/../../Resources/Fixtures/config/limitless_captured_body_length.yml';
+        $file = __DIR__.'/../../Resources/Fixtures/config/limitless_captured_body_length.yml';
         $config = $this->emptyConfig;
         $config['profiling']['captured_body_length'] = null;
         $this->assertProcessedConfigurationEquals($config, [$file]);
     }
 
     public function testInvalidCapturedBodyLengthString(): void
     {
-        $file = __DIR__ . '/../../Resources/Fixtures/config/invalid_captured_body_length.yml';
+        $file = __DIR__.'/../../Resources/Fixtures/config/invalid_captured_body_length.yml';
 
         $this->expectException(InvalidConfigurationException::class);
         $this->expectExceptionMessage('The child node "captured_body_length" at path "httplug.profiling" must be an integer or null');