removed stopwatch

Author: chr-hertel

DependencyInjection/HttplugExtension.php

@@ -279,11 +279,6 @@ private function configureClient(ContainerBuilder $container, $clientName, array
 
         $pluginClientOptions = [];
         if ($profiling) {
-            // Add the stopwatch plugin
-            if (!in_array('httplug.plugin.stopwatch', $arguments['plugins'])) {
-                array_unshift($plugins, 'httplug.plugin.stopwatch');
-            }
-
             //Decorate each plugin with a ProfilePlugin instance.
             foreach ($plugins as $pluginServiceId) {
                 $this->decoratePluginWithProfilePlugin($container, $pluginServiceId);

Tests/Unit/Collector/ProfileClientFactoryTest.php

@@ -8,6 +8,7 @@
 use Http\HttplugBundle\Collector\Formatter;
 use Http\HttplugBundle\Collector\ProfileClient;
 use Http\HttplugBundle\Collector\ProfileClientFactory;
+use Symfony\Component\Stopwatch\Stopwatch;
 
 class ProfileClientFactoryTest extends \PHPUnit_Framework_TestCase
 {
@@ -21,6 +22,11 @@ class ProfileClientFactoryTest extends \PHPUnit_Framework_TestCase
      */
     private $formatter;
 
+    /**
+     * @var Stopwatch
+     */
+    private $stopwatch;
+
     /**
      * @var HttpClient
      */
@@ -30,6 +36,7 @@ public function setUp()
     {
         $this->collector = $this->getMockBuilder(Collector::class)->disableOriginalConstructor()->getMock();
         $this->formatter = $this->getMockBuilder(Formatter::class)->disableOriginalConstructor()->getMock();
+        $this->stopwatch = $this->getMockBuilder(Stopwatch::class)->getMock();
         $this->client = $this->getMockBuilder(HttpClient::class)->getMock();
     }
 
@@ -38,7 +45,7 @@ public function testCreateClientFromClientFactory()
         $factory = $this->getMockBuilder(ClientFactory::class)->getMock();
         $factory->method('createClient')->willReturn($this->client);
 
-        $subject = new ProfileClientFactory($factory, $this->collector, $this->formatter);
+        $subject = new ProfileClientFactory($factory, $this->collector, $this->formatter, $this->stopwatch);
 
         $this->assertInstanceOf(ProfileClient::class, $subject->createClient());
     }
@@ -49,7 +56,7 @@ public function testCreateClientFromCallable()
             return $this->client;
         };
 
-        $subject = new ProfileClientFactory($factory, $this->collector, $this->formatter);
+        $subject = new ProfileClientFactory($factory, $this->collector, $this->formatter, $this->stopwatch);
 
         $this->assertInstanceOf(ProfileClient::class, $subject->createClient());
     }

Tests/Unit/DependencyInjection/HttplugExtensionTest.php

@@ -117,7 +117,6 @@ public function testClientPlugins()
 
         $plugins = [
             'httplug.client.acme.plugin.stack',
-            'httplug.plugin.stopwatch',
             'httplug.client.acme.plugin.decoder',
             'httplug.plugin.redirect',
             'httplug.client.acme.plugin.add_host',