Merge pull request #186 from fbourigault/deprecate-dummy-client

Deprecate DummyClient

Author: Nyholm

CHANGELOG.md

@@ -8,6 +8,10 @@ The change log describes what is "Added", "Removed", "Changed" or "Fixed" betwee
 
 - Plugins are now displayed with their FQCN instead of service id.
 
+### Deprecated
+
+- The `DummyClient` interface.
+
 ## 1.6.0 - 2017-05-22
 
 ### Added

ClientFactory/DummyClient.php

@@ -2,6 +2,8 @@
 
 namespace Http\HttplugBundle\ClientFactory;
 
+@trigger_error('The '.__NAMESPACE__.'\DummyClient interface is deprecated since version 1.7 and will be removed in 2.0.', E_USER_DEPRECATED);
+
 use Http\Client\HttpAsyncClient;
 use Http\Client\HttpClient;
 

DependencyInjection/HttplugExtension.php

@@ -6,7 +6,7 @@
 use Http\Client\Common\FlexibleHttpClient;
 use Http\Client\Common\HttpMethodsClient;
 use Http\Client\Common\Plugin\AuthenticationPlugin;
-use Http\HttplugBundle\ClientFactory\DummyClient;
+use Http\Client\Common\PluginClient;
 use Http\HttplugBundle\ClientFactory\PluginClientFactory;
 use Http\HttplugBundle\Collector\ProfilePlugin;
 use Http\Message\Authentication\BasicAuth;
@@ -283,7 +283,7 @@ private function configureClient(ContainerBuilder $container, $clientName, array
         }
 
         $container
-            ->register($serviceId, DummyClient::class)
+            ->register($serviceId, PluginClient::class)
             ->setFactory([PluginClientFactory::class, 'createPluginClient'])
             ->addArgument(
                 array_map(