VCR Plugin: Remove it from require-dev.

Also skip the tests which rely on it when the plugin is not installed. The tests are still executed when check httplug 2.x clients.

Author: shulard

.travis.yml

@@ -28,7 +28,7 @@ matrix:
         - php: 7.1
         - php: 7.2
         - php: 7.3
-          env: COVERAGE=true TEST_COMMAND="composer test-ci"
+          env: COVERAGE=true TEST_COMMAND="composer test-ci" DEPENDENCIES="php-http/vcr-plugin:^1.0@dev"
 
           # Test LTS versions
         - php: 7.3
@@ -42,11 +42,11 @@ matrix:
 
           # Test with httplug 2.x clients
         - php: 7.2
-          env: DEPENDENCIES="php-http/guzzle6-adapter:^2.0.1 php-http/curl-client:^2.0.0"
+          env: DEPENDENCIES="php-http/guzzle6-adapter:^2.0.1 php-http/curl-client:^2.0.0 php-http/vcr-plugin:^1.0@dev"
 
           # Latest commit to master
         - php: 7.3
-          env: STABILITY="dev"
+          env: STABILITY="dev" DEPENDENCIES="php-http/vcr-plugin:^1.0@dev"
 
     allow_failures:
           # dev stability is allowed to fail.

composer.json

@@ -53,7 +53,6 @@
         "php-http/guzzle6-adapter": "^1.1.1 || ^2.0.1",
         "php-http/mock-client": "^1.2",
         "php-http/promise": "^1.0",
-        "php-http/vcr-plugin": "^1.0@dev",
         "polishsymfonycommunity/symfony-mocker-container": "^1.0",
         "symfony/browser-kit": "^3.4.20 || ^4.0.15 || ^4.1.9 || ^4.2.1",
         "symfony/cache": "^3.4.20 || ^4.0.15 || ^4.1.9 || ^4.2.1",

tests/Unit/DependencyInjection/HttplugExtensionTest.php

@@ -457,6 +457,10 @@ public function testBatchClientCanBePublic()
      */
     public function testVcrPluginConfiguration(array $config, array $services, array $arguments = [])
     {
+        if (!class_exists(\Http\Client\Plugin\Vcr\Recorder\InMemoryRecorder::class)) {
+            $this->markTestSkipped('VCR plugin is not installed.');
+        }
+
         $prefix = 'httplug.client.acme.vcr';
         $this->load(['clients' => ['acme' => ['plugins' => [['vcr' => $config]]]]]);
         $this->assertContainerBuilderHasService('httplug.plugin.vcr.recorder.in_memory', InMemoryRecorder::class);
@@ -477,6 +481,10 @@ public function testVcrPluginConfiguration(array $config, array $services, array
      */
     public function testIsNotLoadedUnlessNeeded()
     {
+        if (!class_exists(\Http\Client\Plugin\Vcr\Recorder\InMemoryRecorder::class)) {
+            $this->markTestSkipped('VCR plugin is not installed.');
+        }
+
         $this->load(['clients' => ['acme' => ['plugins' => []]]]);
         $this->assertContainerBuilderNotHasService('httplug.plugin.vcr.recorder.in_memory');
     }