Enhancement: Apply void_return fixer to tests

Author: localheinz

tests/Functional/DiscoveredClientsTest.php

@@ -15,7 +15,7 @@
 
 class DiscoveredClientsTest extends WebTestCase
 {
-    public function testDiscoveredClient()
+    public function testDiscoveredClient(): void
     {
         $container = $this->getContainer(false);
 
@@ -26,7 +26,7 @@ public function testDiscoveredClient()
         $this->assertInstanceOf(HttpClient::class, $service);
     }
 
-    public function testDiscoveredAsyncClient()
+    public function testDiscoveredAsyncClient(): void
     {
         $container = $this->getContainer(false);
 
@@ -37,7 +37,7 @@ public function testDiscoveredAsyncClient()
         $this->assertInstanceOf(HttpAsyncClient::class, $service);
     }
 
-    public function testDiscoveredClientWithProfilingEnabled()
+    public function testDiscoveredClientWithProfilingEnabled(): void
     {
         $container = $this->getContainer(true);
 
@@ -49,7 +49,7 @@ public function testDiscoveredClientWithProfilingEnabled()
         $this->assertInstanceOf(HttpClient::class, NSA::getProperty($service, 'client'));
     }
 
-    public function testDiscoveredAsyncClientWithProfilingEnabled()
+    public function testDiscoveredAsyncClientWithProfilingEnabled(): void
     {
         $container = $this->getContainer(true);
 
@@ -64,7 +64,7 @@ public function testDiscoveredAsyncClientWithProfilingEnabled()
     /**
      * Test with httplug.discovery.client: "auto".
      */
-    public function testDiscovery()
+    public function testDiscovery(): void
     {
         $container = $this->getContainer(true);
 
@@ -86,7 +86,7 @@ public function testDiscovery()
     /**
      * Test with httplug.discovery.client: null.
      */
-    public function testDisabledDiscovery()
+    public function testDisabledDiscovery(): void
     {
         $container = $this->getContainer(true, 'discovery_disabled');
 
@@ -98,7 +98,7 @@ public function testDisabledDiscovery()
     /**
      * Test with httplug.discovery.client: "httplug.client.acme".
      */
-    public function testForcedDiscovery()
+    public function testForcedDiscovery(): void
     {
         $container = $this->getContainer(true, 'discovery_forced');
 
@@ -119,7 +119,7 @@ private function getContainer($debug, $environment = 'test')
         return static::$kernel->getContainer();
     }
 
-    protected function setUp()
+    protected function setUp(): void
     {
         parent::setUp();
 

tests/Functional/DiscoveryTest.php

@@ -20,7 +20,7 @@
  */
 final class DiscoveryTest extends AbstractExtensionTestCase
 {
-    protected function setUp()
+    protected function setUp(): void
     {
         parent::setUp();
 
@@ -37,7 +37,7 @@ protected function getContainerExtensions()
         ];
     }
 
-    public function testDiscoveryFallbacks()
+    public function testDiscoveryFallbacks(): void
     {
         $this->load();
 
@@ -48,7 +48,7 @@ public function testDiscoveryFallbacks()
         $this->assertContainerBuilderHasService('httplug.async_client.default', HttpAsyncClient::class);
     }
 
-    public function testDiscoveryPartialFallbacks()
+    public function testDiscoveryPartialFallbacks(): void
     {
         $this->load();
         $this->setDefinition('httplug.client.default', new Definition(Client::class));
@@ -60,7 +60,7 @@ public function testDiscoveryPartialFallbacks()
         $this->assertContainerBuilderHasService('httplug.async_client.default', HttpAsyncClient::class);
     }
 
-    public function testNoDiscoveryFallbacks()
+    public function testNoDiscoveryFallbacks(): void
     {
         $this->setDefinition('httplug.client.default', new Definition(HttpClient::class));
         $this->setDefinition('httplug.message_factory.default', new Definition(MessageFactory::class));
@@ -75,7 +75,7 @@ public function testNoDiscoveryFallbacks()
         $this->assertEquals([HttpClientDiscovery::class, 'find'], $clientDefinition->getFactory());
     }
 
-    public function testEnableAutowiring()
+    public function testEnableAutowiring(): void
     {
         $this->load([
             'default_client_autowiring' => true,
@@ -87,7 +87,7 @@ public function testEnableAutowiring()
         $this->assertContainerBuilderHasAlias(HttpAsyncClient::class);
     }
 
-    public function testDisableAutowiring()
+    public function testDisableAutowiring(): void
     {
         if (PHP_VERSION_ID <= 70000) {
             $this->markTestSkipped();

tests/Functional/Issue206.php

@@ -13,7 +13,7 @@
 
 class Issue206 extends WebTestCase
 {
-    public function testCustomClientDoesNotCauseException()
+    public function testCustomClientDoesNotCauseException(): void
     {
         static::bootKernel();
         $container = static::$kernel->getContainer();

tests/Functional/ProfilerTest.php

@@ -6,7 +6,7 @@
 
 class ProfilerTest extends WebTestCase
 {
-    public function testShowProfiler()
+    public function testShowProfiler(): void
     {
         $client = static::createClient();
 

tests/Functional/ProfilingTest.php

@@ -37,14 +37,14 @@ class ProfilingTest extends TestCase
      */
     private $stopwatch;
 
-    public function setUp()
+    public function setUp(): void
     {
         $this->collector = new Collector([]);
         $this->formatter = new Formatter(new FullHttpMessageFormatter(), new CurlCommandFormatter());
         $this->stopwatch = new Stopwatch();
     }
 
-    public function testProfilingWithCachePlugin()
+    public function testProfilingWithCachePlugin(): void
     {
         $client = $this->createClient([
             new Plugin\CachePlugin(new ArrayAdapter(), StreamFactoryDiscovery::find(), [
@@ -64,7 +64,7 @@ public function testProfilingWithCachePlugin()
         $this->assertEquals('example.com', $stack->getRequestHost());
     }
 
-    public function testProfilingWhenPluginThrowException()
+    public function testProfilingWhenPluginThrowException(): void
     {
         $client = $this->createClient([
             new ExceptionThrowerPlugin(),
@@ -83,7 +83,7 @@ public function testProfilingWhenPluginThrowException()
         }
     }
 
-    public function testProfiling()
+    public function testProfiling(): void
     {
         $client = $this->createClient([
             new Plugin\AddHostPlugin(UriFactoryDiscovery::find()->createUri('https://example.com')),
@@ -122,7 +122,7 @@ class ExceptionThrowerPlugin implements Plugin
 {
     use Plugin\VersionBridgePlugin;
 
-    protected function doHandleRequest(RequestInterface $request, callable $next, callable $first)
+    protected function doHandleRequest(RequestInterface $request, callable $next, callable $first): void
     {
         throw new \Exception();
     }

tests/Functional/ServiceInstantiationTest.php

@@ -24,7 +24,7 @@
 
 class ServiceInstantiationTest extends WebTestCase
 {
-    public function testHttpClient()
+    public function testHttpClient(): void
     {
         static::bootKernel();
         $container = static::$kernel->getContainer();
@@ -33,7 +33,7 @@ public function testHttpClient()
         $this->assertInstanceOf(HttpClient::class, $client);
     }
 
-    public function testHttpClientNoDebug()
+    public function testHttpClientNoDebug(): void
     {
         static::bootKernel(['debug' => false]);
         $container = static::$kernel->getContainer();
@@ -42,7 +42,7 @@ public function testHttpClientNoDebug()
         $this->assertInstanceOf(HttpClient::class, $client);
     }
 
-    public function testDebugToolbar()
+    public function testDebugToolbar(): void
     {
         static::bootKernel(['debug' => true]);
         $container = static::$kernel->getContainer();
@@ -54,15 +54,15 @@ public function testDebugToolbar()
         $this->assertInstanceOf(Collector::class, $collector);
     }
 
-    public function testProfilingShouldNotChangeServiceReference()
+    public function testProfilingShouldNotChangeServiceReference(): void
     {
         static::bootKernel(['debug' => true]);
         $container = static::$kernel->getContainer();
 
         $this->assertInstanceof(RedirectPlugin::class, $container->get('app.http.plugin.custom'));
     }
 
-    public function testProfilingDecoration()
+    public function testProfilingDecoration(): void
     {
         static::bootKernel(['debug' => true]);
         $container = static::$kernel->getContainer();
@@ -81,7 +81,7 @@ public function testProfilingDecoration()
         $this->assertInstanceOf(ProfilePlugin::class, $plugins[4]);
     }
 
-    public function testProfilingPsr18Decoration()
+    public function testProfilingPsr18Decoration(): void
     {
         if (!interface_exists(ClientInterface::class)) {
             $this->markTestSkipped('PSR-18 is not installed');

tests/Resources/app/AppKernel.php

@@ -38,7 +38,7 @@ public function registerBundles()
     /**
      * {@inheritdoc}
      */
-    protected function configureContainer(ContainerBuilder $container, LoaderInterface $loader)
+    protected function configureContainer(ContainerBuilder $container, LoaderInterface $loader): void
     {
         $loader->load(__DIR__.'/config/config_'.$this->getEnvironment().'.yml');
         if ($this->isDebug()) {
@@ -49,7 +49,7 @@ protected function configureContainer(ContainerBuilder $container, LoaderInterfa
     /**
      * {@inheritdoc}
      */
-    protected function configureRoutes(RouteCollectionBuilder $routes)
+    protected function configureRoutes(RouteCollectionBuilder $routes): void
     {
         $routes->import('@WebProfilerBundle/Resources/config/routing/wdt.xml', '/_wdt');
         $routes->import('@WebProfilerBundle/Resources/config/routing/profiler.xml', '/_profiler');
@@ -94,15 +94,15 @@ public function indexAction()
         return new Response();
     }
 
-    protected function build(ContainerBuilder $container)
+    protected function build(ContainerBuilder $container): void
     {
         $container->addCompilerPass(new PublicServicesForFunctionalTestsPass());
     }
 }
 
 class PublicServicesForFunctionalTestsPass implements CompilerPassInterface
 {
-    public function process(ContainerBuilder $container)
+    public function process(ContainerBuilder $container): void
     {
         $services = [
             'httplug.strategy',

tests/Unit/ClientFactory/BuzzFactoryTest.php

@@ -12,7 +12,7 @@
  */
 class BuzzFactoryTest extends TestCase
 {
-    public function testCreateClient()
+    public function testCreateClient(): void
     {
         if (!class_exists(Client::class)) {
             $this->markTestSkipped('Buzz adapter is not installed');

tests/Unit/ClientFactory/CurlFactoryTest.php

@@ -13,7 +13,7 @@
  */
 class CurlFactoryTest extends TestCase
 {
-    public function testCreateClient()
+    public function testCreateClient(): void
     {
         if (!class_exists(Client::class)) {
             $this->markTestSkipped('Curl client is not installed');

tests/Unit/ClientFactory/Guzzle6FactoryTest.php

@@ -11,7 +11,7 @@
  */
 class Guzzle6FactoryTest extends TestCase
 {
-    public function testCreateClient()
+    public function testCreateClient(): void
     {
         if (!class_exists(Client::class)) {
             $this->markTestSkipped('Guzzle6 adapter is not installed');