📦 Add typehint to parameter in private method

Author: andrew-demb

src/DependencyInjection/Configuration.php

@@ -520,7 +520,7 @@ private function createClientPluginNode(): ArrayNodeDefinition
      * @param ArrayNodeDefinition $pluginNode the node to add to
      * @param bool                $disableAll Some shared plugins are enabled by default. On the client, all are disabled by default.
      */
-    private function addSharedPluginNodes(ArrayNodeDefinition $pluginNode, $disableAll = false): void
+    private function addSharedPluginNodes(ArrayNodeDefinition $pluginNode, bool $disableAll = false): void
     {
         $children = $pluginNode->children();
 
@@ -696,7 +696,7 @@ private function createAuthenticationPluginNode(): NodeDefinition
      *
      * @throws InvalidConfigurationException If $actual does not have exactly the keys specified in $expected (plus 'type')
      */
-    private function validateAuthenticationType(array $expected, array $actual, $authName): void
+    private function validateAuthenticationType(array $expected, array $actual, string $authName): void
     {
         unset($actual['type']);
         // Empty array is always provided, even if the config is not filled.

src/DependencyInjection/HttplugExtension.php

@@ -195,7 +195,7 @@ private function configurePlugins(ContainerBuilder $container, array $config): v
      * @param ContainerBuilder $container In case we need to add additional services for this plugin
      * @param string           $serviceId service id of the plugin, in case we need to add additional services for this plugin
      */
-    private function configurePluginByName($name, Definition $definition, array $config, ContainerBuilder $container, $serviceId): void
+    private function configurePluginByName(string $name, Definition $definition, array $config, ContainerBuilder $container, string $serviceId): void
     {
         switch ($name) {
             case 'cache':
@@ -398,10 +398,7 @@ private function configureAuthentication(ContainerBuilder $container, array $con
         return $pluginServices;
     }
 
-    /**
-     * @param string $clientName
-     */
-    private function configureClient(ContainerBuilder $container, $clientName, array $arguments): void
+    private function configureClient(ContainerBuilder $container, string $clientName, array $arguments): void
     {
         $serviceId = 'httplug.client.'.$clientName;
 
@@ -499,7 +496,7 @@ function ($id) {
      * @param string $serviceId Name of the private service to create
      * @param string $uri       String representation of the URI
      */
-    private function createUri(ContainerBuilder $container, $serviceId, $uri): void
+    private function createUri(ContainerBuilder $container, string $serviceId, string $uri): void
     {
         $container
             ->register($serviceId, UriInterface::class)
@@ -555,12 +552,9 @@ public function getConfiguration(array $config, ContainerBuilder $container): ?C
     /**
      * Configure a plugin using the parent definition from plugins.xml.
      *
-     * @param string $serviceId
-     * @param string $pluginName
-     *
      * @return string configured service id
      */
-    private function configurePlugin(ContainerBuilder $container, $serviceId, $pluginName, array $pluginConfig): string
+    private function configurePlugin(ContainerBuilder $container, string $serviceId, string $pluginName, array $pluginConfig): string
     {
         $pluginServiceId = $serviceId.'.plugin.'.$pluginName;
 
@@ -572,7 +566,7 @@ private function configurePlugin(ContainerBuilder $container, $serviceId, $plugi
         return $pluginServiceId;
     }
 
-    private function configureVcrPlugin(ContainerBuilder $container, array $config, $prefix): array
+    private function configureVcrPlugin(ContainerBuilder $container, array $config, string $prefix): array
     {
         $recorder = $config['recorder'];
         $recorderId = in_array($recorder, ['filesystem', 'in_memory']) ? 'httplug.plugin.vcr.recorder.'.$recorder : $recorder;