Don't remove abstract plugins (#247)

These abstract definitions are needed for client plugin definitions,
even if plugins weren't configured at root level.

Removal of unused abstract definitions is job of DI container.

Author: ostrolucky

DependencyInjection/HttplugExtension.php

@@ -127,8 +127,6 @@ private function configurePlugins(ContainerBuilder $container, array $config)
             if ($this->isConfigEnabled($container, $pluginConfig)) {
                 $def = $container->getDefinition($pluginId);
                 $this->configurePluginByName($name, $def, $pluginConfig, $container, $pluginId);
-            } else {
-                $container->removeDefinition($pluginId);
             }
         }
     }

Tests/Resources/Fixtures/config/cache_config_with_no_pool.yml

@@ -0,0 +1,3 @@
+httplug:
+    plugins:
+        cache: ~

Tests/Resources/Fixtures/config/client_cache_config_with_no_pool.yml

@@ -0,0 +1,5 @@
+httplug:
+    clients:
+        test:
+            plugins:
+                - cache: ~

Tests/Unit/DependencyInjection/ConfigurationTest.php

@@ -355,4 +355,24 @@ public function testProfilingToolbarCollision()
         $file = __DIR__.'/../../Resources/Fixtures/config/bc/profiling_toolbar.yml';
         $this->assertProcessedConfigurationEquals([], [$file]);
     }
+
+    /**
+     * @expectedException \Symfony\Component\Config\Definition\Exception\InvalidConfigurationException
+     * @expectedExceptionMessage The child node "cache_pool" at path "httplug.clients.test.plugins.0.cache" must be configured.
+     */
+    public function testClientCacheConfigMustHavePool()
+    {
+        $file = __DIR__.'/../../Resources/Fixtures/config/client_cache_config_with_no_pool.yml';
+        $this->assertProcessedConfigurationEquals([], [$file]);
+    }
+
+    /**
+     * @expectedException \Symfony\Component\Config\Definition\Exception\InvalidConfigurationException
+     * @expectedExceptionMessage The child node "cache_pool" at path "httplug.plugins.cache" must be configured.
+     */
+    public function testCacheConfigMustHavePool()
+    {
+        $file = __DIR__.'/../../Resources/Fixtures/config/cache_config_with_no_pool.yml';
+        $this->assertProcessedConfigurationEquals([], [$file]);
+    }
 }

Tests/Unit/DependencyInjection/HttplugExtensionTest.php

@@ -110,6 +110,11 @@ public function testClientPlugins()
                                 ],
                             ],
                         ],
+                        [
+                            'cache' => [
+                                'cache_pool' => 'my_cache_pool',
+                            ],
+                        ],
                     ],
                 ],
             ],
@@ -124,6 +129,7 @@ public function testClientPlugins()
             'httplug.client.acme.plugin.header_set',
             'httplug.client.acme.plugin.header_remove',
             'httplug.client.acme.authentication.my_basic',
+            'httplug.client.acme.plugin.cache',
         ];
         $pluginReferences = array_map(function ($id) {
             return new Reference($id);