Skip to content

Commit 2a4df41

Browse files
committed
Finishes tests
1 parent 8c0cde7 commit 2a4df41

File tree

1 file changed

+40
-14
lines changed

1 file changed

+40
-14
lines changed

src/HttpAdapterTest.php

Lines changed: 40 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,14 @@ abstract class HttpAdapterTest extends \PHPUnit_Framework_TestCase
4545
*/
4646
protected $defaultOptions;
4747

48+
/**
49+
* @var array
50+
*/
51+
protected $defaultHeaders = [
52+
'Connection' => 'close',
53+
'User-Agent' => 'PHP HTTP Adapter',
54+
];
55+
4856
/**
4957
* {@inheritdoc}
5058
*/
@@ -115,10 +123,10 @@ public function testSendRequest($method, $uri, $protocolVersion, array $headers,
115123
$response,
116124
[
117125
'protocolVersion' => $protocolVersion,
118-
'body' => $method === 'HEAD' ? null : $body,
126+
'body' => $method === 'HEAD' ? null : 'Ok',
119127
]
120128
);
121-
$this->assertRequest($method, $headers, $body);
129+
$this->assertRequest($method, $headers, $body, $protocolVersion);
122130
}
123131

124132
/**
@@ -133,7 +141,7 @@ public function testSendRequests(array $requests)
133141
}
134142

135143
/**
136-
* @dataProvider erroredRequestProvider
144+
* @dataProvider erroredRequestsProvider
137145
* @group integration
138146
*/
139147
public function testSendErroredRequests(array $requests, array $erroredRequests)
@@ -153,8 +161,10 @@ public function testSendErroredRequests(array $requests, array $erroredRequests)
153161
public function testSendWithClientError()
154162
{
155163
$request = self::$messageFactory->createRequest(
156-
'GET',
157-
$this->getClientErrorUri()
164+
$method = 'GET',
165+
$this->getClientErrorUri(),
166+
'1.1',
167+
$this->defaultHeaders
158168
);
159169

160170
$response = $this->httpAdapter->sendRequest($request);
@@ -176,8 +186,10 @@ public function testSendWithClientError()
176186
public function testSendWithServerError()
177187
{
178188
$request = self::$messageFactory->createRequest(
179-
'GET',
180-
$this->getServerErrorUri()
189+
$method = 'GET',
190+
$this->getServerErrorUri(),
191+
'1.1',
192+
$this->defaultHeaders
181193
);
182194

183195
$response = $this->httpAdapter->sendRequest($request);
@@ -199,8 +211,10 @@ public function testSendWithServerError()
199211
public function testSendWithRedirect()
200212
{
201213
$request = self::$messageFactory->createRequest(
202-
'GET',
203-
$this->getRedirectUri()
214+
$method = 'GET',
215+
$this->getRedirectUri(),
216+
'1.1',
217+
$this->defaultHeaders
204218
);
205219

206220
$response = $this->httpAdapter->sendRequest($request);
@@ -225,7 +239,9 @@ public function testSendWithInvalidUri()
225239
{
226240
$request = self::$messageFactory->createRequest(
227241
'GET',
228-
$this->getInvalidUri()
242+
$this->getInvalidUri(),
243+
'1.1',
244+
$this->defaultHeaders
229245
);
230246

231247
$this->httpAdapter->sendRequest($request);
@@ -251,7 +267,7 @@ public function requestProvider()
251267
'methods' => $this->getMethods(),
252268
'uri' => [$this->getUri()],
253269
'protocolVersions' => $this->getProtocolVersions(),
254-
'headers' => [[], $this->getHeaders()],
270+
'headers' => [[$this->defaultHeaders], [array_merge($this->defaultHeaders, $this->getHeaders())]],
255271
'body' => [null, http_build_query($this->getData(), null, '&')],
256272
];
257273

@@ -266,6 +282,7 @@ public function requestProvider()
266282
public function requestsProvider()
267283
{
268284
$requests = [];
285+
$requestList = [];
269286
$messageFactory = MessageFactoryGuesser::guess();
270287

271288
foreach ($this->requestProvider() as $request) {
@@ -278,7 +295,13 @@ public function requestsProvider()
278295
);
279296
}
280297

281-
return array_chunk($requests, 3);
298+
$requests = array_chunk($requests, 3);
299+
300+
foreach ($requests as $threeRequests) {
301+
$requestList[] = [$threeRequests];
302+
}
303+
304+
return $requestList;
282305
}
283306

284307
/**
@@ -367,7 +390,7 @@ private function getUri(array $query = [])
367390
*/
368391
public function getProtocolVersions()
369392
{
370-
return ['1.1', '1.0'];
393+
return ['1.1'];
371394
}
372395

373396
/**
@@ -417,7 +440,10 @@ private function getRedirectUri()
417440
*/
418441
private function getHeaders()
419442
{
420-
return ['Accept-Charset' => 'utf-8', 'Accept-Language:fr'];
443+
return [
444+
'Accept-Charset' => 'utf-8',
445+
'Accept-Language:fr',
446+
];
421447
}
422448

423449
/**

0 commit comments

Comments
 (0)