Do not suggest installation of puli via composer or error messages (#195)

* Do not suggest installation of puli via composer or error messages

* Reorder strategies

Co-authored-by: Nyholm <[email protected]>

Author: naderman

composer.json

@@ -21,7 +21,6 @@
         "puli/composer-plugin": "1.0.0-beta10"
     },
     "suggest": {
-        "puli/composer-plugin": "Sets up Puli which is recommended for Discovery to work. Check http://docs.php-http.org/en/latest/discovery.html for more details.",
         "php-http/message": "Allow to use Guzzle, Diactoros or Slim Framework factories"
     },
     "autoload": {

src/ClassDiscovery.php

@@ -22,9 +22,13 @@ abstract class ClassDiscovery
      * @var array
      */
     private static $strategies = [
-        Strategy\PuliBetaStrategy::class,
         Strategy\CommonClassesStrategy::class,
         Strategy\CommonPsr17ClassesStrategy::class,
+        Strategy\PuliBetaStrategy::class,
+    ];
+
+    private static $deprecatedStrategies = [
+        Strategy\PuliBetaStrategy::class => true,
     ];
 
     /**
@@ -55,7 +59,9 @@ protected static function findOneByType($type)
             try {
                 $candidates = call_user_func($strategy.'::getCandidates', $type);
             } catch (StrategyUnavailableException $e) {
-                $exceptions[] = $e;
+                if (!isset(self::$deprecatedStrategies[$strategy])) {
+                    $exceptions[] = $e;
+                }
 
                 continue;
             }

tests/Exception/InitializeExceptionTest.php

@@ -11,7 +11,6 @@ public function testInitialize()
     {
         $e[] = new DiscoveryException\ClassInstantiationFailedException();
         $e[] = new DiscoveryException\NotFoundException();
-        $e[] = new DiscoveryException\PuliUnavailableException();
         $e[] = new DiscoveryException\StrategyUnavailableException();
         $e[] = new DiscoveryException\NoCandidateFoundException('CommonClasses', []);
         $e[] = DiscoveryException\DiscoveryFailedException::create($e);