Merge pull request #111 from php-http/patch-107b

Add ClassDiscovery::safeClassExists

Author: dbu

src/ClassDiscovery.php

@@ -161,7 +161,7 @@ protected static function evaluateCondition($condition)
     {
         if (is_string($condition)) {
             // Should be extended for functions, extensions???
-            return class_exists($condition);
+            return self::safeClassExists($condition);
         } elseif (is_callable($condition)) {
             return $condition();
         } elseif (is_bool($condition)) {
@@ -205,4 +205,25 @@ protected static function instantiateClass($class)
 
         throw new ClassInstantiationFailedException('Could not instantiate class because parameter is neither a callable nor a string');
     }
+
+    /**
+     * We want to do a "safe" version of PHP's "class_exists" because Magento has a bug
+     * (or they call it a "feature"). Magento is throwing an exception if you do class_exists()
+     * on a class that ends with "Factory" and if that file does not exits.
+     *
+     * This function will catch all potential exceptions and make sure it returns a boolean.
+     *
+     * @param string $class
+     * @param bool   $autoload
+     *
+     * @return bool
+     */
+    public static function safeClassExists($class)
+    {
+        try {
+            return class_exists($class);
+        } catch (\Exception $e) {
+            return false;
+        }
+    }
 }

src/Strategy/PuliBetaStrategy.php

@@ -2,6 +2,7 @@
 
 namespace Http\Discovery\Strategy;
 
+use Http\Discovery\ClassDiscovery;
 use Http\Discovery\Exception\PuliUnavailableException;
 use Puli\Discovery\Api\Discovery;
 use Puli\GeneratedPuliFactory;
@@ -41,7 +42,7 @@ private static function getPuliFactory()
 
             $puliFactoryClass = PULI_FACTORY_CLASS;
 
-            if (!class_exists($puliFactoryClass)) {
+            if (!ClassDiscovery::safeClassExists($puliFactoryClass)) {
                 throw new PuliUnavailableException('Puli Factory class does not exist');
             }