Make tests full and green

Author: GeLoLabs

.travis.yml

@@ -21,6 +21,7 @@ matrix:
 install:
   - travis_retry composer self-update
   - travis_retry composer update ${COMPOSER_FLAGS} --prefer-source --no-interaction
+  - php -S 127.0.0.1:10000 -t vendor/php-http/adapter-integration-tests/fixture
 
 script: vendor/bin/phpunit ${PHPUNIT_FLAGS}
 

src/Guzzle5HttpAdapter.php

@@ -58,7 +58,6 @@ protected function sendInternalRequest(InternalRequestInterface $internalRequest
         try {
             $response = $this->client->send($this->createRequest($internalRequest));
         } catch (\Exception $e) {
-            var_dump($e); exit;
             throw HttpAdapterException::cannotFetchUri(
                 $e->getRequest()->getUrl(),
                 $this->getName(),

tests/Guzzle5CurlHttpAdapterTest.php

@@ -0,0 +1,28 @@
+<?php
+
+/*
+ * This file is part of the Http Adapter package.
+ *
+ * (c) Eric GELOEN <[email protected]>
+ *
+ * For the full copyright and license information, please read the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Http\Adapter\Tests;
+
+use GuzzleHttp\Ring\Client\CurlHandler;
+
+/**
+ * @author GeLo <[email protected]>
+ */
+class Guzzle5CurlHttpAdapterTest extends Guzzle5HttpAdapterTest
+{
+    /**
+     * {@inheritdoc}
+     */
+    protected function createHandler()
+    {
+        return new CurlHandler();
+    }
+}

tests/Guzzle5HttpAdapterTest.php

@@ -12,13 +12,12 @@
 namespace Http\Adapter\Tests;
 
 use GuzzleHttp\Client;
-use GuzzleHttp\Ring\Client\CurlHandler;
 use Http\Adapter\Guzzle5HttpAdapter;
 
 /**
  * @author GeLo <[email protected]>
  */
-class Guzzle5HttpAdapterTest extends HttpAdapterTest
+abstract class Guzzle5HttpAdapterTest extends HttpAdapterTest
 {
     public function testGetName()
     {
@@ -35,9 +34,8 @@ protected function createHttpAdapter()
 
     /**
      * Returns a handler for the client
+     *
+     * @return object
      */
-    protected function createHandler()
-    {
-        return new CurlHandler();
-    }
+    abstract protected function createHandler();
 }

tests/Guzzle5MultiHttpAdapterTest.php renamed to tests/Guzzle5MultiCurlHttpAdapterTest.php

@@ -16,10 +16,10 @@
 /**
  * @author GeLo <[email protected]>
  */
-class Guzzle5MultiHttpAdapterTest extends Guzzle5HttpAdapterTest
+class Guzzle5MultiCurlHttpAdapterTest extends Guzzle5HttpAdapterTest
 {
     /**
-     * Returns a handler for the client
+     * {@inheritdoc}
      */
     protected function createHandler()
     {

tests/Guzzle5StreamHttpAdapterTest.php

@@ -0,0 +1,28 @@
+<?php
+
+/*
+ * This file is part of the Http Adapter package.
+ *
+ * (c) Eric GELOEN <[email protected]>
+ *
+ * For the full copyright and license information, please read the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Http\Adapter\Tests;
+
+use GuzzleHttp\Ring\Client\StreamHandler;
+
+/**
+ * @author GeLo <[email protected]>
+ */
+class Guzzle5StreamHttpAdapterTest extends Guzzle5HttpAdapterTest
+{
+    /**
+     * {@inheritdoc}
+     */
+    protected function createHandler()
+    {
+        return new StreamHandler();
+    }
+}