Merge pull request #7 from Nyholm/patch-3

Added tests for exceptions

Author: sagikazarmark

composer.json

@@ -16,15 +16,16 @@
     ],
     "require": {
         "php": ">=5.4",
-        "php-http/httplug": "^1.0.0-beta",
+        "php-http/httplug": "1.0.0-beta",
         "php-http/discovery": "~0.5",
         "guzzlehttp/guzzle": "^5.1"
     },
     "require-dev": {
         "ext-curl": "*",
         "guzzlehttp/ringphp": "^1.1",
         "php-http/adapter-integration-tests": "dev-master",
-        "php-http/client-common": "^0.1"
+        "php-http/client-common": "^0.1",
+        "guzzlehttp/psr7": "^1.2"
     },
     "provide": {
         "php-http/client-implementation": "1.0"

src/Guzzle5HttpAdapter.php

@@ -16,6 +16,7 @@
 
 /**
  * @author GeLo <[email protected]>
+ * @author Tobias Nyholm <[email protected]>
  */
 class Guzzle5HttpAdapter implements HttpClient
 {

tests/Guzzle5ExceptionTest.php

@@ -0,0 +1,119 @@
+<?php
+
+namespace Http\Adapter\Tests;
+
+use GuzzleHttp\Exception as GuzzleExceptions;
+use GuzzleHttp\Message\Request as GuzzleRequest;
+use GuzzleHttp\Message\Response as GuzzleResponse;
+use GuzzleHttp\Psr7\Request as Psr7Request;
+use GuzzleHttp\Stream\Stream;
+use Http\Adapter\Guzzle5HttpAdapter;
+
+/**
+ * @author Tobias Nyholm <[email protected]>
+ */
+class Guzzle5ExceptionTest extends \PHPUnit_Framework_TestCase
+{
+    private $guzzleRequest;
+    private $guzzleResponse;
+
+    public function setUp()
+    {
+        $this->guzzleRequest = new GuzzleRequest('GET', 'http://foo.com');
+        $this->guzzleResponse = new GuzzleResponse('400', [], Stream::factory('message body'), ['protocol_version'=>'1,1']);
+    }
+
+    protected function makeRequest(GuzzleExceptions\TransferException $exception)
+    {
+        $client = $this->getMock('GuzzleHttp\ClientInterface');
+        $client->expects($this->any())->method('send')->willThrowException($exception);
+        $client->expects($this->any())->method('createRequest')->willReturn($this->guzzleRequest);
+
+        $request = new Psr7Request('GET', 'http://foo.com');
+        (new Guzzle5HttpAdapter($client))->sendRequest($request);
+    }
+
+    public function testConnectException()
+    {
+        // Guzzle's ConnectException should be converted to a NetworkException
+        $this->setExpectedException('Http\Client\Exception\NetworkException');
+        $this->makeRequest(new GuzzleExceptions\ConnectException('foo', $this->guzzleRequest));
+    }
+
+    public function testTooManyRedirectsException()
+    {
+        // Guzzle's TooManyRedirectsException should be converted to a RequestException
+        $this->setExpectedException('Http\Client\Exception\RequestException');
+        $this->makeRequest(new GuzzleExceptions\TooManyRedirectsException('foo', $this->guzzleRequest));
+    }
+
+    public function testRequestException()
+    {
+        // Guzzle's RequestException should be converted to a HttpException
+        $this->setExpectedException('Http\Client\Exception\HttpException');
+        $this->makeRequest(new GuzzleExceptions\RequestException('foo', $this->guzzleRequest, $this->guzzleResponse));
+    }
+
+    public function testRequestExceptionWithoutResponse()
+    {
+        // Guzzle's RequestException with no response should be converted to a RequestException
+        $this->setExpectedException('Http\Client\Exception\RequestException');
+        $this->makeRequest(new GuzzleExceptions\RequestException('foo', $this->guzzleRequest));
+    }
+
+    public function testBadResponseException()
+    {
+        // Guzzle's BadResponseException should be converted to a HttpException
+        $this->setExpectedException('Http\Client\Exception\HttpException');
+        $this->makeRequest(new GuzzleExceptions\BadResponseException('foo', $this->guzzleRequest, $this->guzzleResponse));
+    }
+
+    public function testBadResponseExceptionWithoutResponse()
+    {
+        // Guzzle's BadResponseException with no response should be converted to a RequestException
+        $this->setExpectedException('Http\Client\Exception\RequestException');
+        $this->makeRequest(new GuzzleExceptions\BadResponseException('foo', $this->guzzleRequest));
+    }
+
+    public function testClientException()
+    {
+        // Guzzle's ClientException should be converted to a HttpException
+        $this->setExpectedException('Http\Client\Exception\HttpException');
+        $this->makeRequest(new GuzzleExceptions\ClientException('foo', $this->guzzleRequest, $this->guzzleResponse));
+    }
+
+    public function testClientExceptionWithoutResponse()
+    {
+        // Guzzle's ClientException with no response should be converted to a RequestException
+        $this->setExpectedException('Http\Client\Exception\RequestException');
+        $this->makeRequest(new GuzzleExceptions\ClientException('foo', $this->guzzleRequest));
+    }
+
+    public function testServerException()
+    {
+        // Guzzle's ServerException should be converted to a HttpException
+        $this->setExpectedException('Http\Client\Exception\HttpException');
+        $this->makeRequest(new GuzzleExceptions\ServerException('foo', $this->guzzleRequest, $this->guzzleResponse));
+    }
+
+    public function testServerExceptionWithoutResponse()
+    {
+        // Guzzle's ServerException with no response should be converted to a RequestException
+        $this->setExpectedException('Http\Client\Exception\RequestException');
+        $this->makeRequest(new GuzzleExceptions\BadResponseException('foo', $this->guzzleRequest));
+    }
+
+    public function testTransferException()
+    {
+        // Guzzle's TransferException should be converted to a TransferException
+        $this->setExpectedException('Http\Client\Exception\TransferException');
+        $this->makeRequest(new GuzzleExceptions\TransferException('foo'));
+    }
+
+    public function testParseException()
+    {
+        // Guzzle's ParseException should be converted to a TransferException
+        $this->setExpectedException('Http\Client\Exception\TransferException');
+        $this->makeRequest(new GuzzleExceptions\ParseException('foo', $this->guzzleResponse));
+    }
+}