Merge pull request #54 from php-http/patch-3

dbu · web-flow · commit 312aa49fec29 · 2018-09-09T18:23:13.000+03:00
Using late static binding on a final class makes no sense
diff --git a/src/Client.php b/src/Client.php
@@ -28,7 +28,7 @@ final class Client implements HttpClient, HttpAsyncClient
     public function __construct(ClientInterface $client = null)
     {
         if (!$client) {
-            $client = static::buildClient();
+            $client = self::buildClient();
         }
 
         $this->client = $client;
@@ -43,7 +43,7 @@ public function __construct(ClientInterface $client = null)
      */
     public static function createWithConfig(array $config)
     {
-        return new self(static::buildClient($config));
+        return new self(self::buildClient($config));
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ final class Client implements HttpClient, HttpAsyncClient`
`28`	`28`	`public function __construct(ClientInterface $client = null)`
`29`	`29`	`{`
`30`	`30`	`if (!$client) {`
`31`		`- $client = static::buildClient();`
	`31`	`+ $client = self::buildClient();`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`$this->client = $client;`
`@@ -43,7 +43,7 @@ public function __construct(ClientInterface $client = null)`
`43`	`43`	`*/`
`44`	`44`	`public static function createWithConfig(array $config)`
`45`	`45`	`{`
`46`		`- return new self(static::buildClient($config));`
	`46`	`+ return new self(self::buildClient($config));`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`/**`