Throw PSR-18 exceptions (#62)

Author: gmponos

CHANGELOG.md

@@ -9,6 +9,14 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+### Changed
+- Function `sendRequest` of `\Http\Adapter\Guzzle6\Client` used to throw a `\UnexpectedValueException`. Now it throws a 
+`Http\Adapter\Guzzle6\Exception\UnexpectedValueException` that extends the `\UnexpectedValueException` and implements
+the `Psr\Http\Client\ClientExceptionInterface`. This is done in order to be PSR-18 compliant.
+
+- Function `sendRequest` of `\Http\Adapter\Guzzle6\Client` used to throw a `\RuntimeException`. Now it throws a 
+`Http\Client\Exception\TransferException` that extends the `\RuntimeException` and implements
+the `Psr\Http\Client\ClientExceptionInterface`. This is done in order to be PSR-18 compliant.
 
 ## [2.0.0] - 2018-11-14
 

src/Exception/UnexpectedValueException.php

@@ -0,0 +1,9 @@
+<?php
+
+namespace Http\Adapter\Guzzle6\Exception;
+
+use Http\Client\Exception;
+
+final class UnexpectedValueException extends \UnexpectedValueException implements Exception
+{
+}

src/Promise.php

@@ -4,6 +4,7 @@
 
 use GuzzleHttp\Exception as GuzzleExceptions;
 use GuzzleHttp\Promise\PromiseInterface;
+use Http\Adapter\Guzzle6\Exception\UnexpectedValueException;
 use Http\Client\Exception as HttplugException;
 use Http\Promise\Promise as HttpPromise;
 use Psr\Http\Message\RequestInterface;
@@ -62,9 +63,9 @@ public function __construct(PromiseInterface $promise, RequestInterface $request
             } elseif ($reason instanceof GuzzleExceptions\GuzzleException) {
                 $this->exception = $this->handleException($reason, $request);
             } elseif ($reason instanceof \Throwable) {
-                $this->exception = new \RuntimeException('Invalid exception returned from Guzzle6', 0, $reason);
+                $this->exception = new HttplugException\TransferException('Invalid exception returned from Guzzle6', 0, $reason);
             } else {
-                $this->exception = new \UnexpectedValueException('Reason returned from Guzzle6 must be an Exception');
+                $this->exception = new UnexpectedValueException('Reason returned from Guzzle6 must be an Exception');
             }
 
             throw $this->exception;

tests/PromiseExceptionTest.php

@@ -5,6 +5,7 @@
 namespace Http\Adapter\Guzzle6\Tests;
 
 use GuzzleHttp\Exception as GuzzleExceptions;
+use Http\Adapter\Guzzle6\Exception\UnexpectedValueException;
 use Http\Adapter\Guzzle6\Promise;
 use Http\Client\Exception\HttpException;
 use Http\Client\Exception\NetworkException;
@@ -54,9 +55,9 @@ public function exceptionThatIsThrownForGuzzleExceptionProvider(): array
             [$request, new GuzzleExceptions\ClientException('foo', $request), RequestException::class],
             [$request, new GuzzleExceptions\ServerException('foo', $request), RequestException::class],
             // Non PSR-18 Exceptions thrown
-            [$request, new \Exception('foo'), \RuntimeException::class],
-            [$request, new \Error('foo'), \RuntimeException::class],
-            [$request, 'whatever', \UnexpectedValueException::class],
+            [$request, new \Exception('foo'), TransferException::class],
+            [$request, new \Error('foo'), TransferException::class],
+            [$request, 'whatever', UnexpectedValueException::class],
         ];
     }
 }