Merge pull request #3 from php-http/patch-2

Make tests independent from implementation

Author: Nyholm

phpunit.xml.dist

@@ -34,4 +34,9 @@
       </exclude>
     </whitelist>
   </filter>
+
+    <php>
+        <env name="URI_FACTORY" value=""/>
+        <env name="STREAM_FACTORY" value=""/>
+    </php>
 </phpunit>

src/BaseTest.php

@@ -2,10 +2,71 @@
 
 namespace Http\Psr7Test;
 
+use GuzzleHttp\Psr7\Stream as GuzzleStream;
+use GuzzleHttp\Psr7\Uri as GuzzleUri;
+use Slim\Http\Uri as SlimUri;
+use Zend\Diactoros\Stream as ZendStream;
+use Zend\Diactoros\Uri as ZendUri;
+
+/**
+ * @author Tobias Nyholm <[email protected]>
+ */
 class BaseTest extends \PHPUnit_Framework_TestCase
 {
     protected function assertNotSameObject($a, $b)
     {
         $this->assertFalse($a === $b, 'Object does not have different references.');
     }
+
+    protected function buildUri($uri)
+    {
+        $factory = getenv('URI_FACTORY');
+
+        if (!empty($factory)) {
+            $factoryClass = new $factory();
+            if (!$factoryClass instanceof \Http\Message\UriFactory) {
+                throw new \RuntimeException('Environment variable "URI_FACTORY" must be a reference to a Http\Message\UriFactory');
+            }
+
+            return $factoryClass->createUri($uri);
+        }
+
+        if (class_exists(GuzzleUri::class)) {
+            return new GuzzleUri($uri);
+        }
+
+        if (class_exists(SlimUri::class)) {
+            return SlimUri::createFromString($uri);
+        }
+
+        if (class_exists(ZendUri::class)) {
+            return new ZendUri($uri);
+        }
+
+        throw new \RuntimeException('Could not create URI. Check your config');
+    }
+
+    protected function buildStream($data)
+    {
+        $factory = getenv('STREAM_FACTORY');
+
+        if (!empty($factory)) {
+            $factoryClass = new $factory();
+            if (!$factoryClass instanceof \Http\Message\StreamFactory) {
+                throw new \RuntimeException('Environment variable "STREAM_FACTORY" must be a reference to a Http\Message\StreamFactory');
+            }
+
+            return $factoryClass->createStream($data);
+        }
+
+        if (class_exists(GuzzleStream::class)) {
+            return \GuzzleHttp\Psr7\stream_for($data);
+        }
+
+        if (class_exists(ZendStream::class)) {
+            return new ZendStream($data);
+        }
+
+        throw new \RuntimeException('Could not create Stream. Check your config');
+    }
 }

src/MessageTrait.php

@@ -163,7 +163,7 @@ public function testBody()
         }
 
         $initialMessage = $this->getMessage();
-        $stream = \GuzzleHttp\Psr7\stream_for('foo');
+        $stream = $this->buildStream('foo');
         $message = $initialMessage->withBody($stream);
         $this->assertNotSameObject($initialMessage, $message);
 

src/RequestIntegrationTest.php

@@ -2,7 +2,6 @@
 
 namespace Http\Psr7Test;
 
-use GuzzleHttp\Psr7\Uri;
 use Psr\Http\Message\RequestInterface;
 use Psr\Http\Message\UriInterface;
 
@@ -81,13 +80,13 @@ public function testUri()
 
         $this->assertInstanceOf(UriInterface::class, $this->request->getUri());
 
-        $uri = new Uri('http://www.foo.com/bar');
+        $uri = $this->buildUri('http://www.foo.com/bar');
         $request = $this->request->withUri($uri);
         $this->assertNotSameObject($this->request, $request);
         $this->assertEquals('www.foo.com', $request->getHeaderLine('host'));
         $this->assertEquals('http://www.foo.com/bar', (string) $request->getUri());
 
-        $request = $request->withUri(new Uri('/foobar'));
+        $request = $request->withUri($this->buildUri('/foobar'));
         $this->assertNotSameObject($this->request, $request);
         $this->assertEquals('www.foo.com', $request->getHeaderLine('host'), 'If the URI does not contain a host component, any pre-existing Host header MUST be carried over to the returned request.');
         $this->assertEquals('/foobar', (string) $request->getUri());
@@ -101,7 +100,7 @@ public function testUriPreserveHost_NoHost_Host()
             return;
         }
 
-        $request = $this->request->withUri(new Uri('http://www.foo.com/bar'), true);
+        $request = $this->request->withUri($this->buildUri('http://www.foo.com/bar'), true);
         $this->assertEquals('www.foo.com', $request->getHeaderLine('host'));
     }
 
@@ -114,7 +113,7 @@ public function testUriPreserveHost_NoHost_NoHost()
         }
 
         $host = $this->request->getHeaderLine('host');
-        $request = $this->request->withUri(new Uri('/bar'), true);
+        $request = $this->request->withUri($this->buildUri('/bar'), true);
         $this->assertEquals($host, $request->getHeaderLine('host'));
     }
 
@@ -126,10 +125,10 @@ public function testUriPreserveHost_Host_Host()
             return;
         }
 
-        $request = $this->request->withUri(new Uri('http://www.foo.com/bar'));
+        $request = $this->request->withUri($this->buildUri('http://www.foo.com/bar'));
         $host = $request->getHeaderLine('host');
 
-        $request2 = $request->withUri(new Uri('http://www.bar.com/foo'), true);
+        $request2 = $request->withUri($this->buildUri('http://www.bar.com/foo'), true);
         $this->assertEquals($host, $request2->getHeaderLine('host'));
     }
 }