fix: Split multiple slashes tests into three

- `testPathWithMultipleSlashes()` modified to have a path with multiple slashes only in the middle of the path.
- Renames `testProperlyTrimsLeadingSlashesToPreventXSS()` to `testGetPathNormalizesMultipleLeadingSlashesToSingleSlashToPreventXSS()`, and has it assert only against results of `getPath()`; on completion, it returns an associative array with the expected URI string and the URI instance.
- Adds `testStringRepresentationWithMultipleSlashes()`; depends on `testGetPathNormalizesMultipleLeadingSlashesToSingleSlashToPreventXSS()`, and asserts that the string representation is identical to the original URI string.

Signed-off-by: Matthew Weier O'Phinney <[email protected]>

Author: weierophinney

src/UriIntegrationTest.php

@@ -233,18 +233,38 @@ public function testPathWithMultipleSlashes()
             $this->markTestSkipped($this->skippedTests[__FUNCTION__]);
         }
 
-        $expected = 'http://example.org//valid///path';
+        $expected = 'http://example.org/valid///path';
         $uri = $this->createUri($expected);
 
         $this->assertInstanceOf(UriInterface::class, $uri);
+        $this->assertSame('/valid///path', $uri->getPath());
         $this->assertSame($expected, (string) $uri);
+    }
+
+    public function testGetPathNormalizesMultipleLeadingSlashesToSingleSlashToPreventXSS()
+    {
+        if (isset($this->skippedTests[__FUNCTION__])) {
+            $this->markTestSkipped($this->skippedTests[__FUNCTION__]);
+        }
+
+        $expected = 'http://example.org//valid///path';
+        $uri = $this->createUri($expected);
+
+        $this->assertInstanceOf(UriInterface::class, $uri);
         $this->assertSame('/valid///path', $uri->getPath());
+
+        return [
+            'expected' => $expected,
+            'uri'      => $uri,
+        ];
     }
 
-    public function testProperlyTrimsLeadingSlashesToPreventXSS()
+    /**
+     * @depends testGetPathNormalizesMultipleLeadingSlashesToSingleSlashToPreventXSS
+     * @psalm-param array{expected: non-empty-string, uri: UriInterface} $test
+     */
+    public function testStringRepresentationWithMultipleSlashes(array $test)
     {
-        $url = 'http://example.org//zend.com';
-        $uri = $this->createUri($url);
-        $this->assertSame('http://example.org/zend.com', (string) $uri);
+        $this->assertSame($test['expected'], (string) $test['uri']);
     }
 }