Merge pull request #22 from php-http/patch-invalid-arguments

Adding some tests on invalid arguments

Author: Nyholm

src/MessageTrait.php

@@ -103,6 +103,35 @@ public function testWithHeader()
 
         $message = $initialMessage->withHeader('Content-TYPE', 'text/script');
         $this->assertEquals('text/script', $message->getHeaderLine('content-type'));
+
+        $message = $initialMessage->withHeader('x-foo', ['bar', 'baz']);
+        $this->assertRegExp('|bar, ?baz|', $message->getHeaderLine('x-foo'));
+    }
+
+    /**
+     * @dataProvider getInvalidHeaderArguments
+     */
+    public function testWithHeaderInvalidArguments($name, $value)
+    {
+        if (isset($this->skippedTests[__FUNCTION__])) {
+            $this->markTestSkipped($this->skippedTests[__FUNCTION__]);
+        }
+        $this->expectException(\InvalidArgumentException::class);
+        $initialMessage = $this->getMessage();
+        $initialMessage->withHeader($name, $value);
+    }
+
+    public function getInvalidHeaderArguments()
+    {
+        return [
+            [[], 'foo'],
+            ['foo', []],
+            ['', ''],
+            ['foo', false],
+            [false, 'foo'],
+            ['foo', new \stdClass()],
+            [new \stdClass(), 'foo'],
+        ];
     }
 
     public function testWithAddedHeader()
@@ -117,6 +146,19 @@ public function testWithAddedHeader()
         $this->assertRegExp('|text/html, ?text/plain|', $message->getHeaderLine('Content-Type'));
     }
 
+    /**
+     * @dataProvider getInvalidHeaderArguments
+     */
+    public function testWithAddedHeaderInvalidArguments($name, $value)
+    {
+        if (isset($this->skippedTests[__FUNCTION__])) {
+            $this->markTestSkipped($this->skippedTests[__FUNCTION__]);
+        }
+        $this->expectException(\InvalidArgumentException::class);
+        $initialMessage = $this->getMessage();
+        $initialMessage->withAddedHeader($name, $value);
+    }
+
     /**
      * Make sure we maintain headers when we add array values.
      */

src/RequestIntegrationTest.php

@@ -66,6 +66,28 @@ public function testMethod()
         $this->assertEquals('head', $request->getMethod());
     }
 
+    /**
+     * @dataProvider getInvalidMethods
+     */
+    public function testMethodWithInvalidArguments($method)
+    {
+        if (isset($this->skippedTests[__FUNCTION__])) {
+            $this->markTestSkipped($this->skippedTests[__FUNCTION__]);
+        }
+
+        $this->expectException(\InvalidArgumentException::class);
+        $this->request->withMethod($method);
+    }
+
+    public function getInvalidMethods()
+    {
+        return [
+            [false],
+            [['foo']],
+            [new \stdClass()],
+        ];
+    }
+
     public function testUri()
     {
         if (isset($this->skippedTests[__FUNCTION__])) {

src/ResponseIntegrationTest.php

@@ -47,6 +47,31 @@ public function testStatusCode()
         $this->assertEquals(204, $response->getStatusCode());
     }
 
+    /**
+     * @dataProvider getInvalidStatusCodeArguments
+     */
+    public function testStatusCodeInvalidArgument($statusCode)
+    {
+        if (isset($this->skippedTests[__FUNCTION__])) {
+            $this->markTestSkipped($this->skippedTests[__FUNCTION__]);
+        }
+
+        $this->expectException(\InvalidArgumentException::class);
+        $this->response->withStatus($statusCode);
+    }
+
+    public function getInvalidStatusCodeArguments()
+    {
+        return [
+            [true],
+            ['foobar'],
+            [99],
+            [600],
+            [200.34],
+            [new \stdClass()],
+        ];
+    }
+
     public function testReasonPhrase()
     {
         if (isset($this->skippedTests[__FUNCTION__])) {

src/UriIntegrationTest.php

@@ -38,6 +38,29 @@ public function testScheme()
         $this->assertEquals('http', $newUri->getScheme());
     }
 
+    /**
+     * @dataProvider getInvalidSchemaArguments
+     */
+    public function testWithSchemeInvalidArguments($schema)
+    {
+        if (isset($this->skippedTests[__FUNCTION__])) {
+            $this->markTestSkipped($this->skippedTests[__FUNCTION__]);
+        }
+
+        $this->expectException(\InvalidArgumentException::class);
+        $this->createUri('/')->withScheme($schema);
+    }
+
+    public function getInvalidSchemaArguments()
+    {
+        return [
+            [true],
+            [['foobar']],
+            [34],
+            [new \stdClass()],
+        ];
+    }
+
     public function testAuthority()
     {
         if (isset($this->skippedTests[__FUNCTION__])) {