Merge pull request #11 from php-http/discovery

Discovery support

Author: sagikazarmark

composer.json

@@ -15,12 +15,11 @@
         "php-http/httplug": "^1.0",
         "react/http-client": "^0.4.8",
         "react/dns": "^0.4.1",
-        "react/stream": "^0.4.3"
+        "react/stream": "^0.4.3",
+        "php-http/discovery": "^0.8"
     },
     "require-dev": {
-        "guzzlehttp/psr7": "^1.0",
-        "php-http/adapter-integration-tests": "^0.3.1",
-        "puli/composer-plugin": "1.0.0-beta9"
+        "php-http/adapter-integration-tests": "^0.4"
     },
     "autoload": {
         "psr-4": {

src/Client.php

@@ -2,6 +2,7 @@
 
 namespace Http\Adapter\React;
 
+use Http\Discovery\MessageFactoryDiscovery;
 use Psr\Http\Message\ResponseInterface;
 use React\EventLoop\LoopInterface;
 use React\Promise\Deferred;
@@ -38,7 +39,7 @@ class Client implements HttpClient, HttpAsyncClient
     private $loop;
 
     /**
-     * HttpPlug message factory.
+     * HTTPlug message factory.
      *
      * @var MessageFactory
      */
@@ -47,12 +48,12 @@ class Client implements HttpClient, HttpAsyncClient
     /**
      * Initialize the React client.
      *
-     * @param MessageFactory     $messageFactory
-     * @param LoopInterface|null $loop     React Event loop
-     * @param ReactClient        $client   React client to use
+     * @param MessageFactory|null $messageFactory
+     * @param LoopInterface|null  $loop     React Event loop
+     * @param ReactClient|null    $client   React client to use
      */
     public function __construct(
-        MessageFactory $messageFactory,
+        MessageFactory $messageFactory = null,
         LoopInterface $loop = null,
         ReactClient $client = null
     ) {
@@ -64,7 +65,7 @@ public function __construct(
         $this->loop = (null !== $loop) ?: ReactFactory::buildEventLoop();
         $this->client = (null !== $client) ?: ReactFactory::buildHttpClient($this->loop);
 
-        $this->messageFactory = $messageFactory;
+        $this->messageFactory = $messageFactory ?: MessageFactoryDiscovery::find();
     }
 
     /**

tests/AsyncClientTest.php

@@ -3,9 +3,9 @@
 namespace Http\Adapter\React\Tests;
 
 use Http\Client\HttpClient;
-use Http\Discovery\MessageFactoryDiscovery;
 use Http\Client\Tests\HttpAsyncClientTest;
 use Http\Adapter\React\Client;
+use Http\Message\MessageFactory\GuzzleMessageFactory;
 
 /**
  * @author Stéphane Hulard <[email protected]>
@@ -17,7 +17,6 @@ class AsyncClientTest extends HttpAsyncClientTest
      */
     protected function createHttpAsyncClient()
     {
-        $messageFactory = MessageFactoryDiscovery::find();
-        return new Client($messageFactory);
+        return new Client(new GuzzleMessageFactory());
     }
 }

tests/ClientTest.php

@@ -5,7 +5,7 @@
 use Http\Client\HttpClient;
 use Http\Client\Tests\HttpClientTest;
 use Http\Adapter\React\Client;
-use Http\Discovery\MessageFactoryDiscovery;
+use Http\Message\MessageFactory\GuzzleMessageFactory;
 
 /**
  * @author Stéphane Hulard <[email protected]>
@@ -17,7 +17,6 @@ class ClientTest extends HttpClientTest
      */
     protected function createHttpAdapter()
     {
-        $messageFactory = MessageFactoryDiscovery::find();
-        return new Client($messageFactory);
+        return new Client(new GuzzleMessageFactory());
     }
 }