Add PHPUnit speedtrap, remove slow test that didn't perform any assertions

Author: willemstuursma

composer.json

@@ -35,6 +35,7 @@
         "ext-pdo_mysql": "*",
         "ext-pdo_sqlite": "*",
         "ext-redis": "*",
+        "johnkary/phpunit-speedtrap": "^1.0",
         "kriswallsmith/spork": "^0.3",
         "mikey179/vfsStream": "^1.5.0",
         "php-mock/php-mock-phpunit": "^1",

phpunit.xml

@@ -5,4 +5,7 @@
     <testsuite>
         <directory>tests</directory>
     </testsuite>
+    <listeners>
+        <listener class="JohnKary\PHPUnit\Listener\SpeedTrapListener" />
+    </listeners>
 </phpunit>

tests/mutex/MutexTest.php

@@ -160,36 +160,7 @@ public function testRelease(callable $mutexFactory)
         $mutex->synchronized(function () {
         });
     }
-    
-    /**
-     * Tests that locks will be released automatically.
-     *
-     * @param callable $mutexFactory The Mutex factory.
-     * @test
-     * @dataProvider provideMutexFactories
-     */
-    public function testLiveness(callable $mutexFactory)
-    {
-        $manager = new ProcessManager();
-        $manager->setDebug(true);
-
-        $manager->fork(function () use ($mutexFactory) {
-            $mutex = call_user_func($mutexFactory);
-            $mutex->synchronized(function () {
-                exit;
-            });
-        });
-        $manager->wait();
-        
-        sleep(self::TIMEOUT - 1);
 
-        $mutex = call_user_func($mutexFactory);
-        $mutex->synchronized(function () {
-        });
-
-        $manager->check();
-    }
-    
     /**
      * Tests synchronized() rethrows the exception of the code.
      *

tests/mutex/PredisMutexTest.php

@@ -12,11 +12,11 @@
  *
  * REDIS_URIS - a comma separated list of redis:// URIs.
  *
- * @author Markus Malkusch <[email protected]>
- * @link bitcoin:1P5FAZ4QhXCuwYPnLZdk3PJsqePbu1UDDA Donations
+ * @author  Markus Malkusch <[email protected]>
+ * @link    bitcoin:1P5FAZ4QhXCuwYPnLZdk3PJsqePbu1UDDA Donations
  * @license WTFPL
- * @see PredisMutex
- * @group redis
+ * @see     PredisMutex
+ * @group   redis
  */
 class PredisMutexTest extends \PHPUnit_Framework_TestCase
 {
@@ -28,12 +28,16 @@ class PredisMutexTest extends \PHPUnit_Framework_TestCase
     protected function setUp()
     {
         parent::setUp();
-        
-        $this->client = new Client($this->getPredisConfig());
 
-        if (count($this->getPredisConfig()) == 1) {
-            $this->client->flushall(); // Clear any existing locks
+        $config = $this->getPredisConfig();
+
+        if (null === $config) {
+            $this->markTestSkipped();
+            return;
         }
+
+        $this->client = new Client($config);
+        $this->client->flushall(); // Clear any existing locks
     }
 
     private function getPredisConfig()
@@ -44,27 +48,31 @@ private function getPredisConfig()
 
         $servers = explode(",", getenv("REDIS_URIS"));
 
-        return array_map(function ($redisUri) {
-            return str_replace("redis://", "tcp://", $redisUri);
-        }, $servers);
+        return array_map(
+            function ($redisUri) {
+                return str_replace("redis://", "tcp://", $redisUri);
+            }, $servers
+        );
     }
 
     /**
      * Tests add() fails.
      *
      * @test
-     * @expectedException \malkusch\lock\exception\LockAcquireException
+     * @expectedException     \malkusch\lock\exception\LockAcquireException
      * @expectedExceptionCode \malkusch\lock\exception\MutexException::REDIS_NOT_ENOUGH_SERVERS
      */
     public function testAddFails()
     {
         $client = new Client("redis://127.0.0.1:12345");
 
         $mutex  = new PredisMutex([$client], "test");
-        
-        $mutex->synchronized(function () {
-            $this->fail("Code execution is not expected");
-        });
+
+        $mutex->synchronized(
+            function () {
+                $this->fail("Code execution is not expected");
+            }
+        );
     }
 
     /**