Refactored PHPRedisMutex to extract lzf compression detection.

Author: TheLevti

classes/mutex/PHPRedisMutex.php

@@ -69,15 +69,6 @@ protected function add($redisAPI, string $key, string $value, int $expire): bool
      */
     protected function evalScript($redis, string $script, int $numkeys, array $arguments)
     {
-        // Determine if we need to compress eval arguments.
-        $lzfCompression = false;
-        if (defined("Redis::COMPRESSION_LZF") &&
-            Redis::COMPRESSION_LZF === $redis->getOption(Redis::OPT_COMPRESSION) &&
-            function_exists('lzf_compress')
-        ) {
-            $lzfCompression = true;
-        }
-
         for ($i = $numkeys, $iMax = count($arguments); $i < $iMax; $i++) {
             /* If a serializion mode such as "php" or "igbinary" is enabled, the arguments must be
              * serialized by us, because phpredis does not do this for the eval command.
@@ -87,7 +78,7 @@ function_exists('lzf_compress')
             /* If LZF compression is enabled for the redis connection and the runtime has the LZF
              * extension installed, compress the arguments as the final step.
              */
-            if ($lzfCompression) {
+            if ($this->hasLzfCompression($redis)) {
                 $arguments[$i] = lzf_compress($arguments[$i]);
             }
         }
@@ -98,4 +89,22 @@ function_exists('lzf_compress')
             throw new LockReleaseException("Failed to release lock", 0, $e);
         }
     }
+
+    /**
+     * Determines if lzf compression is enabled for the given connection.
+     *
+     * @param  \Redis|\RedisCluster $redis Redis connection.
+     * @return bool TRUE if lzf comression is enabled, false otherwise.
+     */
+    private function hasLzfCompression($redis): bool
+    {
+        if (\defined('Redis::COMPRESSION_LZF') &&
+            Redis::COMPRESSION_LZF === $redis->getOption(Redis::OPT_COMPRESSION) &&
+            \function_exists('lzf_compress')
+        ) {
+            return true;
+        }
+
+        return false;
+    }
 }